Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

This project is now read‑only. Starting Monday, February 2, please use https://ibm-ceph.atlassian.net/ for all bug tracking management.

Bug 1334534

Summary:	collection split causes orphaned files in filestore causing inconsistent scrubs and crashes on pg removal
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Ken Dreyer (Red Hat) <kdreyer>
Component:	RADOS	Assignee:	Samuel Just <sjust>
Status:	CLOSED ERRATA	QA Contact:	shylesh <shmohan>
Severity:	urgent	Docs Contact:	Bara Ancincova <bancinco>
Priority:	unspecified
Version:	1.3.2	CC:	ceph-eng-bugs, ceph-qe-bugs, dzafman, flucifre, gmeno, hnallurv, kchai, kdreyer, nlevine, sjust, tserlin
Target Milestone:	rc
Target Release:	1.3.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	RHEL: ceph-0.94.7-5.el7cp Ubuntu: ceph_0.94.7-3redhat1trusty	Doc Type:	Bug Fix
Doc Text:	.PG collection split no longer produces any orphaned files Due to a bug in the underlying source code, a placement group (PG) collection split could produce orphaned files. Consequently, the PG could be incorrectly marked as inconsistent during scrubbing, or the OSD nodes could terminate unexpectedly. The bug has been fixed, and PG collection split no longer produces any orphaned files.	Story Points:	---
Clone Of:	1318055	Environment:
Last Closed:	2016-09-29 12:58:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1318055
Bug Blocks:	1372735

Description Ken Dreyer (Red Hat) 2016-05-09 23:20:15 UTC

This clone is to fix this BZ in Hammer / RHCS 1.3.

+++ This bug was initially created as a clone of Bug #1318055 +++

Description of problem:

When a collection split occurs during a collection_move_rename on an ec object, it can result in the old link being orphaned in the parent directory (see the commits for details).  

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create new cluster
2. Create ec pool with one pg.
3. Fill up pool by alternately creating a new object and overwriting an existing object.  All of the objects should have names longer than 300 characters.
4. When the pg collection splits, there should be an orphaned file in the <pgid>_head/ directory for the single pg on the osds with the pg.

Actual results:

4. is proof that the bug happened.  The following symptoms may also occur depending on the exact objects created:

Scrubbing the pg may result in the pg being reported incorrectly as inconsistent.  Removing the orphaned file and re-scrubbing should cause the pg to stop being inconsistent.

Causing the pg mapping to change may cause the ENOTEMPTY crash in the linked bug.  Again, the file remaining in the collection directory will be the orphaned file.

Expected results:

No orphaned file, crashes, or pg inconsistencies.



--- Additional comment from Samuel Just on 2016-03-15 17:52:51 EDT ---

https://github.com/ceph/ceph/pull/8136 -- merged.  Not backported to hammer yet.

--- Additional comment from Samuel Just on 2016-04-08 10:41:56 EDT ---

Still needs backport to hammer.

Comment 1 Samuel Just 2016-06-03 22:34:19 UTC

Penidng https://github.com/ceph/ceph/pull/9277

Comment 2 Ken Dreyer (Red Hat) 2016-06-16 15:12:19 UTC

Change was merged to hammer upstream and will be in v0.94.8.

Comment 4 Ken Dreyer (Red Hat) 2016-08-17 14:14:14 UTC

Sam is there a Teuthology test for this? (how would I find that information myself? Would I see some reference to the upstream Redmine ticket in ceph-qa-suite.git?)

Comment 5 Federico Lucifredi 2016-08-17 22:39:43 UTC

medium priority for 1.3.3. testing.

Comment 10 shylesh 2016-09-13 12:24:49 UTC

Followed the bug description and didn't find any orphan objects or crashed.
Hence marking this as verified.
Verified on 0.94.9-1.el7cp.x86_64

Comment 13 errata-xmlrpc 2016-09-29 12:58:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-1972.html