Bug 1334651 - [RFE] Should not change the virtual machines count every times when enter dashboard page
Summary: [RFE] Should not change the virtual machines count every times when enter das...
Alias: None
Product: ovirt-node
Classification: oVirt
Component: UI
Version: 4.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.0.0-rc
: 4.0
Assignee: Ryan Barry
QA Contact: cshao
Depends On:
TreeView+ depends on / blocked
Reported: 2016-05-10 08:53 UTC by wanghui
Modified: 2016-07-05 07:51 UTC (History)
10 users (show)

Fixed In Version: cockpit-ovirt-dashboard-0.9.1-0.0.1.el7ev
Doc Type: Enhancement
Doc Text:
Clone Of:
Last Closed: 2016-07-05 07:51:20 UTC
oVirt Team: Node
rule-engine: ovirt-4.0.0+
ycui: testing_plan_complete?
mgoldboi: planning_ack+
fdeutsch: devel_ack+
cshao: testing_ack+

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
oVirt gerrit 57323 0 None None None 2016-05-11 02:42:40 UTC

Description wanghui 2016-05-10 08:53:52 UTC
Description of problem:
It should not change the virtual machines count every time when enter dashboard page even if there is no new changes. It always changes from 0 Running to X Running when enter the dashboard page. It should be better just stay on X Running when there is no changes.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Install rhev-hypervisor7-ng-3.6-20160506.0.el7
2. Disable NetworkManager service.
3. Create a virtual machine.
4. Check the dashboard.

Actual results:
1. It always change from 0 Running to 1 Running when enter the dashboard page.

Expected results:
1. It should keep 1 Running until other changes came.

Additional info:

Comment 1 Ryan Barry 2016-05-11 00:31:22 UTC
There is no practical way to fix this.

It's a stateless application which updates the count when a dbus call returns. We cannot keep the state inbetween different pages.

Without blocking the entire page load until it does (bad, and Javascript doesn't like to do this anyway, since the dbus object returns promises), the available solutions are:

Use some placeholder text (but that will also get updated almost immediately).

Use redux as a backend, but that's low priority.

Fabian, can you devel_ack- this, or retarget to 4.1 (where we'll have time to implement redux)?

Comment 2 Ryan Barry 2016-05-11 02:42:05 UTC
I tested -- we can block showing that element until we get a response. This way the count of VMs will not change from 0->$number (though starting/stopping VMs will still change the count)

I'd really rather not block the entire page, though, for a variety of reasons.

Does that work?

Comment 3 Fabian Deutsch 2016-05-11 07:33:49 UTC
Just for considerations, what about showing a placeholder until the count is available, i.e.

- ?
- ⋯

But only showing the element once the count is available works for me too.

Comment 4 wanghui 2016-06-02 05:22:44 UTC
Test version:

Test steps:
1. Install rhev-hypervisor7-ng-3.6-20160527.0
2. Create a virtual machine.
3. Check the dashboard.

Test result:
1. The Virtual Machines's summary page is blocked before get the latest status.

Hi Ryan,

For this issue, the vm's whole summary page is blocked before get the latest status. So every time when enter this page, the page will changed from without VM's column to have it. Do you think it's better to add a loading icon as a placeholder when waiting of a update?


Comment 5 Ryan Barry 2016-06-02 11:52:29 UTC
This should be a small UX change.

I am ok with adding a small loading icon (I'll push a patch up), but it shouldn't be necessary for verification of this bug, in my opinion.

Comment 6 wanghui 2016-06-03 03:21:49 UTC
Verify this issue due to comment#4&5.

Comment 9 Sandro Bonazzola 2016-07-05 07:51:20 UTC
oVirt 4.0.0 has been released, closing current release.

Note You need to log in before you can comment on or make changes to this bug.