Red Hat Bugzilla – Bug 133485
Lots of code duplication in different scripts in xinitrc package
Last modified: 2007-11-30 17:10:49 EST
The "Xsession" and "xinitrc" scripts in the xinitrc package
share a lot of identical shell scripting snippits. This is very
bad because bugs have to be fixed in multiple locations as they
are discovered, and there's lots of room for human error in keeping
Querying bugzilla for all xinitrc bugs, shows that this has caused
a number of problems in the past also, which confirms my theory,
in addition to the obvious common sense of not having code
We should fix this by either merging common code into a single
script which gets called by both scripts, or by turning both
scripts into a single dual-purpose script. Both have advantages
that I can think of.
I'm logging this here for now, as I'm not going to fix this
immediately, but do not want to forget about it.
I've factored out the common code from Xsession and xinitrc into
a new script 'xinitrc-common' which is sourced from both. In the
process I cleaned up the code, and made sure any bug fixes from
either of the originals were merged into the new common code.
This will be present in build xinitrc-4.0.8-1 in rawhide soon.
xinitrc-4.0.9-1 in rawhide contains the newly factored out script