Spec URL: http://people.parinux.org/~seyman/fedora/perl-String-Dirify/perl-String-Dirify.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-String-Dirify/perl-String-Dirify-1.03-1.fc23.src.rpm Description: This module allows you to convert a string (possibly containing high ASCII characters, and even HTML) into another, lower-cased, string which can be used as a directory name. Fedora Account System Username: eseyman Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings. This is one of several new packages needed to bring Pearlbee to Fedora.
Standalone and packages spec files differ. I will use the standalone one as it seems more correct because it does not build-require Test::Pod module. URL and Source0 addresses are usable. Ok. Source archive (SHA-256: 8e66374ade8b447ba94d276616973ef8a249e5b6258b81662142daa712329d53) is original. Ok. FIX: The summary is a dummy text. Please use a tesx from lib/String/Dirify.pm POD (Convert a string into a directory name). Summary verified from lib/String/Dirify.pm. Ok. License verified from Makefile.PL and LICENSE. Ok. No XS code, noarch BuildArch is Ok. FIX: Build-require `perl' (perl-String-Dirify.spec:16). FIX: Build-require `perl-generators'. FIX: Build-require `make' (perl-String-Dirify.spec:30). All tests pass. Ok. $ rpmlint perl-String-Dirify.spec ../SRPMS/perl-String-Dirify-1.03-1.fc25.src.rpm ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm drwxr-xr-x 2 root root 0 May 13 14:20 /usr/share/doc/perl-String-Dirify -rw-r--r-- 1 root root 996 May 11 01:36 /usr/share/doc/perl-String-Dirify/Changes -rw-r--r-- 1 root root 2406 Nov 16 2010 /usr/share/doc/perl-String-Dirify/README drwxr-xr-x 2 root root 0 May 13 14:20 /usr/share/licenses/perl-String-Dirify -rw-r--r-- 1 root root 20231 May 11 01:28 /usr/share/licenses/perl-String-Dirify/LICENSE -rw-r--r-- 1 root root 2308 May 13 14:20 /usr/share/man/man3/String::Dirify.3pm.gz drwxr-xr-x 2 root root 0 May 13 14:20 /usr/share/perl5/vendor_perl/String -rw-r--r-- 1 root root 6901 May 11 01:39 /usr/share/perl5/vendor_perl/String/Dirify.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.2) 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(String::Dirify) = 1.03 1 perl-String-Dirify = 1.03-1.fc25 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14042709). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items and provide a new spec file. Resolution: Package NOT approved.
(In reply to Petr Pisar from comment #1) > Standalone and packages spec files differ. I will use the standalone one as > it seems more correct because it does not build-require Test::Pod module. Dammit... Sorry about that. > FIX: The summary is a dummy text. Please use a tesx from > lib/String/Dirify.pm POD (Convert a string into a directory name). Done. > FIX: Build-require `perl' (perl-String-Dirify.spec:16). > FIX: Build-require `perl-generators'. > FIX: Build-require `make' (perl-String-Dirify.spec:30). Done. > Please correct all `FIX' items and provide a new spec file. > Resolution: Package NOT approved. Spec URL: http://people.parinux.org/~seyman/fedora/perl-String-Dirify/perl-String-Dirify.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-String-Dirify/perl-String-Dirify-1.03-2.fc23.src.rpm
Spec file changes: --- perl-String-Dirify.spec.old 2016-05-11 11:57:47.000000000 +0200 +++ perl-String-Dirify.spec 2016-05-14 22:51:02.000000000 +0200 @@ -1,13 +1,16 @@ Name: perl-String-Dirify Version: 1.03 -Release: 1%{?dist} -Summary: String::Dirify Perl module +Release: 2%{?dist} +Summary: Convert a string into a directory name License: GPL+ or Artistic URL: http://search.cpan.org/dist/String-Dirify/ Source0: http://www.cpan.org/authors/id/R/RS/RSAVAGE/String-Dirify-%{version}.tgz BuildArch: noarch +BuildRequires: make +BuildRequires: perl +BuildRequires: perl-generators BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Test::More) @@ -43,6 +46,9 @@ %{_mandir}/man3/String* %changelog +* Sat May 14 2016 Emmanuel Seyman <emmanuel> - 1.03-2 +- Take into account review comments (#1335076) + * Wed May 11 2016 Emmanuel Seyman <emmanuel> - 1.03-1 - Update to 1.03, released under the Perl 5 license $ rpmlint perl-String-Dirify.spec ../SRPMS/perl-String-Dirify-1.03-2.fc25.src.rpm ../RPMS/noarch/perl-String-Dirify-1.03-2.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14104390). Ok. Package is good. Resolution: Package APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-String-Dirify
Package built for rawhide and updates issued for F24 and F23. Petr, thank you for the review. KJon, thanks for the git repo.