Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.173-1.fc23.src.rpm Description: with the latest changes to Fedora policy on emulators and to mame licensing, I believe mame should now be acceptable in Fedora. Mame RPM has been residing in RPM Fusion for the last few years, and in dribble.co.uk prior to that. Fedora Account System Username: belegdol
Are game emulators now permitted on Fedora ?
Yes, they are, provided they don't require copyright infringement to function (e.g. require system ROMs from the original hardware). See: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/OCIB2WAZ6DF3HJZV2OWYOTNRTUZZ6VRX/ And also see: https://fedoraproject.org/wiki/Licensing:SoftwareTypes#Emulators
http://mamedev.org/downloader.php?file=%{name}0%{baseversion}/%{name}0%{baseversion}s.exe You are using a pre-compiled file for Windows. Why not the source code instead ?
It is a 7zip self extracting archive of the source code, it is considerably smaller than the zip archive.
Is there any valid reason to provide those bundled libraries ?
bgfx is not made to be linked to dynamically as per [1]. http-parser got dropped from upstream git and will be removed in 0.175 lsqlite3 got dropped from upstream git and will be removed in 0.175 luafilesystem and lua-zlib have no fedora packages ATM and are very tiny luv on anything but rawhide is too old lzma is not made to be linked dynamically softfloat is not made to be linked dynamically [1] http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=104437
(In reply to Julian Sikorski from comment #6) > bgfx is not made to be linked to dynamically as per [1]. > http-parser got dropped from upstream git and will be removed in 0.175 > lsqlite3 got dropped from upstream git and will be removed in 0.175 > luafilesystem and lua-zlib have no fedora packages ATM and are very tiny > luv on anything but rawhide is too old > lzma is not made to be linked dynamically > softfloat is not made to be linked dynamically > > [1] http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=104437 Please, leave a comment about Provides lines. Just another issue: locale files are not managed by %find_lang. http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
For the source, why not use the tarball URL? https://github.com/mamedev/%{name}/archive/%{name}0174.tar.gz Your %setup invocation will look like this: %setup -n %{name}-%{name}0174
(In reply to Antonio Trande from comment #7) > (In reply to Julian Sikorski from comment #6) > > bgfx is not made to be linked to dynamically as per [1]. > > http-parser got dropped from upstream git and will be removed in 0.175 > > lsqlite3 got dropped from upstream git and will be removed in 0.175 > > luafilesystem and lua-zlib have no fedora packages ATM and are very tiny > > luv on anything but rawhide is too old > > lzma is not made to be linked dynamically > > softfloat is not made to be linked dynamically > > > > [1] http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=104437 > > Please, leave a comment about Provides lines. Will do. > > Just another issue: locale files are not managed by %find_lang. > http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files This will not work unfortunately, I tried. %find_lang looks for .mo files in %{_datadir}/locale, whereas mame puts them into %{_datadir}/%{name}. (In reply to Neal Gompa from comment #8) > For the source, why not use the tarball URL? > > https://github.com/mamedev/%{name}/archive/%{name}0174.tar.gz > > Your %setup invocation will look like this: > > %setup -n %{name}-%{name}0174 The tar.gz is 33 MiB bigger than the .exe (102 vs 69). Having said that, the Source URL needs to be updated to point to github indeed. New packages have been uploaded: Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-2.fc23.src.rpm
> This will not work unfortunately, I tried. %find_lang looks for .mo files in > %{_datadir}/locale, whereas mame puts them into %{_datadir}/%{name}. Let me check if we can do something. > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-2.fc23.src.rpm https://belegdol.fedorapeople.org/mame/mame-0.174-2.fc24.src.rpm is failed on rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=14483994 Compiler/linker flags are confused during build, please try to make them uniform in order to activate all flags for "hardened" builds. For example: '--pipe' looks wrong '-g1' is not default debugging level in Fedora '-fno-omit-frame-pointer -fno-optimize-sibling-calls': activated by default '-O2' flag but disabled. At the moment, all binary files are "No Full Relro" and "Not PIE" (see https://fedoraproject.org/wiki/Changes/Harden_All_Packages).
This is quite strange, as mame used to build at F23 as late as at least 0.171 and F23 includes the hardening change. I will investigate.
https://koji.kwizart.net/koji/packageinfo?packageID=213
New packages have been uploaded: Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-3.fc23.src.rpm I have cleaned up the compiler and linker flags, mame builds on F24. Some of the flags are duplicated, coming from mame build config and from %{optflags}. I have checked and they should always be the same. The failure on rawhide is caused by glibc change, I have filed an upstream bug about this [1] [1] https://github.com/mamedev/mame/issues/953
Please turn off the lowmem build conditional, as that doesn't apply to Fedora builders.
(In reply to Julian Sikorski from comment #13) > New packages have been uploaded: > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-3.fc23.src.rpm > Your package are now f24. :) Wrong flags are still there. I'm attaching my spec file (with some modifications) and a couple of patches. Log: - Unset useless compiler flags - lowmem conditional disabled - Use %%license - Remove bundled files - Set directory of jpeglib.h from system - Conditional installations according to system bit
Created attachment 1168391 [details] spec file
Created attachment 1168392 [details] proposed patch 1
Created attachment 1168393 [details] proposed patch 2
Created attachment 1168514 [details] spec file 2 New spec file. '-g' looks cause a 'memory' error during linkage. Debugging flag downgraded to '-g1'.
Hi, anyway shouldn't we block FE-Legal tracker [1] ? [1] https://bugzilla.redhat.com/show_bug.cgi?id=FE-Legal
New packages have been uploaded: Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-4.fc23.src.rpm Changes: - Ensured Fedora compiler and linker flags are applied to genie as well - Added 3rdparty/ cleanup statement - Dropped SIMD and low memory conditionals - Separated LICENSE.md to %%license - Ensured genie is built using system lua - Downgraded debug flags to -g1 I took a bit different approach for some of the changes you proposed: - the conditional install seems very convoluted as opposed to || used in my spec - -fno-strict-aliasing is actually required, please see [1] mame built fine on i686 and x86_64 without fiddling with smpflags so far, please see [2]. [1] http://forums.bannister.org/ubbthreads.php?ubb=showflat&Number=58738 [2] https://koji.fedoraproject.org/koji/taskinfo?taskID=14521891
(In reply to Julian Sikorski from comment #21) > New packages have been uploaded: > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-4.fc23.src.rpm > Again ... Your fc23.src.rpm links are broken.
Package rebuilt on f24. We need to fix rawhide builds. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Some source files (involved in the building) are released under LGPLv2+ license src/mame/audio/snes_snd.cpp: LGPL (v2 or later) src/devices/sound/tiasound.cpp: LGPL (v2) (with incorrect FSF address) src/devices/sound/tiasound.h: LGPL (v2) (with incorrect FSF address) source code 3rdparty/bgfx under ASL 2.0 artwork under CC0 license definitions for BGFX under BSD plugins/json under MIT license keymaps under CC0 license hash under CC0 docs/* under CC0 All these licenses can be condensed as ** License: GPLv2+ and LGPLv2+ and ASL 2.0 ** But license files are not packaged: ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/plugins/json/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/artwork/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/bgfx/effects/hlsl/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/bgfx/effects/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/bgfx/effects/unfiltered/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/bgfx/effects/default/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/bgfx/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/bgfx/chains/LICENSE ./mame-data-0.174-4.fc24.noarch.rpm/usr/share/mame/keymaps/LICENSE ./mame-data-software-lists-0.174-4.fc24.noarch.rpm/usr/share/mame/hash/LICENSE - *data* sub-package is noarch and it's required by *tools*, *mame*, *data-software-lists*; *data* and just it can provide all doc/license files. *ldplayer* is a stand-alone sub-package: it must provide an own license file. *tools* requires an arched package so needs Requires: %{name}%{?_isa} = %{version}-%{release} ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 204800 bytes in 12 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/mamedev/mame/releases/download/mame0174/mame0174s.exe See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mame- tools , mame-ldplayer , mame-data , mame-data-software-lists , mame- debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mame-0.174-4.fc24.x86_64.rpm mame-tools-0.174-4.fc24.x86_64.rpm mame-ldplayer-0.174-4.fc24.x86_64.rpm mame-data-0.174-4.fc24.noarch.rpm mame-data-software-lists-0.174-4.fc24.noarch.rpm mame-debuginfo-0.174-4.fc24.x86_64.rpm mame-0.174-4.fc24.src.rpm mame.x86_64: W: hidden-file-or-dir /etc/skel/.mame mame-tools.x86_64: W: no-manual-page-for-binary mame-regrep mame-tools.x86_64: W: no-manual-page-for-binary nltool mame-tools.x86_64: W: no-manual-page-for-binary mame-src2html mame-tools.x86_64: W: no-manual-page-for-binary mame-srcclean mame-tools.x86_64: W: no-manual-page-for-binary unidasm mame-tools.x86_64: W: no-manual-page-for-binary nlwav mame-tools.x86_64: W: no-manual-page-for-binary mame-split mame-tools.x86_64: W: no-manual-page-for-binary pngcmp mame-ldplayer.x86_64: W: spelling-error Summary(en_US) laserdisc -> laser disc, laser-disc, disclose mame-ldplayer.x86_64: W: spelling-error %description -l en_US laserdisc -> laser disc, laser-disc, disclose mame-data.noarch: W: no-documentation mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq2x.json mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq4x.json mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq3x.json mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Afrikaans/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Albanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Arabic/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Basque/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Belarusian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Bosnian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Bulgarian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Burmese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Catalan/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Chinese_Simplified/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Chinese_Traditional/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Croatian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Czech/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Danish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Dutch/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/English/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Estonian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Finnish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French_Belgium/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French_Canada/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Georgian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/German/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Greek/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hebrew/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hindi/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hungarian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Indonesian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Italian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Japanese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Korean/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Latvian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Lithuanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Macedonian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Norwegian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Persian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Polish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Portuguese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Portuguese_Brazil/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Romanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Russian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Serbian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Serbian_Cyrillic/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Slovak/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Slovenian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Spanish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Spanish_Mexico/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Swedish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Thai/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Turkish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Ukrainian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Vietnamese/strings.mo mame-data-software-lists.noarch: W: spelling-error %description -l en_US subpackage -> sub package, sub-package, package's mame-data-software-lists.noarch: W: no-documentation mame.src:1: W: macro-in-comment %bcond_with mame.src:42: W: unversioned-explicit-provides bundled(bgfx) mame.src:44: W: unversioned-explicit-provides bundled(http-parser) mame.src:46: W: unversioned-explicit-provides bundled(lsqlite3) mame.src:48: W: unversioned-explicit-provides bundled(luafilesystem) mame.src:49: W: unversioned-explicit-provides bundled(lua-zlib) mame.src:57: W: unversioned-explicit-provides bundled(softfloat) mame.src: W: invalid-url Source0: https://github.com/mamedev/mame/releases/download/mame0174/mame0174s.exe HTTP Error 403: Forbidden 7 packages and 0 specfiles checked; 3 errors, 74 warnings. Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory mame-tools.x86_64: W: no-manual-page-for-binary unidasm mame-tools.x86_64: W: no-manual-page-for-binary nltool mame-tools.x86_64: W: no-manual-page-for-binary nlwav mame-tools.x86_64: W: no-manual-page-for-binary mame-src2html mame-tools.x86_64: W: no-manual-page-for-binary mame-split mame-tools.x86_64: W: no-manual-page-for-binary mame-srcclean mame-tools.x86_64: W: no-manual-page-for-binary mame-regrep mame-tools.x86_64: W: no-manual-page-for-binary pngcmp mame-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mame-0.174/src/lib/util/sha1.cpp mame-data-software-lists.noarch: W: spelling-error %description -l en_US subpackage -> sub package, sub-package, package's mame-data-software-lists.noarch: W: no-documentation mame-data.noarch: W: no-documentation mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq4x.json mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq3x.json mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq2x.json mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Afrikaans/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Albanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Arabic/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Basque/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Belarusian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Bosnian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Bulgarian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Burmese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Catalan/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Chinese_Simplified/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Chinese_Traditional/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Croatian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Czech/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Danish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Dutch/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/English/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Estonian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Finnish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French_Belgium/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French_Canada/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Georgian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/German/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Greek/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hebrew/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hindi/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hungarian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Indonesian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Italian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Japanese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Korean/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Latvian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Lithuanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Macedonian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Norwegian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Persian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Polish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Portuguese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Portuguese_Brazil/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Romanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Russian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Serbian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Serbian_Cyrillic/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Slovak/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Slovenian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Spanish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Spanish_Mexico/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Swedish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Thai/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Turkish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Ukrainian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Vietnamese/strings.mo mame.x86_64: W: hidden-file-or-dir /etc/skel/.mame mame-ldplayer.x86_64: W: spelling-error Summary(en_US) laserdisc -> laser disc, laser-disc, disclose mame-ldplayer.x86_64: W: spelling-error %description -l en_US laserdisc -> laser disc, laser-disc, disclose 6 packages and 0 specfiles checked; 4 errors, 66 warnings. Requires -------- mame-tools (rpmlib, GLIBC filtered): libFLAC.so.8()(64bit) libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libutil.so.1()(64bit) libz.so.1()(64bit) mame rtld(GNU_HASH) mame-debuginfo (rpmlib, GLIBC filtered): mame-data-software-lists (rpmlib, GLIBC filtered): mame-data mame-data (rpmlib, GLIBC filtered): mame (rpmlib, GLIBC filtered): config(mame) libFLAC.so.8()(64bit) libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_ttf-2.0.so.0()(64bit) libX11.so.6()(64bit) libXinerama.so.1()(64bit) libasound.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblua-5.3.so()(64bit) libm.so.6()(64bit) libportmidi.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libutil.so.1()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.2)(64bit) mame-data rtld(GNU_HASH) mame-ldplayer (rpmlib, GLIBC filtered): libFLAC.so.8()(64bit) libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_ttf-2.0.so.0()(64bit) libX11.so.6()(64bit) libXinerama.so.1()(64bit) libasound.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblua-5.3.so()(64bit) libm.so.6()(64bit) libportmidi.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libutil.so.1()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.2)(64bit) rtld(GNU_HASH) Provides -------- mame-tools: mame-tools mame-tools(x86-64) mame-debuginfo: mame-debuginfo mame-debuginfo(x86-64) mame-data-software-lists: mame-data-software-lists mame-data: mame-data mess-data mame: bundled(bgfx) bundled(http-parser) bundled(lsqlite3) bundled(lua-zlib) bundled(luafilesystem) bundled(luv) bundled(lzma-sdk) bundled(softfloat) config(mame) mame mame(x86-64) mame-ldplayer: mame-ldplayer mame-ldplayer(x86-64) Source checksums ---------------- http://mamedev.org/releases/whatsnew_0174.txt : CHECKSUM(SHA256) this package : 77fc1de9e114a2d2b8fccef1dbc154baf56e78069b37d6e9af01e026bd9b621e CHECKSUM(SHA256) upstream package : 77fc1de9e114a2d2b8fccef1dbc154baf56e78069b37d6e9af01e026bd9b621e Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-24-x86_64 -rn mame-0.174-4.fc24.src.rpm Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Antonio Trande from comment #23) > - Some source files (involved in the building) are released > > under LGPLv2+ license > src/mame/audio/snes_snd.cpp: LGPL (v2 or later) > src/devices/sound/tiasound.cpp: LGPL (v2) (with incorrect FSF address) > src/devices/sound/tiasound.h: LGPL (v2) (with incorrect FSF address) > > source code 3rdparty/bgfx under ASL 2.0 > > artwork under CC0 license > > definitions for BGFX under BSD > > plugins/json under MIT license > > keymaps under CC0 license > > hash under CC0 > > docs/* under CC0 > > All these licenses can be condensed as > > ** License: GPLv2+ and LGPLv2+ and ASL 2.0 ** Fedora guidelines require to specify the License tag and that is the license of the contents of the *binary* RPM (and therefore it is not a list of licenses found in source files): https://fedoraproject.org/wiki/Packaging:LicensingGuidelines Therefore the license is GPLv2+.
(In reply to Andrea Musuruane from comment #24) > (In reply to Antonio Trande from comment #23) > > - Some source files (involved in the building) are released > > > > under LGPLv2+ license > > src/mame/audio/snes_snd.cpp: LGPL (v2 or later) > > src/devices/sound/tiasound.cpp: LGPL (v2) (with incorrect FSF address) > > src/devices/sound/tiasound.h: LGPL (v2) (with incorrect FSF address) > > > > source code 3rdparty/bgfx under ASL 2.0 > > > > artwork under CC0 license > > > > definitions for BGFX under BSD > > > > plugins/json under MIT license > > > > keymaps under CC0 license > > > > hash under CC0 > > > > docs/* under CC0 > > > > All these licenses can be condensed as > > > > ** License: GPLv2+ and LGPLv2+ and ASL 2.0 ** > > Fedora guidelines require to specify the License tag and that is the license > of the contents of the *binary* RPM (and therefore it is not a list of > licenses found in source files): > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines > > Therefore the license is GPLv2+. It's a Mixed Source Licensing Scenario: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario These ones > > artwork under CC0 license > > > > definitions for BGFX under BSD > > > > plugins/json under MIT license > > > > keymaps under CC0 license > > > > hash under CC0 > > > > docs/* under CC0 are licenses of data files, not listed with License tag.
I am sorry for the delay, new packages have been uploaded: Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.174-5.fc24.src.rpm Changes: - Updated the License tag - Made ldplayer dependent on the main package - Dropped leftover mess-data provides - Moved documentation to -data subpackage - Made -data and -ldplayer Required arched I am not sure what do you mean about LICENSE files not being packaged - the 10 LICENSE files are actually part of mame-data and mame-data-software-lists. Please may you elaborate?
(In reply to Julian Sikorski from comment #26) > I am not sure what do you mean about LICENSE files not being packaged - the > 10 LICENSE files are actually part of mame-data and > mame-data-software-lists. Please may you elaborate? Are part of mame-data but not tagged with %license (this macro pushes license files in /usr/share/licenses/package_name). I think you should rename them by indicating the type of license and tag them with %license. > - Made ldplayer dependent on the main package Does 'ldplayer' really depend by 'mame' package ?
(In reply to Antonio Trande from comment #27) > (In reply to Julian Sikorski from comment #26) > > I am not sure what do you mean about LICENSE files not being packaged - the > > 10 LICENSE files are actually part of mame-data and > > mame-data-software-lists. Please may you elaborate? > > Are part of mame-data but not tagged with %license (this macro pushes > license files in /usr/share/licenses/package_name). > > I think you should rename them by indicating the type of license and tag > them with %license. I am not completely convinced... As things stand now, it is clear which LICENSE file applies to which folder. If everything goes to %licensedir, this information will be lost. > > > - Made ldplayer dependent on the main package > > Does 'ldplayer' really depend by 'mame' package ? It needs mame.ini to follow Fedora default configuration
(In reply to Julian Sikorski from comment #28) > (In reply to Antonio Trande from comment #27) > > (In reply to Julian Sikorski from comment #26) > > > I am not sure what do you mean about LICENSE files not being packaged - the > > > 10 LICENSE files are actually part of mame-data and > > > mame-data-software-lists. Please may you elaborate? > > > > Are part of mame-data but not tagged with %license (this macro pushes > > license files in /usr/share/licenses/package_name). > > > > I think you should rename them by indicating the type of license and tag > > them with %license. > > I am not completely convinced... As things stand now, it is clear which > LICENSE file applies to which folder. If everything goes to %licensedir, > this information will be lost. > > > Those directories are matched with README files, if it remember fine, which indicate the license. All licenses go in /usr/share/licenses/mame-data like happens with other packages.
New packages have been uploaded: Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc23.src.rpm Changes: - Updated to 0.175 - Dropped upstreamed patches - Removed bundled lua-sqlite and http-parser provides as they were removed - Ensured licenses for artwork and plugins are installed appropriately - Disabled ldplayer since it does not build currently (Github #1015)
I'm sorry, the correct links are: Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc24.src.rpm
(In reply to Julian Sikorski from comment #31) > I'm sorry, the correct links are: > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc24.src.rpm Review is finished but I still have an error like this https://github.com/mamedev/mame/issues/953 if I try to build with fedora-review. Instead works on koji ... Are you able to build 'mame' with mock on rawhide ?
(In reply to Antonio Trande from comment #32) > (In reply to Julian Sikorski from comment #31) > > I'm sorry, the correct links are: > > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec > > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc24.src.rpm > > Review is finished but I still have an error like this > https://github.com/mamedev/mame/issues/953 if I try to build with > fedora-review. > > Instead works on koji ... > > Are you able to build 'mame' with mock on rawhide ? It was failing for me on rawhide as well, this is why I filed the bug. If it works in koji, this is most peculiar.
(In reply to Antonio Trande from comment #32) > (In reply to Julian Sikorski from comment #31) > > I'm sorry, the correct links are: > > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec > > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc24.src.rpm > > Review is finished but I still have an error like this > https://github.com/mamedev/mame/issues/953 if I try to build with > fedora-review. > > Instead works on koji ... > > Are you able to build 'mame' with mock on rawhide ? Would you be OK approving the review request? The rawhide build issue is beyond my ability to fix myself, and a bug has been filled with upstream. Rawhide is at relatively early development stage atm so this issue is unlikely to affect many at this point. Thank you.
.gch is _precompiled_ header file, which must not be used. Instead the original header file must be used. rawhide build failure is perhaps because the headers on glibc side which .gch original header file changed on newer (rawhide) glibc. As the build failure says: > cc1plus: fatal error: ../../../../linux_gcc/obj/x64/Release/emu.h: No such file or directory mame compilation on mock must use the original "emu.h". i.e. remove precompiled .gch files and replace them with the original file.
(In reply to Mamoru TASAKA from comment #35) > rawhide build failure is perhaps because > the headers on glibc side which .gch original header file changed on newer > (rawhide) glibc. > I meant "the headers on glibc side which .gch original header file depends on changed"
Thank you for the pointer Mamoru! I thought that the precompiled headers are created during build, but I will check this when I get home.
Ah, sorry... actually there is no .gch beforehand...
rawhide builds work on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=14779471 Does it matter that local mock build fails?
Build on koji took more than 2 hours [1] I remember that is hard build it on local, needs more than 4 Giga bytes of memory free ( without low mem) Are you sure this is legal to chip in Fedora proper ? [1] Started Tue, 05 Jul 2016 17:32:50 UTC Completed Tue, 05 Jul 2016 19:54:21 UTC
(In reply to Sergio Monteiro Basto from comment #40) > Build on koji took more than 2 hours [1] I remember that is hard build it on > local, needs more than 4 Giga bytes of memory free ( without low mem) > Amount of memory has nothing to do with the build failure discussed here. The failure was caused by glibc when trying to build mame in mock locally on F22 host (for me, not sure what was Antonio using). Having said that, I upgraded to F24 yesterday and the issue is gone - I have just built 0.175-1 srpm in mock for rawhide. > > Are you sure this is legal to chip in Fedora proper ? > These are the new rules for emulators: Some emulators (applications which emulate another platform) are not permitted for inclusion in Fedora. These rules will help you determine if an emulator is acceptable for Fedora. - Emulators which depend on firmware or ROM files to function may not be included in Fedora, unless the copyright holder(s) for the firmware/ROM files give clear permission for the firmware/ROM files to be distributed (either under a Fedora permissible license or under the Fedora firmware exception criteria). Note: This only covers the situation where an emulator will not run at all without firmware/ROM files. For example, emulators that compile and run, but ship with no game ROMs are not covered by this rule. - Emulators must not ship with any ROM files (e.g. games) unless those ROM files are available under a Fedora permissible license and have been built from source code in the Fedora buildsystem. - Emulators must not point to any third-party sites which provide firmware or ROM files that are distributed without the clear and explicit permission of their copyright holders. - All other Fedora licensing and packaging rules apply to emulators. mame compiles and runs without roms, does not ship any rom files and there are no pointers to 3rd party sites providing them. Unless there are licensing issues, there should be no problem including mame in Fedora. > [1] > Started Tue, 05 Jul 2016 17:32:50 UTC > Completed Tue, 05 Jul 2016 19:54:21 UTC
(In reply to Julian Sikorski from comment #34) > (In reply to Antonio Trande from comment #32) > > (In reply to Julian Sikorski from comment #31) > > > I'm sorry, the correct links are: > > > Spec URL: https://belegdol.fedorapeople.org/mame/mame.spec > > > SRPM URL: https://belegdol.fedorapeople.org/mame/mame-0.175-1.fc24.src.rpm > > > > Review is finished but I still have an error like this > > https://github.com/mamedev/mame/issues/953 if I try to build with > > fedora-review. > > > > Instead works on koji ... > > > > Are you able to build 'mame' with mock on rawhide ? > > Would you be OK approving the review request? The rawhide build issue is > beyond my ability to fix myself, and a bug has been filled with upstream. > Rawhide is at relatively early development stage atm so this issue is > unlikely to affect many at this point. Thank you. Review had to be done against rawhide: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 225280 bytes in 12 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mame- data , mame-data-software-lists , mame-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mame-0.175-1.fc25.i686.rpm mame-tools-0.175-1.fc25.i686.rpm mame-data-0.175-1.fc25.noarch.rpm mame-data-software-lists-0.175-1.fc25.noarch.rpm mame-debuginfo-0.175-1.fc25.i686.rpm mame-0.175-1.fc25.src.rpm mame.i686: W: hidden-file-or-dir /etc/skel/.mame mame-tools.i686: W: no-manual-page-for-binary mame-srcclean mame-tools.i686: W: no-manual-page-for-binary mame-regrep mame-tools.i686: W: no-manual-page-for-binary mame-src2html mame-tools.i686: W: no-manual-page-for-binary unidasm mame-tools.i686: W: no-manual-page-for-binary pngcmp mame-tools.i686: W: no-manual-page-for-binary nltool mame-tools.i686: W: no-manual-page-for-binary mame-split mame-tools.i686: W: no-manual-page-for-binary nlwav mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq3x.json mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq4x.json mame-data.noarch: E: incorrect-fsf-address /usr/share/mame/bgfx/chains/hqx/hq2x.json mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Afrikaans/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Albanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Arabic/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Basque/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Belarusian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Bosnian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Bulgarian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Burmese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Catalan/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Chinese_Simplified/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Chinese_Traditional/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Croatian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Czech/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Danish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Dutch/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/English/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Estonian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Finnish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French_Belgium/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/French_Canada/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Georgian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/German/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Greek/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hebrew/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hindi/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Hungarian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Indonesian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Italian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Japanese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Korean/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Latvian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Lithuanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Macedonian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Norwegian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Persian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Polish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Portuguese/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Portuguese_Brazil/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Romanian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Russian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Serbian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Serbian_Cyrillic/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Slovak/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Slovenian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Spanish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Spanish_Mexico/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Swedish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Thai/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Turkish/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Ukrainian/strings.mo mame-data.noarch: W: file-not-in-%lang /usr/share/mame/language/Vietnamese/strings.mo mame-data-software-lists.noarch: W: spelling-error %description -l en_US subpackage -> sub package, sub-package, package's mame-data-software-lists.noarch: W: no-documentation mame-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/mame-0.175/src/lib/util/sha1.cpp mame.src:1: W: macro-in-comment %bcond_with mame.src:48: W: unversioned-explicit-provides bundled(bgfx) mame.src:50: W: unversioned-explicit-provides bundled(luafilesystem) mame.src:51: W: unversioned-explicit-provides bundled(lua-zlib) mame.src:59: W: unversioned-explicit-provides bundled(softfloat) mame.src: W: invalid-url Source0: https://github.com/mamedev/mame/releases/download/mame0175/mame0175s.exe HTTP Error 403: Forbidden 6 packages and 0 specfiles checked; 4 errors, 69 warnings. Rpmlint (debuginfo) ------------------- Checking: mame-debuginfo-0.175-1.fc25.i686.rpm mame-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/mame-0.175/src/lib/util/sha1.cpp 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- mame-tools (rpmlib, GLIBC filtered): libFLAC.so.8 libSDL2-2.0.so.0 libc.so.6 libdl.so.2 libexpat.so.1 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libpthread.so.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.5) libstdc++.so.6(CXXABI_1.3.8) libstdc++.so.6(CXXABI_1.3.9) libutil.so.1 libz.so.1 mame(x86-32) rtld(GNU_HASH) mame-data (rpmlib, GLIBC filtered): mame-debuginfo (rpmlib, GLIBC filtered): mame (rpmlib, GLIBC filtered): config(mame) libFLAC.so.8 libGL.so.1 libQt5Core.so.5 libQt5Core.so.5(Qt_5) libQt5Core.so.5(Qt_5.6) libQt5Gui.so.5 libQt5Gui.so.5(Qt_5) libQt5Widgets.so.5 libQt5Widgets.so.5(Qt_5) libSDL2-2.0.so.0 libSDL2_ttf-2.0.so.0 libX11.so.6 libXinerama.so.1 libasound.so.2 libc.so.6 libdl.so.2 libexpat.so.1 libfontconfig.so.1 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libjpeg.so.62 libjpeg.so.62(LIBJPEGTURBO_6.2) libjpeg.so.62(LIBJPEG_6.2) liblua-5.3.so libm.so.6 libportmidi.so.0 libpthread.so.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.5) libstdc++.so.6(CXXABI_1.3.8) libstdc++.so.6(CXXABI_1.3.9) libutil.so.1 libuv.so.1 libz.so.1 libz.so.1(ZLIB_1.2.2) mame-data rtld(GNU_HASH) mame-data-software-lists (rpmlib, GLIBC filtered): mame-data Provides -------- mame-tools: mame-tools mame-tools(x86-32) mame-data: mame-data mame-debuginfo: mame-debuginfo mame-debuginfo(x86-32) mame: bundled(bgfx) bundled(lua-zlib) bundled(luafilesystem) bundled(lzma-sdk) bundled(softfloat) config(mame) mame mame(x86-32) mame-data-software-lists: mame-data-software-lists Source checksums ---------------- https://github.com/mamedev/mame/releases/download/mame0175/mame0175s.exe : CHECKSUM(SHA256) this package : fcca637d56dac8dd7eb42d3cff59cf0fc858e3744958fe898252380e25473567 CHECKSUM(SHA256) upstream package : fcca637d56dac8dd7eb42d3cff59cf0fc858e3744958fe898252380e25473567 http://mamedev.org/releases/whatsnew_0175.txt : CHECKSUM(SHA256) this package : b40dbfe8f610e3abaeb80fd512a3e76e42ba3a63c9911c5630728b8aebd4fd68 CHECKSUM(SHA256) upstream package : b40dbfe8f610e3abaeb80fd512a3e76e42ba3a63c9911c5630728b8aebd4fd68 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -c -m fedora-rawhide-i386 -rn mame-0.175-1.fc24.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mame
mame-0.175-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab1e111bf6
mame-0.175-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-17c1c5ad71
mame-0.175-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-17c1c5ad71
mame-0.175-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab1e111bf6
mame-0.175-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
mame-0.175-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.