Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1) # satellite-installer -S satellite --upgrade --force Upgrading... Upgrade Step: stop_services... Upgrade Step: start_databases... Upgrade Step: update_http_conf... Upgrade Step: migrate_pulp... Upgrade Step: start_httpd... Upgrade step start_httpd failed. Check logs for more information. /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:108:in `error': wrong number of arguments (4 for 1) (ArgumentError) from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:108:in `send' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:108:in `dump_buffer' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:108:in `each' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:108:in `dump_buffer' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:107:in `each' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:107:in `dump_buffer' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:98:in `dump_errors' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/logger.rb:103:in `dump_errors' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/exit_handler.rb:28:in `exit' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/kafo_configure.rb:162:in `exit' from /usr/share/katello-installer-base/hooks/pre/30-upgrade.rb:63:in `fail_and_exit' from /usr/share/katello-installer-base/hooks/pre/30-upgrade.rb:57:in `upgrade_step' from /usr/share/katello-installer-base/hooks/pre/30-upgrade.rb:77:in `load' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/hook_context.rb:13:in `instance_exec' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/hook_context.rb:13:in `execute' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/hooking.rb:51:in `execute' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/hooking.rb:49:in `each' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/hooking.rb:49:in `execute' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/kafo_configure.rb:373:in `run_installation' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/kafo_configure.rb:149:in `execute' from /usr/lib/ruby/gems/1.8/gems/clamp-0.6.2/lib/clamp/command.rb:67:in `run' from /usr/lib/ruby/gems/1.8/gems/clamp-0.6.2/lib/clamp/command.rb:125:in `run' from /usr/lib/ruby/gems/1.8/gems/kafo-0.7.3/lib/kafo/kafo_configure.rb:156:in `run' from /usr/sbin/foreman-installer:12 Actual results: Upgrade step start_httpd fails Expected results: Upgrade step start_httpd succeeds Additional info: # service httpd start Starting httpd: [Fri May 13 08:27:30 2016] [warn] module passenger_module is already loaded, skipping httpd: Syntax error on line 48 of /etc/httpd/conf/httpd.conf: Include directory '/etc/httpd/conf.modules.d' not found [FAILED]
/etc/httpd/conf/httpd.conf: 46: Include "/etc/httpd/conf.d/*.conf" 47: 48: Include "/etc/httpd/conf.modules.d/*.conf" <<< dir not found >>> It seems that 6.1 httpd conf layout is not migrated to 6.2 layout...
>>> That directory exists only on RHEL7 with httpd-2.4 while RHEL6 has httpd-2.2 # rpm -qf /etc/httpd/conf.modules.d httpd-2.4.6-40.el7.x86_64 >>> Upgrades should handle also RHEL6 httpd-2.2
The error is not so hard, after removing line 48 in /etc/httpd/conf/httpd.conf, the upgrade step start_httpd succeeds and Upgrades proceed further
I confirm, the root cause is here: https://github.com/Katello/katello-installer/blob/master/hooks/pre/30-upgrade.rb#L13 This was introduced in the fix for bug 1332700. John - can you please take a look as you fixed the related bug?
Tomer, I assigned this to myself and will take a look. -John
Created redmine issue http://projects.theforeman.org/issues/15072 from this bug
Moving to POST since upstream bug http://projects.theforeman.org/issues/15072 has been closed
VERIFIED. @satellite-6.2.0-13.0.el6sat.noarch # satellite-installer -S satellite --upgrade Upgrading... Upgrade Step: stop_services... Upgrade Step: start_databases... Upgrade Step: update_http_conf... Upgrade Step: migrate_pulp... Upgrade Step: fix_pulp_httpd_conf... Upgrade Step: start_httpd... <<< step went successfully Upgrade Step: start_qpidd... Upgrade Step: start_pulp... Upgrade Step: migrate_candlepin... Upgrade Step: start_tomcat... Upgrade Step: fix_katello_settings_file... Upgrade Step: migrate_foreman... Upgrade Step: migrate_gutterball... Upgrade Step: remove_nodes_distributors... Upgrade Step: Running installer... ...
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1501