Bug 1336082 - bad path, jsoncpp.pc include dir
Summary: bad path, jsoncpp.pc include dir
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: jsoncpp
Version: 24
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Sébastien Willmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-14 00:59 UTC by David Vásquez
Modified: 2016-07-17 11:16 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-17 11:16:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
src.rpm with the patch (201.58 KB, application/x-rpm)
2016-05-14 00:59 UTC, David Vásquez
no flags Details
only the patch (365 bytes, patch)
2016-05-14 05:13 UTC, Sergio Basto
no flags Details | Diff

Description David Vásquez 2016-05-14 00:59:26 UTC
Created attachment 1157443 [details]
src.rpm with the patch

Description of problem:


Version-Release number of selected component (if applicable):
jsoncpp-1.7.2-1 (F24/25) and jsoncpp-0.6.0-0.18.rc2 (F23) 

Steps to Reproduce:

su
dnf -y install jsoncpp-devel

cat /usr/lib64/pkgconfig/jsoncpp.pc

prefix=/usr
exec_prefix=${prefix}
libdir=/usr/lib64
includedir=/usr/include

Name: jsoncpp
Description: A C++ library for interacting with JSON
Version: 1.7.2
URL: https://github.com/open-source-parsers/jsoncpp
Libs: -L${libdir} -ljsoncpp
Cflags: -I${includedir}


----------

the .spec file changed the path to /usr/include/json

ls /usr/include/json/

allocator.h   autolink.h  features.h  json.h    value.h    writer.h
assertions.h  config.h    forwards.h  reader.h  version.h



Additional info:
The package for Fedora 23 has the same problem; I am tired export my '.pc' with the correct path...
I include the patch in this report...

Comment 1 Sergio Basto 2016-05-14 05:13:40 UTC
Created attachment 1157447 [details]
only the patch

just try to help , seems to me more simple just send the patch .

Comment 2 Sergio Basto 2016-05-15 00:09:14 UTC
I opened a bug in upstream component that fail to compile with jsoncpp-devel [1]

I believe the problem is in pvr.argustv

[1] https://github.com/kodi-pvr/pvr.argustv/issues/57

Comment 3 Fedora Update System 2016-06-13 22:01:57 UTC
jsoncpp-1.7.2-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2eb79bedb8

Comment 4 Sébastien Willmann 2016-06-13 22:05:02 UTC
I applied the patch for f25 and f24, but are you sure there is a problem with f23? Note that in 0.6 the path is really /usr/include/jsoncpp.

Comment 5 Fedora Update System 2016-06-14 03:57:18 UTC
jsoncpp-1.7.2-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2eb79bedb8

Comment 6 Sergio Basto 2016-06-14 12:02:42 UTC
Hi, I think the problem is with pvr.argustv and other kodi-pvrs which not handle well jsoncpp-1.7.2 see https://github.com/kodi-pvr/pvr.argustv/issues/57

Comment 7 Fedora Update System 2016-06-18 18:30:29 UTC
jsoncpp-1.7.2-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Ulrich Drepper 2016-06-20 16:55:29 UTC
This change is horribly broken!

In 1.7.2-2 pkg-config --cflags now returns /usr/include/json.  This has fatal consequences since now the files which should be available only with a json/ prefix are available without it.  Specifically, the file /usr/include/json/features.h is available as <features.h> which is at least some of the time found instead of /usr/include/features.h.  You can image that this has fatal consequences.

The right solution is to complete get rid of the --cflags output or alternatively use this patch:

--- jsoncpp.pc-old	2016-06-20 12:51:59.694811903 -0400
+++ jsoncpp.pc	2016-06-20 12:54:09.950975360 -0400
@@ -1,7 +1,7 @@
 prefix=/usr
 exec_prefix=${prefix}
 libdir=/usr/lib64
-includedir=/usr/include/json
+includedir=/usr/include
 
 Name: jsoncpp
 Description: A C++ library for interacting with JSON


This brings back the functionality of Fedora 23.

Comment 9 Sébastien Willmann 2016-06-20 18:20:26 UTC
Ok, so in other words the path was actually correct in 1.7.2-1, even though some people expect it to be different.

I’m reverting the change.

Comment 10 Fedora Update System 2016-06-20 18:52:32 UTC
jsoncpp-1.7.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dcf9d5f9a8

Comment 11 Sergio Basto 2016-06-20 22:45:20 UTC
(In reply to Sébastien Willmann from comment #9)
> Ok, so in other words the path was actually correct in 1.7.2-1, even though
> some people expect it to be different.
> 
> I’m reverting the change.

Again, I think the problem is with pvr.argustv and other kodi-pvrs which not handle well jsoncpp-1.7.2, they just handle jsoncpp < 1, please help and comment here :  https://github.com/kodi-pvr/pvr.argustv/issues/57

Comment 12 Fedora Update System 2016-06-22 02:27:32 UTC
jsoncpp-1.7.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dcf9d5f9a8

Comment 13 Fedora Update System 2016-06-25 19:30:21 UTC
jsoncpp-1.7.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.