+++ This bug was initially created as a clone of Bug #1335717 +++

A lot of paths in GlusterFS have been hardcoded, and do not honour the prefix set when configured.

Following a discussion on the mailing lists, Aravinda has identified [1][2] the following list of files that get installed outside prefix that need to be fixed to install into the correct location.

sbin
sbin/mount.glusterfs
usr/lib/
usr/lib/systemd
usr/lib/systemd/system
usr/lib/systemd/system/glustereventsd.service
usr/lib/systemd/system/glusterd.service
usr/lib/python2.7
usr/lib/python2.7/site-packages
usr/lib/python2.7/site-packages/gluster
usr/lib/python2.7/site-packages/gluster/__init__.pyo
usr/lib/python2.7/site-packages/gluster/__init__.pyc
usr/lib/python2.7/site-packages/gluster/__init__.py
usr/lib/python2.7/site-packages/gluster/glupy
usr/lib/python2.7/site-packages/gluster/glupy/__init__.pyo
usr/lib/python2.7/site-packages/gluster/glupy/__init__.pyc
usr/lib/python2.7/site-packages/gluster/glupy/__init__.py
var/
var/lib
var/lib/glusterd
var/lib/glusterd/glusterfind
var/lib/glusterd/glusterfind/.keys
var/lib/glusterd/groups
var/lib/glusterd/groups/virt
var/lib/glusterd/hooks
var/lib/glusterd/hooks/1
var/lib/glusterd/hooks/1/delete
var/lib/glusterd/hooks/1/delete/post
var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py
var/lib/glusterd/hooks/1/gsync-create
var/lib/glusterd/hooks/1/gsync-create/post
var/lib/glusterd/hooks/1/gsync-create/post/S56glusterd-geo-rep-create-post.sh
var/lib/glusterd/hooks/1/reset
var/lib/glusterd/hooks/1/reset/post
var/lib/glusterd/hooks/1/reset/post/S31ganesha-reset.sh
var/lib/glusterd/hooks/1/stop
var/lib/glusterd/hooks/1/stop/pre
var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh
var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh
var/lib/glusterd/hooks/1/start
var/lib/glusterd/hooks/1/start/post
var/lib/glusterd/hooks/1/start/post/S31ganesha-start.sh
var/lib/glusterd/hooks/1/start/post/S30samba-start.sh
var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh
var/lib/glusterd/hooks/1/set
var/lib/glusterd/hooks/1/set/post
var/lib/glusterd/hooks/1/set/post/S32gluster_enable_shared_storage.sh
var/lib/glusterd/hooks/1/set/post/S30samba-set.sh
var/lib/glusterd/hooks/1/add-brick
var/lib/glusterd/hooks/1/add-brick/pre
var/lib/glusterd/hooks/1/add-brick/pre/S28Quota-enable-root-xattr-heal.sh
var/lib/glusterd/hooks/1/add-brick/post
var/lib/glusterd/hooks/1/add-brick/post/disabled-quota-root-xattr-heal.sh
var/log
var/log/glusterfs
var/run
var/run/gluster
usr/lib/
usr/lib/systemd
usr/lib/systemd/system
usr/lib/systemd/system/glusterd.service
usr/lib/python2.7
usr/lib/python2.7/site-packages
usr/lib/python2.7/site-packages/gluster
usr/lib/python2.7/site-packages/gluster/__init__.pyo
usr/lib/python2.7/site-packages/gluster/__init__.pyc
usr/lib/python2.7/site-packages/gluster/__init__.py
usr/lib/python2.7/site-packages/gluster/glupy
usr/lib/python2.7/site-packages/gluster/glupy/__init__.pyo
usr/lib/python2.7/site-packages/gluster/glupy/__init__.pyc
usr/lib/python2.7/site-packages/gluster/glupy/__init__.py
sbin/
sbin/mount.glusterfs

[1] https://www.gluster.org/pipermail/gluster-devel/2016-May/049516.html
[2] https://www.gluster.org/pipermail/gluster-devel/2016-May/049518.html

--- Additional comment from Vijay Bellur on 2016-05-13 07:57:00 CEST ---

REVIEW: http://review.gluster.org/14315 (configure: Prevent glupy python installation outside $prefix) posted (#2) for review on master by Aravinda VK (avishwan)

--- Additional comment from Aravinda VK on 2016-05-13 08:00:40 CEST ---

Kaushal,

That list was generated without --prefix option during configure. With --prefix option list of files which do not honor prefix are,

usr/lib/
usr/lib/systemd
usr/lib/systemd/system
usr/lib/systemd/system/glusterd.service
usr/lib/python2.7
usr/lib/python2.7/site-packages
usr/lib/python2.7/site-packages/gluster
usr/lib/python2.7/site-packages/gluster/__init__.pyo
usr/lib/python2.7/site-packages/gluster/__init__.pyc
usr/lib/python2.7/site-packages/gluster/__init__.py
usr/lib/python2.7/site-packages/gluster/glupy
usr/lib/python2.7/site-packages/gluster/glupy/__init__.pyo
usr/lib/python2.7/site-packages/gluster/glupy/__init__.pyc
usr/lib/python2.7/site-packages/gluster/glupy/__init__.py
sbin/
sbin/mount.glusterfs 

patch sent to fix glupy related issue 
http://review.gluster.org/14315

--- Additional comment from Vijay Bellur on 2016-05-13 08:19:15 CEST ---

REVIEW: http://review.gluster.org/14315 (configure: Prevent glupy/systemd/mount.glusterfs installation outside $prefix) posted (#3) for review on master by Aravinda VK (avishwan)

--- Additional comment from Vijay Bellur on 2016-05-13 08:58:23 CEST ---

REVIEW: http://review.gluster.org/14315 (configure: Prevent glupy/systemd/mount.glusterfs installation outside $prefix) posted (#4) for review on master by Aravinda VK (avishwan)

--- Additional comment from Aravinda VK on 2016-05-13 09:03:08 CEST ---

Now the same patch addresses all the other issues mentioned in comment 2

--- Additional comment from Vijay Bellur on 2016-05-13 11:34:14 CEST ---

REVIEW: http://review.gluster.org/14315 (configure: Prevent glupy installation outside $prefix) posted (#5) for review on master by Aravinda VK (avishwan)

--- Additional comment from Vijay Bellur on 2016-05-14 18:39:49 CEST ---

COMMIT: http://review.gluster.org/14315 committed in master by Niels de Vos (ndevos) 
------
commit 85de0c83392d861ba47c97664ff73fd7f8705a3a
Author: Aravinda VK <avishwan>
Date:   Fri May 13 09:40:38 2016 +0530

    configure: Prevent glupy installation outside $prefix
    
    glupy was installed in the global path outside the prefix path,
    even if --prefix is passed.
    
    ./configure --prefix=/usr/local
    make install
    
    Expected: ${DESTDIR}${prefix}/lib64/python<VERSION>/site-packages/gluster
    Actual: ${DESTDIR}/usr/lib64/python<VERSION>/site-packages/gluster
    
    prefix was not honoured.
    
    With this patch, glupy will be installed inside the prefix path.
    
    BUG: 1335717
    Change-Id: I810dd8d2d6c403540d4b738f5ab54237c7358bf6
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/14315
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    CentOS-regression: Gluster Build System <jenkins.com>