Bug 1336161 - Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go
Summary: Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementa...
Keywords:
Status: CLOSED DUPLICATE of bug 1486511
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1336168
TreeView+ depends on / blocked
 
Reported: 2016-05-15 00:55 UTC by Igor Gnatenko
Modified: 2017-08-31 06:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-31 06:37:00 UTC
Type: ---
Embargoed:
jchaloup: fedora-review?


Attachments (Terms of Use)

Description Igor Gnatenko 2016-05-15 00:55:29 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-ThomsonReutersEikon-go-ntlm.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-ThomsonReutersEikon-go-ntlm-0-0.1.gitb00ec39.fc25.src.rpm
Description: Native implementation of NTLM for Go.
Fedora Account System Username: ignatenkobrain

Comment 1 Jan Chaloupka 2016-07-11 10:21:53 UTC
Summary:
- licence OK
- will not build in epel6 (%license macro is not defined)
- usually structure (with_* removed)
- version is ok (hard to decode the version number from jenkins-ci-2 [1]

Nits:
- unit-test does not have license and docs (add %license License and %doc README.md as well)

Running rpmlint golang-github-ThomsonReutersEikon-go-ntlm-0-0.1.gitb00ec39.fc20.src.rpm golang-github-ThomsonReutersEikon-go-ntlm-devel-0-0.1.gitb00ec39.fc20.noarch.rpm golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel-0-0.1.gitb00ec39.fc20.x86_64.rpm
golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14858213

Up to the nit LGTM.

[1] https://github.com/ThomsonReutersEikon/go-ntlm/releases/tag/jenkins-ci-2

Comment 2 clime 2017-08-07 14:03:27 UTC
Can this be pushed? Or do you want to hand it over, Igor?

Comment 3 Igor Gnatenko 2017-08-08 08:46:44 UTC
(In reply to clime from comment #2)
> Can this be pushed? Or do you want to hand it over, Igor?
Please, someone take over this ;)

Comment 5 Elliott Sales de Andrade 2017-08-18 05:58:18 UTC
Apologies, I didn't notice that tito bumped the version instead of the release; here is a corrected spec:

Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-0-0.2.gitb00ec39.fc26.src.rpm
Description: Native implementation of NTLM for Go.
Fedora Account System Username: qulogic

Comment 6 Elliott Sales de Andrade 2017-08-31 06:37:00 UTC
Closing in favour of new review.

*** This bug has been marked as a duplicate of bug 1486511 ***


Note You need to log in before you can comment on or make changes to this bug.