Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-ThomsonReutersEikon-go-ntlm.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-ThomsonReutersEikon-go-ntlm-0-0.1.gitb00ec39.fc25.src.rpm Description: Native implementation of NTLM for Go. Fedora Account System Username: ignatenkobrain
Summary: - licence OK - will not build in epel6 (%license macro is not defined) - usually structure (with_* removed) - version is ok (hard to decode the version number from jenkins-ci-2 [1] Nits: - unit-test does not have license and docs (add %license License and %doc README.md as well) Running rpmlint golang-github-ThomsonReutersEikon-go-ntlm-0-0.1.gitb00ec39.fc20.src.rpm golang-github-ThomsonReutersEikon-go-ntlm-devel-0-0.1.gitb00ec39.fc20.noarch.rpm golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel-0-0.1.gitb00ec39.fc20.x86_64.rpm golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14858213 Up to the nit LGTM. [1] https://github.com/ThomsonReutersEikon/go-ntlm/releases/tag/jenkins-ci-2
Can this be pushed? Or do you want to hand it over, Igor?
(In reply to clime from comment #2) > Can this be pushed? Or do you want to hand it over, Igor? Please, someone take over this ;)
Here is an updated SPEC/SRPM for you: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591446-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591446-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-1-0.2.gitb00ec39.fc26.src.rpm Description: Native implementation of NTLM for Go. Fedora Account System Username: qulogic
Apologies, I didn't notice that tito bumped the version instead of the release; here is a corrected spec: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-0-0.2.gitb00ec39.fc26.src.rpm Description: Native implementation of NTLM for Go. Fedora Account System Username: qulogic
Closing in favour of new review. *** This bug has been marked as a duplicate of bug 1486511 ***