Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-bgentry-go-netrc-0-0.1.git9fd32a8.fc25.src.rpm SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-bgentry-go-netrc.spec Description: A Golang package for reading and writing netrc files. This package can parse netrc files, make changes to them, and then serialize them back to netrc format, while preserving any whitespace that was present in the source file. Fedora Account System Username: ignatenkobrain
Summary: - licences OK - example provides testing files for unit-tests => ok to include them in the unit-test subpackge - will not build in epel6 (%license macro is not defined) - usually structure (with_* removed) Running rpmlint golang-github-bgentry-go-netrc-0-0.1.git9fd32a8.fc20.src.rpm golang-github-bgentry-go-netrc-devel-0-0.1.git9fd32a8.fc20.noarch.rpm golang-github-bgentry-go-netrc-unit-test-devel-0-0.1.git9fd32a8.fc20.x86_64.rpm golang-github-bgentry-go-netrc.src: W: summary-not-capitalized C netrc file parser for Go programming language golang-github-bgentry-go-netrc.src: W: spelling-error %description -l en_US whitespace -> white space, white-space, whites pace golang-github-bgentry-go-netrc-devel.noarch: W: summary-not-capitalized C netrc file parser for Go programming language golang-github-bgentry-go-netrc-devel.noarch: W: spelling-error %description -l en_US whitespace -> white space, white-space, whites pace golang-github-bgentry-go-netrc-unit-test-devel.x86_64: W: spelling-error %description -l en_US whitespace -> white space, white-space, whites pace golang-github-bgentry-go-netrc-unit-test-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14858035 Nits: - fix summary, first letter must by capitalized (s/netrc/Netrc). Otherwise LGTM.
Here is an updated spec/srpm: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhide-x86_64/00591456-golang-github-bgentry-go-netrc/golang-github-bgentry-go-netrc.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhide-x86_64/00591456-golang-github-bgentry-go-netrc/golang-github-bgentry-go-netrc-0-0.2.git9fd32a8.fc27.src.rpm Description: A Golang package for reading and writing netrc files. This package can parse netrc files, make changes to them, and then serialize them back to netrc format, while preserving any whitespace that was present in the source file. Fedora Account System Username: qulogic
Closing in favour of other review. *** This bug has been marked as a duplicate of bug 1486510 ***