Bug 1336513
| Summary: | changelog: compiler warning format string | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Kaleb KEITHLEY <kkeithle> |
| Component: | changelog | Assignee: | Sheetal Pamecha <spamecha> |
| Status: | CLOSED NOTABUG | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | mainline | CC: | atumball, bugs, gaoxyt, kkeithle, spamecha, vbellur, xiang.gao |
| Target Milestone: | --- | Keywords: | EasyFix, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-07-16 13:26:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
ykaul@ykaul src]$ make
CC libgfchangelog_la-gf-changelog.lo
CC libgfchangelog_la-gf-changelog-journal-handler.lo
CC libgfchangelog_la-gf-changelog-helpers.lo
CC libgfchangelog_la-gf-changelog-api.lo
CC libgfchangelog_la-gf-history-changelog.lo
CC libgfchangelog_la-gf-changelog-rpc.lo
CC libgfchangelog_la-gf-changelog-reborp.lo
gf-changelog-reborp.c:396:35: warning: initialization of ‘int (*)(rpcsvc_request_t *)’ {aka ‘int (*)(struct rpcsvc_request *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
396 | CHANGELOG_REV_PROC_EVENT,
| ^~~~~~~~~~~~~~~~~~~~~~~~
gf-changelog-reborp.c:396:35: note: (near initialization for ‘gf_changelog_reborp_actors[1].actor’)
gf-changelog-reborp.c:397:35: warning: initialization of ‘int (*)(int, ssize_t *, char *, char *)’ {aka ‘int (*)(int, long int *, char *, char *)’} from incompatible pointer type ‘int (*)(rpcsvc_request_t *)’ {aka ‘int (*)(struct rpcsvc_request *)’} [-Wincompatible-pointer-types]
397 | gf_changelog_reborp_handle_event, NULL, 0,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gf-changelog-reborp.c:397:35: note: (near initialization for ‘gf_changelog_reborp_actors[1].vector_sizer’)
gf-changelog-reborp.c:397:69: warning: initialization of ‘int’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]
397 | gf_changelog_reborp_handle_event, NULL, 0,
| ^~~~
gf-changelog-reborp.c:397:69: note: (near initialization for ‘gf_changelog_reborp_actors[1].procnum’)
CC libgfchangelog_la-changelog-rpc-common.lo
CCLD libgfchangelog.la
(As of e5ff6cc397e7a23dff4024efb6806cb004a89ee6 )
The original issue reported in string format is now fixed as part of our 32bit/64bit compile options. But as Yaniv said in comment#2, there are other warnings with latest gcc. Recommend running compile with fedora 30 (gcc 8.3.x and above), and fixing all bugs. |
Description of problem: Making all in lib Making all in src CC libgfchangelog_la-gf-changelog-journal-handler.lo CC libgfchangelog_la-gf-changelog.lo CC libgfchangelog_la-gf-changelog-helpers.lo CC libgfchangelog_la-gf-changelog-api.lo CC libgfchangelog_la-gf-history-changelog.lo CC libgfchangelog_la-gf-changelog-rpc.lo CC libgfchangelog_la-gf-changelog-reborp.lo CC libgfchangelog_la-changelog-rpc-common.lo In file included from ../../../../../libglusterfs/src/glusterfs.h:35:0, from ../../../../../xlators/features/changelog/src/changelog-misc.h:14, from gf-changelog-reborp.c:11: gf-changelog-reborp.c: In function 'gf_changelog_event_handler': gf-changelog-reborp.c:365:23: warning: format '%ld' expects argument of type 'long int', but argument 15 has type 'size_t {aka unsigned int}' [-Wformat=] "seq: %lu [%s] (time: %lu.%lu), (vec: %d, len: %ld)", ^ ../../../../../libglusterfs/src/logging.h:248:55: note: in definition of macro 'gf_msg_debug' GF_LOG_DEBUG, errnum, 0, 0, ##fmt); \ ^~~ CCLD libgfchangelog.la Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: