Created attachment 1158100 [details]
Patch with recommended fix

Description of problem:

On an NFS mounted home area, where chgrp is effectively ignored,
pulseaudio fails to start because it can't change the group id
on a directory it already made mode 0700.

Version-Release number of selected component (if applicable):

pulseaudio-0.9.21-21

How reproducible:


Steps to Reproduce:
1. Get an NFS mounted home directory where chgrp doesn't do anything
2. run "pulseaudio"


Actual results:

Error:
Failed to create secure directory


Expected results:

Audio daemon starts, so you can play sounds.


Additional info:
If you look at the strace output:

stat("/nashome/m/mengel", {st_mode=S_IFDIR|S_ISGID|0755, st_size=124928, ...}) = 0
getuid()                                = 1733
umask(077)                              = 022
mkdir("/nashome/m/mengel/.pulse", 0700) = -1 EEXIST (File exists)
umask(022)                              = 077
open("/nashome/m/mengel/.pulse", O_RDONLY|O_NOCTTY|O_NOFOLLOW|O_CLOEXEC) = 4
fstat(4, {st_mode=S_IFDIR|0700, st_size=2048, ...}) = 0
getuid()                                = 1733
getgid()                                = 500
fchown(4, 1733, 500)                    = -1 EPERM (Operation not permitted)
fchmod(4, 0700)                         = 0
close(4)                                = 0
lstat("/nashome/m/mengel/.pulse", {st_mode=S_IFDIR|0700, st_size=2048, ...}) = 0
rmdir("/nashome/m/mengel/.pulse")       = -1 ENOTEMPTY (Directory not empty)
ioctl(2, SNDCTL_TMR_TIMEBASE or SNDRV_TIMER_IOCTL_NEXT_DEVICE or TCGETS, {B38400 opost isig icanon echo ...}) = 0
write(2, "E: core-util.c: \33[1;31mFailed to"..., 80) = 80
close(3)                                = 0
exit_group(1)                           = ?
+++ exited with 1 +++

You can see that it re-stats the directory after trying to rebuild it,
and fails because the fchmod is ignored.

So basically, it ought not care what the group-id's are when it's making 
the directory mode 0700; it's moot.  The attached patch only checks
the group-id if the mode has group bits set in it; so it still checks if
it is in shared-daemon mode and doing group pulseaudio, but not if it's 0700
for a single user.