Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim3/php-Slim3.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Slim3/php-Slim3-3.4.1-1.fc23.src.rpm Description: PHP micro framrework Fedora Account System Username: trasher The php-Slim package already exists in the repositories; but for the third version is a complete rewrite and breaks many things.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14128097
Created attachment 1158249 [details] phpci.log phpCompatInfo version 5.0.0 DB version 1.8.1 built May 03 2016 07:41:55 CEST static analyze results
Created attachment 1158250 [details] review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1336735 Buildroot used: fedora-rawhide-x86_64
[!]: Package is named according to the Package Naming Guidelines. "As for other packages, name should only use lowercase, underscore and slash replaced by dash. " So php-slim3 should be prefered [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. Obsoletes: %{name}-tests < 3 Uneeded, this package doesn't exists [~] EL-5 stuff unneeded (not a blocker) [x]: %check is present and all tests pass. PHP 5: OK PHP 7: OK I encouter failure on local build, but ok in mock (so not a blocker) 1) Slim\Tests\ContainerTest::testGetWithDiConfigErrorThrownAsInvalidArgumentException Failed asserting that exception of type "InvalidArgumentException" matches expected exception "\Interop\Container\Exception\ContainerException". Message was: "Identifier "doesnt-exist" is not defined." at /dev/shm/extras/BUILD/Slim-794073a27b2dd9ef492124263038291b7f8daeb3/tests/ContainerTest.php:74 /dev/shm/extras/BUILDROOT/php-Slim3-3.4.1-1.fc21.remi.x86_64/usr/share/php/Slim3/Container.php:125 /dev/shm/extras/BUILD/Slim-794073a27b2dd9ef492124263038291b7f8daeb3/tests/ContainerTest.php:77 Minors - also fix package name in spec header - as you keep changelog from php-Slim, add a changelog entry "renamed to ..."
Thank you to take care of this one :) I've rename the package according to the guidelines, and made all changes you've pointed out (except el-5 stuff ;)). As package has been renamed, I did not bump the spec version. I've not been able to reproduce the tests failure you throw on your local environment :-/ Here the new versions: Spec URL: http://odysseus.x-tnd.be/fedora/php-slim3/php-slim3.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-slim3/php-slim3-3.4.1-1.fc23.src.rpm
[x]: Package is named according to the Package Naming Guidelines. [x]: Obsoletes [x]: spec header [x]: changelog === APPROVED ===
Thank you very much for the review! I've requested package creation on pkgdb.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-slim3