Spec URL: https://rathann.fedorapeople.org/review/python-Pympler/python-Pympler.spec SRPM URL: https://rathann.fedorapeople.org/review/python-Pympler/python-Pympler-0.4.3-1.fc23.src.rpm Description: Pympler is a development tool to measure, monitor and analyze the memory behavior of Python objects in a running Python application. By pympling a Python application, detailed insight in the size and the lifetime of Python objects can be obtained. Undesirable or unexpected runtime behavior like memory bloat and other “pymples” can easily be identified. Pympler integrates three previously separate modules into a single, comprehensive profiling tool. The asizeof module provides basic size information for one or several Python objects, module muppy is used for on-line monitoring of a Python application and module Class Tracker provides off-line analysis of the lifetime of selected Python objects. Fedora Account System Username: rathann
This currently fails a couple of tests on koji (when built on arm builder) due to bug 1336740. Local mock build on x86_64 succeeds.
bug 1336740 is fixed in rawhide now.
Package Review ============== RPM Lint warning about a invalid License: [!]: Package is licensed with an open-source compatible license. W: invalid-license CC-BY-SA-NC Where does this license come? I do not look files with CC-BY-SA-NC license. Also remove the python shebangs of lifes undes python2/3_sitelib to fix the non executable script issue. ===== MUST items ===== Generic: [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-Pympler-0.4.3-1.fc23.noarch.rpm python3-Pympler-0.4.3-1.fc23.noarch.rpm python-Pympler-0.4.3-1.fc23.src.rpm python2-Pympler.noarch: W: invalid-license ASL2.0 python2-Pympler.noarch: W: invalid-license CC-BY-SA-NC python2-Pympler.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pympler/asizeof.py 644 /usr/bin/env python3-Pympler.noarch: W: invalid-license ASL2.0 python3-Pympler.noarch: W: invalid-license CC-BY-SA-NC python3-Pympler.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pympler/asizeof.py 644 /usr/bin/env python-Pympler.src: W: invalid-license ASL2.0 python-Pympler.src: W: invalid-license CC-BY-SA-NC 3 packages and 0 specfiles checked; 2 errors, 6 warnings. Rpmlint (installed packages) --------------------------- python2-Pympler.noarch: W: invalid-license ASL2.0 python2-Pympler.noarch: W: invalid-license CC-BY-SA-NC python2-Pympler.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pympler/asizeof.py 644 /usr/bin/env python3-Pympler.noarch: W: invalid-license ASL2.0 python3-Pympler.noarch: W: invalid-license CC-BY-SA-NC python3-Pympler.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pympler/asizeof.py 644 /usr/bin/env 2 packages and 0 specfiles checked; 2 errors, 4 warnings. Requires -------- python2-Pympler (rpmlib, GLIBC filtered): npm(Flot) python(abi) python-bottle python3-Pympler (rpmlib, GLIBC filtered): npm(Flot) python(abi) python3-bottle Provides -------- python2-Pympler: bundled(js-jquery-flot-tooltip) bundled(js-jquery-sparkline) python2-Pympler python3-Pympler: bundled(js-jquery-flot-tooltip) bundled(js-jquery-sparkline) python3-Pympler Source checksums ---------------- https://pypi.python.org/packages/source/P/Pympler/Pympler-0.4.3.tar.gz : CHECKSUM(SHA256) this package : 430528fff6cde1bae0a305e8df647b158c3cc4930cff122bf228293829ee1e56 CHECKSUM(SHA256) upstream package : 430528fff6cde1bae0a305e8df647b158c3cc4930cff122bf228293829ee1e56
Thanks for the review! Spec URL: https://rathann.fedorapeople.org/review/python-Pympler/python-Pympler.spec SRPM URL: https://rathann.fedorapeople.org/review/python-Pympler/python-Pympler-0.4.3-2.fc23.src.rpm * Fri Jun 10 2016 Dominik Mierzejewski <rpm> 0.4.3-2 - drop CC-BY-SA-NC from license list and fix typo - actually unbundle nodejs-flot - add a weak dep for python{2,3}-django-debug-toolbar - drop python shebang from asizeof.py Unbundling nodejs-flot-tooltip and js-jquery-sparkline is planned, but they're not packaged in Fedora yet.
Please note than some tests are failing in f23 and f24: https://copr.fedorainfracloud.org/coprs/williamjmorenor/fedora-review-test/build/341248/ Any way I am fine with this packaging so I will aprove it.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-Pympler
python-Pympler-0.4.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a46a9c06e5
F23 build is a bit more tricky as python-matplotlib is a big mess to fix in F23, so I may end up disabling the tests instead.
python-Pympler-0.4.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a46a9c06e5
python-Pympler-0.4.3-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.