Bug 1336828 - v2v: Import VMs dialog - Load button and error message issues
Summary: v2v: Import VMs dialog - Load button and error message issues
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-3.6.7
: 3.6.7.1
Assignee: jniederm
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-17 14:01 UTC by Sharon Gratch
Modified: 2016-07-04 12:33 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Load button in Import VMs dialog is disabled when * The is no data center up * or, there is no export domain and "Source" in Import VM dialog is set to "Export domain"
Clone Of:
Environment:
Last Closed: 2016-07-04 12:33:05 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-3.6.z+
rule-engine: planning_ack+
michal.skrivanek: devel_ack+
mavital: testing_ack+

Attachments (Terms of Use)
screensot (37.97 KB, image/png)
2016-05-17 14:01 UTC, Sharon Gratch 		no flags Details
ui.log (4.69 KB, text/plain)
2016-05-17 14:02 UTC, Sharon Gratch 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 57772 0 master MERGED webadmin: Fix of Import VMs dialog 2016-05-20 13:18:48 UTC
oVirt gerrit 57805 0 ovirt-engine-3.6 MERGED webadmin: Fix of Import VMs dialog 2016-05-24 10:53:12 UTC
oVirt gerrit 58268 0 ovirt-engine-3.6.7 MERGED webadmin: Fix of Import VMs dialog 2016-05-30 14:55:53 UTC

Description Sharon Gratch 2016-05-17 14:01:42 UTC 
Created attachment 1158306 [details]
screensot

Description of problem:
webadmin Import VM dialog > in case no DC is active/up, the Data Center field is empty but the "Load" button is not greyed out.
activating the Load action raised an uncaught exception.

1. screenshot attached.
2. ui log with the exception stack trace attached.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.make sure all Data Centers are not active.
2.Browse webadmin and navigate to virtual machines tab > import dialog
3.check that the Data Center field is empty.
4. click on the "Load" button.

Actual results:
an uncaught exception is raised.

Expected results:
the "Load" button should be greyed out in case no DC is active/selected for import.

Additional info:
1. screenshot attached.
2. ui log with the exception stack trace attached.
Comment 1 Sharon Gratch 2016-05-17 14:02:31 UTC 
Created attachment 1158307 [details]
ui.log
Comment 2 Red Hat Bugzilla Rules Engine 2016-05-18 10:55:30 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 3 jniederm 2016-05-20 12:11:24 UTC 
Another problem: Load button is not disabled when importing from export domain there is no external domain. Clicking it causes frontend exception.

Steps to reproduce:
1. Make sure there is no storage export domain.
2. Open Import VMs dialog (VM tab, Import toolbar button)
3. Select source "Export domain"
4. Click Load button

Actual result: FE exception thrown (in browser console)
Expected result: Load button is disabled.

_________________________
Another problem: When Import VMs dialog is opened, "Source" is by default "Export domain". When there is no export domain in the system, error message should be shown. However it is only show then "Export domain" is reselected in "Source" dropbox.

Steps to reproduce:
1. Make sure there is no storage export domain.
2. Open Import VMs dialog (VM tab, Import toolbar button)

Actual result: No error message is shown. However when "Source" "Export domain" is reselected, it is shown.
Expected result: Error message is shown right after opening the dialog.
Comment 4 Eyal Edri 2016-05-30 08:09:59 UTC 
still missing patch on ovirt-engine-3.6.7 branch.
Comment 5 Tomas Jelinek 2016-05-31 06:04:53 UTC 
ok, patch merged to 3.6.7, moving to modified
Comment 6 meital avital 2016-06-27 12:26:38 UTC 
Verified on version: 3.6.7.5-0.1.el6

Verified that Errors message correctly with Data Centers not active and without Export domain
Note You need to log in before you can comment on or make changes to this bug.