Spec URL: https://raw.githubusercontent.com/siwinski/rpms/1cbf8802ef711a295f621a836bc83d812a2ba60a/php-symfony-security-acl/php-symfony-security-acl.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-securiy-acl-2.8.0-1.fc24.src.rpm Description: Symfony Security Component - ACL (Access Control List) Fedora Account System Username: siwinski
Please fix obvious typo (rpmlnt: E: invalid-spec-name) %global github_name security-acl %global composer_project securiy-acl
Created attachment 1158772 [details] phpci.log phpCompatInfo version 5.0.0 DB version 1.8.1 built May 03 2016 07:41:55 CEST
Wow :/ Fixed. I did not bump the release since the generated RPMs are a different name. Diff: https://github.com/siwinski/rpms/commit/a0c2bcbed1541f46c9d9308b32def2c198af7693 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/a0c2bcbed1541f46c9d9308b32def2c198af7693/php-symfony-security-acl/php-symfony-security-acl.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-security-acl-2.8.0-1.fc24.src.rpm
Created attachment 1159980 [details] review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1336872 Buildroot used: fedora-rawhide-x86_64
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines => OK, package design for symfony 2.8 [x]: Package does not own files or directories owned by other packages. => Ok (as dropped from synfony 2.8) [~]: Requires correct, justified where necessary. Instead of Requires: php-composer(symfony/security-core) >= %{symfony_min_ver} Conflicts: php-symfony-security < 2.8.0 Could be simpler to (keep 2.7 for the BR) Requires: php-composer(symfony/security-core) >= 2.8 [x]: Latest version is packaged. => in the 2.8 branch [x]: %check is present and all tests pass. PHP 5: ok PHP 7: ok No Blocker, so the package conform with Fedora Guidelines. === APPROVED ===
THANKS for the review! SCM request opened via pkgdb. (In reply to Remi Collet from comment #5) > [~]: Requires correct, justified where necessary. > Instead of > Requires: php-composer(symfony/security-core) >= %{symfony_min_ver} > Conflicts: php-symfony-security < 2.8.0 > Could be simpler to (keep 2.7 for the BR) > Requires: php-composer(symfony/security-core) >= 2.8 I did not sub-package the individual components of the security module (they are all just php-symfony-security with multiple provides) so this would overwrite the 2.7 security-acl files. Is that OK?
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-securiy-acl
(In reply to Jon Ciesla from comment #7) > Package request has been approved: > https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-securiy-acl
(In reply to Jon Ciesla from comment #7) > Package request has been approved: > https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-securiy-acl Hey Jon -- I had a typo in the package name :( Would it be easier to: 1) ask to rename created pkg "php-symfony-securiy-acl" to "php-symfony-security-acl" 2) submit a new pkg request and then request that the old one be deleted?
Submit a new SCM request for the correct name and EOL the old one.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-security-acl