Bug 1336925 - Automate | Quota error "undefined method `vendor' for #<MiqAeMethodService::MiqAeServiceServiceTemplate:"
Summary: Automate | Quota error "undefined method `vendor' for #<MiqAeMethodService::M...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.6.0
Assignee: William Fitzgerald
QA Contact: Dmitry Misharov
URL:
Whiteboard: automate:quota
: 1340710 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-17 19:57 UTC by Tina Fitzgerald
Modified: 2018-06-25 14:57 UTC (History)
9 users (show)

Fixed In Version: 5.6.0.9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-29 16:03:22 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Tina Fitzgerald 2016-05-17 19:57:30 UTC
Description of problem:
Quota requested method error for generic service item causes the following error:

<code: storage = if @miq_request.source.vendor == 'google'>:16:in `calculate_requested'
[----] E, [2016-05-17T15:13:32.100512 #26491:12cb6bc] ERROR -- : Q-task_id([service_template_provision_request_1000000000277]) Method STDERR: (druby://127.0.0.1:40365) /home/hkataria/dev/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:200:in `method_missing': undefined method `vendor' for #<MiqAeMethodService::MiqAeServiceServiceTemplate:0x00000002c65c58> (NoMethodError)
[----] E, [2016-05-17T15:13:32.100568 #26491:12cb6bc] ERROR -- : Q-


How reproducible:
Create a generic service item and provision it.

Actual results:


Expected results:


Additional info:

Comment 4 Greg McCullough 2016-05-30 14:34:12 UTC
*** Bug 1340710 has been marked as a duplicate of this bug. ***

Comment 5 CFME Bot 2016-05-31 14:16:09 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/adb2ba7b73135650868ce0f85cd39bec7f073c64

commit adb2ba7b73135650868ce0f85cd39bec7f073c64
Author:     william fitzgerald <wfitzger>
AuthorDate: Fri May 20 12:36:08 2016 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Fri May 27 19:58:05 2016 -0400

    Automate - Fixed service quota
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1336925
    
    Added Service provisioning spec tests for generic and vmware service items.
    
    Updated spec helper files.

 .../QuotaMethods.class/__methods__/requested.rb    | 55 +++++++++++-------
 .../method_validation/calculate_requested_spec.rb  | 66 ++++++++++++++--------
 spec/support/quota_helper.rb                       | 43 ++++++++++----
 spec/support/service_template_helper.rb            | 10 ++--
 4 files changed, 119 insertions(+), 55 deletions(-)

Comment 7 Tina Fitzgerald 2016-06-02 17:08:15 UTC
Hi Milan,

Sorry about the lack of detail in the steps to reproduce...

Tenant quota should have at least one value that will cause the quota to fail.

The default service entry point should be: /Service/Provisioning/StateMachines/ServiceProvision_Template/default class.

Please let me know if it's still not behaving as you'd expect.

Thanks,
Tina

Comment 9 Milan Falešník 2016-06-03 13:14:51 UTC
Verified in 5.6.0.9

I have set a tenant quota (and I set them that they were already "broken"). I made a plain Generic service and kicked off its provisioning. No error happened during the provisioning.

Comment 12 errata-xmlrpc 2016-06-29 16:03:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Comment 13 CFME Bot 2016-08-04 12:51:48 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=86c546e3c0e79e117a6577cd0238676ff923a8e3

commit 86c546e3c0e79e117a6577cd0238676ff923a8e3
Author:     william fitzgerald <wfitzger>
AuthorDate: Fri May 20 12:36:08 2016 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Wed Aug 3 14:46:11 2016 -0400

    Automate - Fixed service quota
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1336925
    
    Added Service provisioning spec tests for generic and vmware service items.
    
    Updated spec helper files.
    
    Conflicts:
    	db/fixtures/ae_datastore/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/requested.rb
    	spec/automation/unit/method_validation/calculate_requested_spec.rb
    	spec/support/quota_helper.rb

 .../QuotaMethods.class/__methods__/requested.rb    | 55 ++++++++++++--------
 .../method_validation/calculate_requested_spec.rb  | 58 ++++++++++++++++------
 spec/support/quota_helper.rb                       | 57 +++++++++++++++++++--
 spec/support/service_template_helper.rb            | 10 ++--
 4 files changed, 137 insertions(+), 43 deletions(-)

Comment 14 Tina Fitzgerald 2016-08-04 15:58:26 UTC
Fixed in version 5.5.z: 
https://bugzilla.redhat.com/show_bug.cgi?id=1360132


Note You need to log in before you can comment on or make changes to this bug.