Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1337072 - Ansible Jobs are shown in Cloud/Stacks - clicking on one gives error message
Ansible Jobs are shown in Cloud/Stacks - clicking on one gives error message
Status: CLOSED ERRATA
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers (Show other bugs)
5.6.0
All Linux
high Severity medium
: GA
: 5.6.0
Assigned To: Ladislav Smola
Shveta
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-18 04:45 EDT by Christian Jung
Modified: 2017-08-30 16:18 EDT (History)
11 users (show)

See Also:
Fixed In Version: 5.6.0.9
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-06-29 12:03:48 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
ansible jobs (119.51 KB, image/png)
2016-06-01 20:24 EDT, Shveta
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 14:50:04 EDT

  None (edit)
Description Christian Jung 2016-05-18 04:45:22 EDT
Description of problem:
After running an Ansible Job Template (e.g. from a service catalog item), a object is created in Compute, Cloud, Stacks. When clicking on the object to retrieve more details, an error message is shown.

Version-Release number of selected component (if applicable):
5.6.0.7-beta2.6.20160516171555_b1be31f 

How reproducible:
always

Steps to Reproduce:
1. Order an Ansible Job Template from a service catalog
2. Navigate to Compute, Cloud, Stacks
3. click on the previously created object

Actual results:
undefined method `orchestration_template' for #<ManageIQ::Providers::AnsibleTower::ConfigurationManager::Job:0x00000013399fa0> [orchestration_stack/show] 

Expected results:
details of the selected object
Comment 5 Bill Wei 2016-05-19 15:31:21 EDT
The Ansible Tower job although a subclass of OrchestrationStack, it does not have orchestration template. Therefore the error message shows undefined method `orchestration_template'

I think the UI enhancement would be:
1. Compute -> Cloud -> Stacks should exclude any instance of ManageIQ::Providers::AnsibleTower::ConfigurationManager::Job.

Currently Stacks list all instances of OrchestrationStack, this includes ManageIQ::Providers::Openstack::InfraManager::OrchestrationStack. Infra stacks should not be listed either. We may want to move them to some other location.

If we limit true cloud stacks in Compute -> Cloud -> Stacks, the type should be only ManageIQ::Providers::CloudManager::OrchestrationStack

2. ManageIQ::Providers::AnsibleTower::ConfigurationManager::Job should be listed some other place, because it does not belong to cloud

Properties to be shown for an AnsibleTower job includes:
Configuration Manager (#ext_management_system)
Job Template (#job_template)
Status (#status)
Extra Vars (#parameters)
(Optional) Output. This should pop up or redirect to another page because the output can be a large chunk of text, and is retrieved live from the provider
Comment 9 CFME Bot 2016-05-26 13:40:32 EDT
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/372e64ddb686ddfbd2223412318bf6e39c01dd9d

commit 372e64ddb686ddfbd2223412318bf6e39c01dd9d
Author:     Ladislav Smola <lsmola@redhat.com>
AuthorDate: Thu May 26 09:53:46 2016 +0200
Commit:     Ladislav Smola <lsmola@redhat.com>
CommitDate: Thu May 26 09:53:46 2016 +0200

    Safely check for orchestration_template for stack
    
    Safely check for orchestration_template for stack
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1337072

 app/helpers/orchestration_stack_helper/textual_summary.rb | 2 +-
 app/views/layouts/listnav/_orchestration_stack.html.haml  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 10 Oleg Barenboim 2016-05-26 13:44:39 EDT
https://github.com/ManageIQ/manageiq/pull/8975 has been merged and backported to Darga branch.
Comment 11 Ladislav Smola 2016-05-27 03:29:30 EDT
https://github.com/ManageIQ/manageiq/pull/8975 is the only fix needed for the bug, 8962 will contain other enhancements that will not be backported
Comment 12 Shveta 2016-06-01 20:24 EDT
Created attachment 1163850 [details]
ansible jobs

Ansible jobs are still shown under clouds- stacks .
Clicking on it does not give any error though . 
Build : 5.6.0.9-rc2.20160531154046_b4e2f6d
Comment 13 Ladislav Smola 2016-06-02 03:18:12 EDT
@Shveta it's ok, fixing of this BZ is by making sure it doesn't throw an error.

We cannot just hide the ansible jobs, cause there is no other place that would show them. So there will be another RFE that will enhance the UI and bring multiple sections for stacks and ansible jobs.
Comment 14 Shveta 2016-06-03 13:35:42 EDT
Verified based on above comment.
Comment 16 errata-xmlrpc 2016-06-29 12:03:48 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Note You need to log in before you can comment on or make changes to this bug.