Red Hat Bugzilla – Bug 1337089
[Behind Proxy] gitHTTPSProxy and HTTPS_PROXY should be included in openshift_builddefaults_json variable of example file
Last modified: 2017-01-21 21:47:41 EST
Description of problem: The variable defined in example hosts file is: [root@xxx ~]# grep "openshift_builddefaults_json" docs/example-inventories/hosts.ose.example #openshift_builddefaults_json='{"BuildDefaults":{"configuration":{"apiVersion":"v1","env":[{"name":"HTTP_PROXY","value":"http://proxy.example.com.redhat.com:3128"},{"name":"NO_PROXY","value":"ose3-master.example.com"}],"gitHTTPProxy":"http://proxy.example.com:3128","kind":"BuildDefaultsConfig"}}}' gitHTTPSProxy and HTTPS_PROXY are not included in the example variable, actually they're needed to do S2I build in 99% secenarios. Version-Release number of selected component (if applicable): openshift-ansible-docs-3.0.90-1.git.0.a077b68.el7.noarch How reproducible: 100% Steps to Reproduce: 1. 2. 3. Actual results: Expected results: gitHTTPSProxy and HTTPS_PROXY should be included in example variable openshift_builddefaults_json Additional info:
(In reply to Gan Huang from comment #0) > Description of problem: > The variable defined in example hosts file is: > [root@xxx ~]# grep "openshift_builddefaults_json" > docs/example-inventories/hosts.ose.example > #openshift_builddefaults_json='{"BuildDefaults":{"configuration": > {"apiVersion":"v1","env":[{"name":"HTTP_PROXY","value":"http://proxy.example. > com.redhat.com:3128"},{"name":"NO_PROXY","value":"ose3-master.example.com"}], > "gitHTTPProxy":"http://proxy.example.com:3128","kind": > "BuildDefaultsConfig"}}}' > > gitHTTPSProxy and HTTPS_PROXY are not included in the example variable, > actually they're needed to do S2I build in 99% secenarios. This variable is really an advanced configuration value. Why do you say it's needed in 99% of the s2i scenarios? Is it still necessary with all the changes that've happened between then and now?
Nevermind, I see what you mean. https://github.com/openshift/openshift-ansible/pull/2521
There is gitHTTPSProxy without HTTPS_PROXY in the example variable. If install like this, it will be failure. [root@xxx ~]# grep "openshift_builddefaults_json" /usr/share/doc/openshift-ansible-docs-3.3.32/docs/example-inventories/hosts.ose.example #openshift_builddefaults_json='{"BuildDefaults":{"configuration":{"kind":"BuildDefaultsConfig","apiVersion":"v1","gitHTTPSProxy":"http://proxy.example.com.redhat.com:3128","gitHTTPProxy":"http://proxy.example.com.redhat.com:3128","env":[{"name":"HTTP_PROXY","value":"http://proxy.example.com.redhat.com:3128"},{"name":"NO_PROXY","value":"ose3-master.example.com"}]}}' ... TASK [openshift_builddefaults : Set builddefaults config structure] ************ Sunday 09 October 2016 03:53:00 -0400 (0:00:06.931) 0:12:00.481 ******** fatal: [xxx.example.com]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Shared connection to xxx.example.com closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n File \"/tmp/ansible_iwewXK/ansible_module_openshift_facts.py\", line 2214, in <module>\r\n main()\r\n File \"/tmp/ansible_iwewXK/ansible_module_openshift_facts.py\", line 2195, in main\r\n protected_facts_to_overwrite)\r\n File \"/tmp/ansible_iwewXK/ansible_module_openshift_facts.py\", line 1645, in __init__\r\n protected_facts_to_overwrite)\r\n File \"/tmp/ansible_iwewXK/ansible_module_openshift_facts.py\", line 1710, in generate_facts\r\n facts = set_proxy_facts(facts)\r\n File \"/tmp/ansible_iwewXK/ansible_module_openshift_facts.py\", line 1467, in set_proxy_facts\r\n facts['master']['kube_admission_plugin_config'].update(builddefaults['config'])\r\nValueError: dictionary update sequence element #0 has length 1; 2 is required\r\n", "msg": "MODULE FAILURE"} ...
It is already fix. [root@xxx ~]# grep "openshift_builddefaults_json" /usr/share/doc/openshift-ansible-docs-3.3.34/docs/example-inventories/hosts.ose.example #openshift_builddefaults_json='{"BuildDefaults":{"configuration":{"kind":"BuildDefaultsConfig","apiVersion":"v1","gitHTTPSProxy":"http://proxy.example.com.redhat.com:3128","gitHTTPProxy":"http://proxy.example.com.redhat.com:3128","env":[{"name":"HTTP_PROXY","value":"http://proxy.example.com.redhat.com:3128"},{"name":"HTTPS_PROXY","value":"http://proxy.example.com.redhat.com:3128"},{"name":"NO_PROXY","value":"ose3-master.example.com"}]}}'
The version of fixed rpm is: openshift-ansible-docs-3.3.34-1.git.0.5b998bb.el7.noarch.rpm
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:2122