Bug 1337336 - gnome-software shows updates but "Restart & Install" button doesn't install them
Summary: gnome-software shows updates but "Restart & Install" button doesn't install them
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-software
Version: 24
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-18 21:28 UTC by Geoffrey Marr
Modified: 2016-08-07 08:24 UTC (History)
8 users (show)

Fixed In Version: gnome-software-3.20.3-1.fc24
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-30 21:18:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot of gnome-software showing updates in the list. (232.30 KB, image/png)
2016-05-18 21:28 UTC, Geoffrey Marr
no flags Details
'journalctl -b' output after reboot caused by pressing "Restart & Install" in gnome-software (262.65 KB, text/plain)
2016-05-19 17:09 UTC, Geoffrey Marr
no flags Details
journalctl -b (294.00 KB, text/x-vhdl)
2016-05-20 11:37 UTC, pavel raur
no flags Details
journalctl_-a_-b_-1.log (167.91 KB, text/plain)
2016-05-23 16:45 UTC, Geoffrey Marr
no flags Details
restart popup with "os updates" only (86.05 KB, image/png)
2016-05-24 09:08 UTC, Kamil Páral
no flags Details
restart popup with app updates as well (94.86 KB, image/png)
2016-05-24 09:09 UTC, Kamil Páral
no flags Details
packagekit log when triggering update of "os updates" only (65.80 KB, text/plain)
2016-05-24 09:09 UTC, Kamil Páral
no flags Details
packagekit log when triggering update of "app" updates as well (64.26 KB, text/plain)
2016-05-24 09:10 UTC, Kamil Páral
no flags Details
rpm -qa (48.73 KB, text/plain)
2016-05-24 09:10 UTC, Kamil Páral
no flags Details
journalctl -ab (263.97 KB, text/plain)
2016-05-24 21:53 UTC, Geoffrey Marr
no flags Details

Description Geoffrey Marr 2016-05-18 21:28:35 UTC
Created attachment 1159102 [details]
Screenshot of gnome-software showing updates in the list.

Description of problem:

After an install of F24 Workstation nightly 20160518n0, a banner in the top of the screen says that OS updates are available. When clicked it takes the user into gnome-software and shows "OS Updates" in the updates list and a button to "Restart & Install". When the button is pressed, the computer will reboot, but upon restarting, the updates are not installed and the computer again shows the "OS Updates" in the updates list and the "Restart & Install" button. Using "dnf" to install the updates works like it should.


Version-Release number of selected component (if applicable):

Fedora-Workstation-Live-x86_64-24-20160518.n.0.iso


How reproducible:

Have reproduced it twice on two different installs.

Steps to Reproduce:
1. Perform fresh install of F24 Workstation nightly 20160518n0
2. Attempt to update the system by pressing "Restart & Install" under "Updates" tab in gnome-software
3. After reboot, check in gnome-software "Updates" tab to see that updates were not applied to the system.

Actual results:

After pressing "Restart & Install" in gnome-software, system reboots but does not install the updates.


Expected results:

After pressing "Restart & Install" the system should reboot and apply the updates to the system.


Additional info:

Using "dnf" works to install the updates.

Comment 1 Geoffrey Marr 2016-05-18 21:32:05 UTC
This bug violates the Beta release blocker criteria: 

"The installed system must be able to download and install updates with the default graphical package manager in all release-blocking desktops." [1]


[1] http://fedoraproject.org/wiki/Fedora_24_Beta_Release_Criteria#Updates

Comment 2 Fedora Blocker Bugs Application 2016-05-18 21:47:28 UTC
Proposed as a Blocker for 24-final by Fedora user coremodule using the blocker tracking app because:

 This bug violates the Beta release blocker criteria: 

"The installed system must be able to download and install updates with the default graphical package manager in all release-blocking desktops." [1]


[1] http://fedoraproject.org/wiki/Fedora_24_Beta_Release_Criteria#Updates

Comment 3 Richard Hughes 2016-05-19 15:27:57 UTC
What does the journal say about the failed offline update? Thanks.

Comment 4 Geoffrey Marr 2016-05-19 17:09:24 UTC
Created attachment 1159563 [details]
'journalctl -b' output after reboot caused by pressing "Restart & Install" in gnome-software

Richard,

Hope this helps. Let me know what else you need.

'journalctl -b' output after reboot caused by pressing "Restart & Install" in gnome-software.

Comment 5 pavel raur 2016-05-20 11:35:56 UTC
This happened to me too.

Version:

gnome-software-3.20.2-2.fc24.x86_64
libhif-0.2.2-3.fc24.x86_64

Fedora-Workstation-Live-x86_64-24-20160518.n.0.iso

Comment 6 pavel raur 2016-05-20 11:37:33 UTC
Created attachment 1159883 [details]
journalctl -b

Comment 7 Geoffrey Marr 2016-05-23 16:07:55 UTC
Additional info:

The "Restart & Install" button seems to only trigger a reboot, as there is no "Starting update" text in the top-left corner of the screen upon reboot.

The machine used to test this was a Core 2 Duo, 4gb RAM, x86_64, BIOS install.

This was replicated on two different installs and five different instances of the 20160518n0 nightly.

More logs to come...

Comment 8 Geoffrey Marr 2016-05-23 16:45:05 UTC
Created attachment 1160735 [details]
journalctl_-a_-b_-1.log

Comment 9 Geoffrey Marr 2016-05-23 16:53:31 UTC
The above log is the output of 'journalctl -a -b -1' after a successful install of the updates. The installs updated correctly when there were three updates to install (OS Updates, SELinux, and a gnome extention). It looks like if there is only an "OS Update" in the gnome-software update queue, it doesn't install, but as soon as another package shows up in the updates, they will all successfully install. More to come...

Comment 10 Geoffrey Marr 2016-05-23 18:11:14 UTC
Discussed during the 2016-05-23 blocker review meeting: [1]

The decision was made to delay the classification of this as a bug so that more testing can be performed. Will be discussed at next week's blocker review meeting.

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2016-05-23/f24-blocker-review.2016-05-23-16.00.txt

Comment 11 Kamil Páral 2016-05-24 09:06:59 UTC
I reproduced this on my own F24 VM, it's like Goeffrey said in comment 9. I had the system in a situation where only "OS Updates" were available. When I tried to use gnome-software to update, its button said "Restart & Install", but the popup dialog said only "Restart". That is in contrast to the situation when some "app" update is also available, then the popup says "Restart & Install updates". In the first case, just a reboot is performed, no update. In the second case, offline updates are correctly performed.

In my case, these were the pending updates:

================================================================================
 Package                   Arch     Version             Repository         Size
================================================================================
Installing:
 kernel                    x86_64   4.5.5-300.fc24      updates-testing    69 k
 kernel-core               x86_64   4.5.5-300.fc24      updates-testing    19 M
 kernel-modules            x86_64   4.5.5-300.fc24      updates-testing    21 M
 kernel-modules-extra      x86_64   4.5.5-300.fc24      updates-testing   2.2 M
Upgrading:
 at-spi2-core              x86_64   2.20.2-1.fc24       updates-testing   162 k
 gtk-update-icon-cache     x86_64   3.20.5-1.fc24       updates-testing    34 k
 gtk3                      x86_64   3.20.5-1.fc24       updates-testing   4.3 M
 kernel-headers            x86_64   4.5.5-300.fc24      updates-testing   1.0 M
 tigervnc-license          noarch   1.6.0-4.fc24        updates-testing    33 k
 tigervnc-server-minimal   x86_64   1.6.0-4.fc24        updates-testing   1.0 M
Removing:
 kernel                    x86_64   4.5.0-302.fc24      @fedora             0  
 kernel-core               x86_64   4.5.0-302.fc24      @fedora            50 M
 kernel-modules            x86_64   4.5.0-302.fc24      @fedora            21 M

Transaction Summary
================================================================================
Install  4 Packages
Upgrade  6 Packages
Remove   3 Packages


This is the output of `pkcon get-updates`:

Available    at-spi2-core-2.20.2-1.fc24.x86_64 (updates-testing)
Available    gtk-update-icon-cache-3.20.5-1.fc24.x86_64 (updates-testing)
Available    gtk3-3.20.5-1.fc24.x86_64 (updates-testing)
Available    kernel-4.5.5-300.fc24.x86_64 (updates-testing)
Available    kernel-core-4.5.5-300.fc24.x86_64 (updates-testing)
Available    kernel-headers-4.5.5-300.fc24.x86_64 (updates-testing)
Available    kernel-modules-4.5.5-300.fc24.x86_64 (updates-testing)
Available    kernel-modules-extra-4.5.5-300.fc24.x86_64 (updates-testing)
Available    tigervnc-license-1.6.0-4.fc24.noarch (updates-testing)
Available    tigervnc-server-minimal-1.6.0-4.fc24.x86_64 (updates-testing)


Verbose packagekit logs attached.

Comment 12 Kamil Páral 2016-05-24 09:08:32 UTC
Created attachment 1160945 [details]
restart popup with "os updates" only

See that the button in gnome-software is "Restart & Install", but the popup doesn't speak about updating.

Comment 13 Kamil Páral 2016-05-24 09:09:01 UTC
Created attachment 1160946 [details]
restart popup with app updates as well

See that the popup is correct now.

Comment 14 Kamil Páral 2016-05-24 09:09:41 UTC
Created attachment 1160947 [details]
packagekit log when triggering update of "os updates" only

Comment 15 Kamil Páral 2016-05-24 09:10:03 UTC
Created attachment 1160948 [details]
packagekit log when triggering update of "app" updates as well

Comment 16 Kamil Páral 2016-05-24 09:10:21 UTC
Created attachment 1160949 [details]
rpm -qa

Comment 17 Kamil Páral 2016-05-24 10:39:12 UTC
Richard created a Koji build containing a fix:
https://bugzilla.redhat.com/show_bug.cgi?id=1337336
I tested it and it works for me.

Reproducer is simple enough:
1. fully update your system
2. downgrade some package which is not considered "an app" by gnome-software
3. pkcon refresh force
4. download updates via gnome-software
5. try to trigger offline updates

Comment 18 Geoffrey Marr 2016-05-24 21:53:13 UTC
Created attachment 1161228 [details]
journalctl -ab

Output of 'journalctl -ab' on F24 Workstation Live nightly 20160524n0.

Comment 19 Geoffrey Marr 2016-05-24 21:54:11 UTC
This bug appears in F24 Workstation Live nightly 20160524n0. See the preceding post for the journal output surrounding this bug.

Comment 20 Kamil Páral 2016-05-25 08:14:26 UTC
Geoffrey, see comment 17. You can test the fix with the new koji build.

Richard, can you please submit a bodhi update for this?

Comment 21 Geoffrey Marr 2016-05-25 20:01:04 UTC
Kamil, Richard,

As far as my testing goes, gnome-software-3.20.2-3.fc24.x86_64 [1] works correctly as far as this bug is concerned.


[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=768073

Comment 22 Fedora Update System 2016-05-28 18:37:42 UTC
gnome-software-3.20.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2be09c9861

Comment 23 Fedora Update System 2016-05-29 23:26:04 UTC
gnome-software-3.20.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2be09c9861

Comment 24 Geoffrey Marr 2016-05-30 18:12:18 UTC
Discussed during the 2016-05-30 blocker review meeting: [1]

Decision to classify this as an AcceptedFreezeException was made due to the fact that an update has been pushed stable, so it *should* make it to release. The classification as a FreezeException is just in case the update is not pushed for some reason.

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2016-05-30/f24-blocker-review.2016-05-30-16.01.txt

Comment 25 Fedora Update System 2016-05-30 21:18:30 UTC
gnome-software-3.20.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 26 Kamil Páral 2016-05-31 13:01:43 UTC
Verified fixed with gnome-software-3.20.3-1.fc24.

Comment 27 Luca Truffarelli 2016-08-07 08:24:54 UTC
I case it might help I'm on 
cat /etc/fedora-release 
Fedora release 24 (Twenty Four)

with
rpm -q gnome-software
gnome-software-3.20.3-1.fc24.x86_64

and "Restart & Instrall" didn't work (run it multiple time)

I had to rum
dnf clean all
dnf -y update

to get the updates


Note You need to log in before you can comment on or make changes to this bug.