Bug 1337422 - No error reported when audio call fails
Summary: No error reported when audio call fails
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: pidgin
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Synacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-19 07:48 UTC by David Woodhouse
Modified: 2016-12-20 20:36 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-20 20:36:44 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description David Woodhouse 2016-05-19 07:48:18 UTC
Bug 1337412 describes a libnice failure to connect. This bug is for what happens next.

The Pidgin call dialog comes up (with the numeric keypad). For an outbound call it just says 'Calling...' and sits there doing nothing, even after the failure. 
The call isn't made (the other end doesn't ring).
For an accepted inbound call it says 'Call in progress'. The call isn't answered, and the caller continues to hear the ringing tone (and other targets still ring).

There should be some *indication* of failure. It's not entirely clear where this bug lies — the failure information is lost *somewhere* between libnice, farstream, gstreamer, pidgin-sipe and the pidgin UI. Hence filing this in the distribution bugzilla where it can easily be refiled to the offending component. 

My first guess would be pidgin-sipe (sorry Stefan ☺) but as I said, do feel free to assign blame elsewhere.

Comment 1 David Woodhouse 2016-05-19 07:49:35 UTC
Sample output when trying to make a test call...

(08:37:01) backend-fs2: Creating hash table for sessions
(08:37:01) backend-fs2: connecting pad: success
(08:37:01) backend-fs2: create_src: setting source state to GST_STATE_PLAYING - it may hang here on win32
(08:37:01) backend-fs2: create_src: state set
0:03:56.283988865 17885 0x55db561b0190 FIXME                default gstutils.c:3766:gst_pad_create_stream_id_internal:<pidgindefaultaudiosrc-actual-src-puls:src> Creating random stream-id, consider implementing a deterministic way of creating a stream-id
(08:37:01) backend-fs2: Creating hash table for participants
(08:37:01) GLib-GObject: unable to set property 'relay-info' of type 'GPtrArray' from value of type 'GValueArray'
(Pidgin:17885): libnice-DEBUG: Failed to convert address to string for interface ‘lo’.
(Pidgin:17885): libnice-DEBUG: Failed to convert address to string for interface ‘eth0’.
(Pidgin:17885): libnice-DEBUG: Failed to convert address to string for interface ‘wlan0’.
(Pidgin:17885): libnice-DEBUG: Failed to convert address to string for interface ‘virbr3’.
(Pidgin:17885): libnice-DEBUG: Failed to convert address to string for interface ‘virbr2’.
(Pidgin:17885): libnice-DEBUG: Failed to convert address to string for interface ‘virbr0’.
(Pidgin:17885): libnice-DEBUG: Interface:  lo
(Pidgin:17885): libnice-DEBUG: IP Address: 127.0.0.1
(Pidgin:17885): libnice-DEBUG: Ignoring loopback interface
(Pidgin:17885): libnice-DEBUG: Interface:  wlan0
(Pidgin:17885): libnice-DEBUG: IP Address: 90.155.92.197
(Pidgin:17885): libnice-DEBUG: Interface:  virbr3
(Pidgin:17885): libnice-DEBUG: IP Address: 90.155.50.33
(Pidgin:17885): libnice-DEBUG: Interface:  virbr2
(Pidgin:17885): libnice-DEBUG: IP Address: 192.168.100.1
(Pidgin:17885): libnice-DEBUG: Interface:  virbr0
(Pidgin:17885): libnice-DEBUG: IP Address: 192.168.123.1
(Pidgin:17885): libnice-DEBUG: Interface:  vpn0
(Pidgin:17885): libnice-DEBUG: IP Address: 10.252.15.30
(Pidgin:17885): libnice-DEBUG: Interface:  lo
(Pidgin:17885): libnice-DEBUG: IP Address: ::1
(Pidgin:17885): libnice-DEBUG: Ignoring loopback interface
(Pidgin:17885): libnice-DEBUG: Interface:  wlan0
(Pidgin:17885): libnice-DEBUG: IP Address: 2001:8b0:10b:1:841b:5eff:0:f69
(Pidgin:17885): libnice-DEBUG: Interface:  wlan0
(Pidgin:17885): libnice-DEBUG: IP Address: 2001:8b0:10b:1:e6ce:8fff:fe1f:f2c0
(Pidgin:17885): libnice-DEBUG: Interface:  wlan0
(Pidgin:17885): libnice-DEBUG: IP Address: fe80::e6ce:8fff:fe1f:f2c0%wlan0
(Pidgin:17885): libnice-DEBUG: Interface:  virbr3
(Pidgin:17885): libnice-DEBUG: IP Address: 2001:8b0:10b:10::1
(Pidgin:17885): libnice-DEBUG: Created NiceStream (1 created, 0 destroyed)
(Pidgin:17885): libnice-DEBUG: Created NiceComponent (1 created, 0 destroyed)
(Pidgin:17885): libnice-DEBUG: Created NiceComponent (2 created, 0 destroyed)
(Pidgin:17885): libnice-DEBUG: Agent 0x55db563884f0 : allocating stream id 1 (0x55db5715c970)
0:03:56.287249678 17885 0x55db561b0230 FIXME                default gstutils.c:3766:gst_pad_create_stream_id_internal:<nicesrc0:src> Creating random stream-id, consider implementing a deterministic way of creating a stream-id
(Pidgin:17885): libnice-DEBUG: Agent 0x55db563884f0 : In ICE-FULL mode, starting candidate gathering.
(Pidgin:17885): libnice-DEBUG: Agent 0x55db563884f0 : libnice compiled without UPnP support
(Pidgin:17885): libnice-DEBUG: Agent 0x55db563884f0: Trying to create host candidate on port 0
0:03:56.287570409 17885 0x55db56355b20 FIXME                default gstutils.c:3766:gst_pad_create_stream_id_internal:<nicesrc1:src> Creating random stream-id, consider implementing a deterministic way of creating a stream-id
(Pidgin:17885): libnice-DEBUG: Agent 0x55db563884f0: Unable to add local host candidate 2001:8b0:10b:10::1 for s1:1. Invalid interface?
(Pidgin:17885): libnice-DEBUG: Free socket sources for component 0x55db5715cdb0.
(Pidgin:17885): libnice-DEBUG: Free socket sources for component 0x55db571606a0.
(08:37:01) media: Creating hash table for sessions
(08:37:01) gtkmedia: state: 0 sid: audio name: (null)
(08:37:01) sipe: sipe_media_state_changed_cb: 0 audio (null)

(08:37:01) gtkmedia: state: 0 sid: (null) name: sip:fmcspool2.amr.corp.intel.com;gruu;opaque=srvr:Microsoft.Rtc.Applications.TestBot:uRa9JWnZSVWOUMHR-N92TgAA
(08:37:01) sipe: sipe_media_state_changed_cb: 0 (null) sip:fmcspool2.amr.corp.intel.com;gruu;opaque=srvr:Microsoft.Rtc.Applications.TestBot:uRa9JWnZSVWOUMHR-N92TgAA

(08:37:01) gtkmedia: state: 0 sid: audio name: sip:fmcspool2.amr.corp.intel.com;gruu;opaque=srvr:Microsoft.Rtc.Applications.TestBot:uRa9JWnZSVWOUMHR-N92TgAA
(08:37:01) sipe: sipe_media_state_changed_cb: 0 audio sip:fmcspool2.amr.corp.intel.com;gruu;opaque=srvr:Microsoft.Rtc.Applications.TestBot:uRa9JWnZSVWOUMHR-N92TgAA

(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1
(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1
(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1
(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1
(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1
(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1
(Pidgin:17885): libnice-DEBUG: nice_agent_send_messages_nonblocking_internal: n_sent: -1, n_messages: 1


... and it just sits here repeating that line...

Comment 2 Stefan Becker 2016-05-19 09:08:41 UTC
I do not see SIPE being called or updated at the end. Re-assigning to libnice to maybe provide error message back to SIPE?

David: if you feel this is a bug in SIPE, then this is the wrong place to report it. I consider V&V optional feature in SIPE and do not care if it works or not. Not to mention that I can't test or fix any V&V problems with the accounts available to me.

Comment 3 David Woodhouse 2016-05-19 10:05:53 UTC
(In reply to Stefan Becker from comment #2)
> I do not see SIPE being called or updated at the end. Re-assigning to
> libnice to maybe provide error message back to SIPE?

Thanks.

> David: if you feel this is a bug in SIPE, then this is the wrong place to
> report it.

Understood. The point in using the distro bugzilla was really to allow you to do precisely what you *have* done, and assign it to the right place with a little more accuracy than my initial guess.

Comment 4 David Woodhouse 2016-05-20 08:15:37 UTC
Further comment from Jakub Adam suggests that the problem actually lies in Pidgin itself. Reassigning (and I'll file a ticket upstream too):

Digging into the code, I see fs_nice_stream_transmitter_gather_local_candidates()
doesn't check the return value from nice_agent_gather_candidates()¹. That
shouldn't be a big deal though, because with², the function will return TRUE
event when it couldn't create candidates for some local addresses.

The actual problem seems to be that libpurple doesn't really handle stream state
change messages in any way besides writing the state into the debug log³.
Thus, when for example some stream fails because of failed candidate gathering
or ICE connectivity checks, libpurple silently ignores it without even letting
the respective protocol plugin (like Sipe) know there's something wrong going on.

I'm not sure what's the best way to handle stream failure in libpurple and will
have to think that over. You may consider opening a ticket in Pidgin tracker⁴
so that upstream developers can propose some solutions.

¹ https://git.collabora.com/cgit/farstream.git/tree/transmitters/nice/fs-nice-stream-transmitter.c#n1557
² https://phabricator.freedesktop.org/D999
³ https://hg.pidgin.im/pidgin/main/file/69a42dcf5a74/libpurple/media/backend-fs2.c#l1136https://developer.pidgin.im/query

Comment 5 David Woodhouse 2016-05-20 08:31:27 UTC
https://developer.pidgin.im/ticket/17017

Comment 6 Fedora End Of Life 2016-11-25 09:05:21 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Fedora End Of Life 2016-12-20 20:36:44 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.