Bug 1337548 - [abrt] bodhi-client: bodhi.py:84:wrapper:TypeError: argument of type 'NoneType' is not iterable
Summary: [abrt] bodhi-client: bodhi.py:84:wrapper:TypeError: argument of type 'NoneTyp...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: bodhi
Version: 25
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Randy Barlow
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:04604da01cafa5dd1b65ee00551...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-19 12:34 UTC by Vít Ondruch
Modified: 2017-12-12 10:44 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:44:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (636 bytes, text/plain)
2016-05-19 12:34 UTC, Vít Ondruch
no flags Details
File: environ (3.01 KB, text/plain)
2016-05-19 12:34 UTC, Vít Ondruch
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1386173 0 unspecified CLOSED "bodhi updates request revoke" does not work properly. 2021-02-22 00:41:40 UTC

Internal Links: 1386173

Description Vít Ondruch 2016-05-19 12:34:53 UTC
Description of problem:
Trying to delete update:

$ bodhi -d rubygem-ethon-0.9.0-1.fc24

Version-Release number of selected component:
bodhi-client-0.9.12.2-4.fc24

Additional info:
reporter:       libreport-2.7.0
cmdline:        /usr/bin/python2 -tt /usr/bin/bodhi -d rubygem-ethon-0.9.0-1.fc24
dso_list:       python-fedora-0.8.0-1.fc25.noarch
executable:     /usr/bin/bodhi
kernel:         4.5.0-1.fc25.x86_64
pkg_fingerprint: 73BD E983 81B4 6521
pkg_vendor:     Fedora Project
reproducible:   Not sure how to reproduce the problem
runlevel:       N 5
type:           Python
uid:            16025

Truncated backtrace:
bodhi.py:84:wrapper:TypeError: argument of type 'NoneType' is not iterable

Traceback (most recent call last):
  File "/usr/bin/bodhi", line 537, in <module>
    main()
  File "/usr/bin/bodhi", line 279, in main
    data = bodhi.delete(update=args[0])
  File "/usr/lib/python2.7/site-packages/fedora/client/bodhi.py", line 84, in wrapper
    if 'errors' not in result:
TypeError: argument of type 'NoneType' is not iterable

Local variables in innermost frame:
method: <function delete at 0x7f2f899462a8>
args: (<fedora.client.bodhi.Bodhi2Client object at 0x7f2f89944a50>,)
result: None
kwargs: {'update': 'rubygem-ethon-0.9.0-1.fc24'}

Comment 1 Vít Ondruch 2016-05-19 12:34:57 UTC
Created attachment 1159458 [details]
File: backtrace

Comment 2 Vít Ondruch 2016-05-19 12:34:58 UTC
Created attachment 1159459 [details]
File: environ

Comment 3 Jan Kurik 2016-07-26 04:36:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 4 Randy Barlow 2016-10-18 05:00:24 UTC
Hello!

I have recently become the primary caretaker of Bodhi and I've inherited a number of issues related to bodhi 0.9. I wanted to be forthcoming with you that it will be difficult for me to fix issues with bodhi 0.9 while also pressing forward with bodhi 2, especially since I do not have any familiarity with the bodhi 0.9 codebase. I'm happy to keep this bug open to track the problem, but I would also encourage you to please test the bodhi 2 client (currently available in Rawhide and Copr[0]). Unfortunately, the bodhi 2 client is not backwards compatible with bodhi 0.9, so at this time I only plan for bodhi 2 to be released with Fedora 26 and EPEL 7 (with special permission from the EPEL SC).

Here are some options you could pursue for this issue:

0) Write a patch for me that can be applied with the spec file. If you are willing to take the time to learn the bodhi 0.9 code, write a patch, and test it, I am willing to accept patches to be applied during build.
1) Use Rawhide.
2) Install bodhi 2 from my Copr[0].

I apologize as I understand that this is probably disappointing news for you to hear, but I thought it would be better to be forthcoming than to let the bug languish. I appreciate your understanding!


[0] https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi/

Comment 5 Vít Ondruch 2016-10-18 10:44:41 UTC
I am retesting this on F25 and it seems that something on server side was probably changed, since the error is more reasonable now (although the environment I am using is definitely different as well):

```
$ bodhi -u vondruch -d rubygem-httparty-0.14.0-1.fc25
No handlers could be found for logger "fedora.client.bodhi"
/usr/lib/python2.7/site-packages/fedora/client/bodhi.py:179: UserWarning: Deleting updates has been disabled in Bodhi2. This API call will unpush the update instead. Please use `set_request(update, "unpush")` instead
  warnings.warn('Deleting updates has been disabled in Bodhi2. '
Traceback (most recent call last):
  File "/usr/bin/bodhi", line 537, in <module>
    main()
  File "/usr/bin/bodhi", line 279, in main
    data = bodhi.delete(update=args[0])
  File "/usr/lib/python2.7/site-packages/fedora/client/bodhi.py", line 82, in wrapper
    result = method(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/fedora/client/bodhi.py", line 182, in delete
    self.request(update, 'unpush')
  File "/usr/lib/python2.7/site-packages/fedora/client/bodhi.py", line 93, in wrapper
    raise BodhiClientException(problems)
fedora.client.bodhi.BodhiClientException: Can't unpush a pending update
```

Comment 6 Fedora End Of Life 2017-11-16 14:10:29 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 7 Fedora End Of Life 2017-12-12 10:44:01 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.