Bug 1337619 - Redundant disk allocation label in VM dialogs if the template does not have disks
Summary: Redundant disk allocation label in VM dialogs if the template does not have d...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.0.4
: 4.0.4
Assignee: jniederm
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-19 15:58 UTC by ahauser
Modified: 2016-09-26 12:40 UTC (History)
14 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-09-26 12:40:24 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
tjelinek: devel_ack+
mavital: testing_ack+

Attachments (Terms of Use)
Screenshot of the web interface bug (44.80 KB, image/png)
2016-05-19 15:58 UTC, ahauser 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1251928 0 low CLOSED Disks Allocations section in new VM/resource allocation Disks Allocation is empty 2021-02-22 00:41:40 UTC
oVirt gerrit 57801 0 master MERGED webadmin: show "Disk Allocation" only when there are disks 2016-05-20 19:23:04 UTC
oVirt gerrit 58801 0 None None None 2016-07-20 16:39:52 UTC
oVirt gerrit 61145 0 ovirt-engine-4.0 MERGED webadmin: hide unnecessary label from Edit VM popup 2016-07-21 13:13:49 UTC

Internal Links: 1251928

Description ahauser 2016-05-19 15:58:58 UTC 
Created attachment 1159535 [details]
Screenshot of the web interface bug

Description of problem:

In the RHEV-M web interface, the bottom of the page of "resources allocation" in the VM properties menu ("edit menu") doesn't display correctly, like if the bottom of the page was "cut". I joined a screenshot to show the problem.

Version-Release number of selected component (if applicable):

3.6.5.3-0.1.el6

How reproducible:


Steps to Reproduce:
1. Log In to the Admin portal
2. Edit a VM settings
3. Go in the "Resources Allocation" menu

Actual results:

The bottom of the page of this menu is cut, showing only "disk allocation" without anything else (please check screenshot)

Expected results:

There should be something about disk allocation, the page doesn't look to display completely

Additional info:

Tested with various Linux distribution, with various Firefox and chromium releases
Comment 1 Tomas Jelinek 2016-05-20 08:54:47 UTC 
Hi Alexis,

I think the page only "looks" unfinished but actually there should be nothing more shown. You could check by selecting a template which has some disks and than going back to this tab - the list of disks will be shown under the "Disk Allocation:".

Can you please confirm this behavior?

thanx,
Tomas
Comment 2 ahauser 2016-05-20 09:22:55 UTC 
Hi Tomas,


yes, the page is displayed correctly when creating a VM and selecting a template.

However the mention "Disk allocation" (without anything else after) shouldn't appear when no template is used.
When a VM is created from template (in the template menu, with "make template"), it shouldn't appear either I guess.
Comment 3 Tomas Jelinek 2016-05-20 12:57:37 UTC 
I agree, it is confusing.
Fix posted - should land in 4.0
Comment 4 Tomas Jelinek 2016-05-31 06:13:37 UTC 
the fix does not handle it on all places, moving back to assigned
Comment 5 Idan Shaby 2016-07-21 05:26:15 UTC 
Sorry if I am misunderstanding here, but why isn't this bug a duplicate of bug 1251928?
Comment 6 Idan Shaby 2016-07-21 07:08:02 UTC 
Sorry, I've just noticed that bug 1251928 talks about new vm and this one's talking about edit vm.
The fix, however, seems to be the same patch.
Comment 7 Red Hat Bugzilla Rules Engine 2016-07-26 04:32:30 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 8 meital avital 2016-09-06 15:19:13 UTC 
Verified on version : 4.0.4-0.1.el7ev
Note You need to log in before you can comment on or make changes to this bug.