Bug 1338025 - rfkill is hard blocked on pre-2009 HP laptops
Summary: rfkill is hard blocked on pre-2009 HP laptops
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 22
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1338024 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-20 18:59 UTC by samoht0
Modified: 2016-07-31 15:02 UTC (History)
9 users (show)

Fixed In Version: kernel-4.6.3-300.fc24 kernel-4.5.7-202.fc23
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-30 21:25:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Testpatch from upstream (748 bytes, patch)
2016-05-21 13:06 UTC, samoht0
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Linux Kernel 69131 0 None None None 2016-05-20 18:59:55 UTC

Description samoht0 2016-05-20 18:59:55 UTC
Description of problem:

Wifi hard blocked by rfkill on ath9k/hp_wmi kernel modules.

Version-Release number of selected component (if applicable):

4.4.10-200.fc22.x86_64
longtime bug, see https://bugzilla.redhat.com/show_bug.cgi?id=954070

How reproducible:

Always.

Steps to Reproduce:

1.
Boot system. Wifi soft and hardware switch off.

2.
# rfkill list
0: hp-wifi: Wireless LAN
        Soft blocked: yes
        Hard blocked: yes
...
3: phy0: Wireless LAN
        Soft blocked: yes
        Hard blocked: yes

3.
Remove soft block and activate wifi hardware switch.

# rfkill list
0: hp-wifi: Wireless LAN
        Soft blocked: no
        Hard blocked: no
...
3: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: yes

Wifi don't work.

4.
Use /etc/modprobe.d/hp.conf to blacklist hp_wmi

5.
Reboot system. Wifi soft and hardware switch off.

6.
# rfkill list
0: phy0: Wireless LAN
        Soft blocked: yes
        Hard blocked: yes
[no hp-wifi]

7.
Remove soft block and activate wifi hardware switch. 

# rfkill list
0: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no
[no hp-wifi]

Wifi works.


Actual results:

Wifi blocked and hp_wmi need's to be blacklisted to use wifi.

Expected results:

Wifi working out of box.

Additional info:

Locks like this patch for hp_wmi fixed the issue for the testers, but didn't make it into mainline since March.

https://bugzilla.kernel.org/show_bug.cgi?id=69131#c13

F23 and F24 should be affected too.

Comment 1 samoht0 2016-05-20 19:24:03 UTC
*** Bug 1338024 has been marked as a duplicate of this bug. ***

Comment 2 samoht0 2016-05-21 13:06:29 UTC
Created attachment 1160120 [details]
Testpatch from upstream

Comment 3 Laura Abbott 2016-05-23 14:28:48 UTC
That patch does not have a Signed-off-by so it cannot be pulled into the Fedora tree. The patch author also needs to at least submit to a mailing list and have it reviewed by the maintainer.

Comment 4 samoht0 2016-05-23 16:48:19 UTC
To be honest, this is a little bit disappointing.
But well, if the patch isn't suitable, there's no need to keep the report open. Blacklisting hp_wmi is fine by me.

Comment 5 Laura Abbott 2016-05-23 20:18:25 UTC
The technical content of the patch is fine. If it had a Signed-off-by I could consider bringing it. The Signed-off-by is a legal requirement and I don't have any flexibility there. If you can get the patch author to submit an actual patch with a Signed-off-by we can re-evaluate.

Comment 6 David Ward 2016-06-13 20:37:38 UTC
(In reply to Laura Abbott from comment #5)
> The technical content of the patch is fine. If it had a Signed-off-by I
> could consider bringing it. The Signed-off-by is a legal requirement and I
> don't have any flexibility there. If you can get the patch author to submit
> an actual patch with a Signed-off-by we can re-evaluate.

Laura, the patch is now signed off by its author, and has been submitted to the kernel subsystem mailing list for review by maintainer and others:

http://permalink.gmane.org/gmane.linux.drivers.platform.x86.devel/9288

Please revert the status of this bug to NEW so this will still be tracked. Thanks.

Comment 7 Laura Abbott 2016-06-13 21:17:00 UTC
Yay! I've changed the status of the bug so it can be tracked again. I'm going to wait a few days to see if the maintainer has any comments before I bring it in.

Thanks for bringing this to my attention.

Comment 8 samoht0 2016-06-15 17:17:47 UTC
(In reply to David Ward from comment #6)
> 
> Laura, the patch is now signed off by its author, and has been submitted to
> the kernel subsystem mailing list for review by maintainer and others:
> 
> http://permalink.gmane.org/gmane.linux.drivers.platform.x86.devel/9288
> 
> Please revert the status of this bug to NEW so this will still be tracked.
> Thanks.

Great news! Thanks.

Comment 9 Fedora Update System 2016-06-25 11:47:42 UTC
kernel-4.6.3-300.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1c409313f4

Comment 10 Fedora Update System 2016-06-26 00:26:43 UTC
kernel-4.6.3-300.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1c409313f4

Comment 11 David Ward 2016-06-26 13:20:38 UTC
To make the errata more helpful, I would suggest updating the title of this bug — given both the content of the kernel patch, as well as the upstream bug report which shows a wider range of HP laptops affected by the same issue and addressed with this fix.

From these, we can see that:
 * the wireless chipset is not relevant (ath9k),
 * the issue is known to affect several different models of HP laptops believed to all be manufactured during a certain time period (before 2009), and
 * the rfkill settings that are impacted by this fix include not just Wi-Fi ('hp-wifi') but also Bluetooth ('hp-bluetooth'), WWAN ('hp-wwan'), and GPS ('hp-gps')

Perhaps the bug title should be closer to the following:
"rfkill is hard blocked on pre-2009 HP laptops"

Comment 12 Fedora Update System 2016-06-26 13:24:57 UTC
kernel-4.4.14-200.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-63ee0999e4

Comment 13 samoht0 2016-06-26 15:05:35 UTC
(In reply to David Ward from comment #11)
> To make the errata more helpful, I would suggest updating the title of this
> bug — given both the content of the kernel patch, as well as the upstream
> bug report which shows a wider range of HP laptops affected by the same
> issue and addressed with this fix.
> 
> From these, we can see that:
>  * the wireless chipset is not relevant (ath9k),
>  * the issue is known to affect several different models of HP laptops
> believed to all be manufactured during a certain time period (before 2009),
> and
>  * the rfkill settings that are impacted by this fix include not just Wi-Fi
> ('hp-wifi') but also Bluetooth ('hp-bluetooth'), WWAN ('hp-wwan'), and GPS
> ('hp-gps')
> 
> Perhaps the bug title should be closer to the following:
> "rfkill is hard blocked on pre-2009 HP laptops"

I didn't test the patch yet, since kernel-4.4.14-200.fc22 hasn't been pushed testing so far.

But I agree, this isn't a ath9k issue and dont't impact hp-wifi only. Especially on HP 635 bluetooth is not blocked and are no other hp-xxx devices present. But this seems to differ between the HP models.

I don't agree with "pre-2009". The HP 635 was introduced as low-end series in late summer 2011. See review from September 2011:
http://www.notebookcheck.net/Review-HP-635-LH416EA-ABD-Notebook.61035.0.html

I bought my laptop in September 2012. I've got the model which came with the later AMD E-450 APU and SUSE LED preinstalled.

Comment 14 Fedora Update System 2016-06-26 19:24:27 UTC
kernel-4.4.14-200.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-63ee0999e4

Comment 15 samoht0 2016-06-27 05:26:24 UTC
With kernel-4.4.14-200.fc22 still the same here. phy0 stays blocked as described in the report. There are two radio killswitches as before:

localhost NetworkManager[650]: <info>  rfkill2: found WiFi radio killswitch (at /sys/devices/platform/hp-wmi/rfkill/rfkill2 (platform driver hp-wmi)
localhost NetworkManager[650]: <info>  rfkill1: found WiFi radio killswitch (at /sys/devices/pci0000:00/0000:00:15.3/0000:0 (driver ath9k)

Maybe the upstream bug/patch and my issue are actually different.

Comment 16 David Ward 2016-06-28 01:32:57 UTC
(In reply to samoht0 from comment #13)
> (In reply to David Ward from comment #11)
> > To make the errata more helpful, I would suggest updating the title of this
> > bug [...]
> > "rfkill is hard blocked on pre-2009 HP laptops"
> 
> I don't agree with "pre-2009". The HP 635 was introduced as low-end series
> in late summer 2011. See review from September 2011:
> http://www.notebookcheck.net/Review-HP-635-LH416EA-ABD-Notebook.61035.0.html


(In reply to samoht0 from comment #15)
> With kernel-4.4.14-200.fc22 still the same here. phy0 stays blocked as
> described in the report. There are two radio killswitches as before [...]
> Maybe the upstream bug/patch and my issue are actually different.


I would agree with that — as I said, this patch is known to fix HP laptops manufactured in a certain time period before 2009, and your system is much newer than that. Since a fix has been pushed already for the earlier laptops, perhaps the title of this bug could be updated as I suggested, and then you could open a new bug in Fedora for your issue?

I think you may actually be affected by this other upstream kernel bug instead, which was reported for the HP 635:
https://bugzilla.kernel.org/show_bug.cgi?id=42898

Comment 17 samoht0 2016-06-28 17:35:11 UTC
(In reply to David Ward from comment #16)
> I would agree with that — as I said, this patch is known to fix HP laptops
> manufactured in a certain time period before 2009, and your system is much
> newer than that. Since a fix has been pushed already for the earlier
> laptops, perhaps the title of this bug could be updated as I suggested, and
> then you could open a new bug in Fedora for your issue?

Yes, sure. Changing the tile to fit the pushed fix avoids confusion.

Upstream kernel bug #42898 shows exactly the same symptoms. I will look, if I can dig out some helpful extra information, and if so, I'll file a new bug in Fedora (after installing F24).

Comment 18 Fedora Update System 2016-06-29 02:31:53 UTC
kernel-4.5.7-202.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-73a733f4d9

Comment 19 Fedora Update System 2016-06-29 18:26:00 UTC
kernel-4.5.7-202.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-73a733f4d9

Comment 20 samoht0 2016-06-30 18:56:12 UTC
Title edited.

Comment 21 Fedora Update System 2016-06-30 21:24:09 UTC
kernel-4.6.3-300.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2016-07-02 19:24:29 UTC
kernel-4.5.7-202.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2016-07-19 07:18:41 UTC
kernel-4.4.14-200.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 samoht0 2016-07-31 15:02:21 UTC
As David Ward suggested, I filed my updated Information into upstream kernel bug #42898, which fits my HP 635 and the typical symptoms:

https://bugzilla.kernel.org/show_bug.cgi?id=42898#c8

I truly hope, this will get more attention by upstream than in the last 4 1/2 years. I (currently) didn't file a new bug in Fedora's bugzilla, since there is no proposed fix.

With pre-2009 HP laptops fixed this bug keeps closed.


Note You need to log in before you can comment on or make changes to this bug.