Spec URL: https://github.com/minfrin/mod_ical/blob/master/mod_ical.spec SRPM URL: https://github.com/minfrin/mod_ical/releases/download/mod_ical-0.0.6/mod_ical-0.0.6-1.el7.centos.src.rpm Description: The Apache mod_ical module provides a set of filters to filter RFC5545 iCalendar data and convert it to RFC6321 xCal / RFC7265 jCal. Fedora Account System Username: minfrin
Please split BuildRequires for one per line. From first glance looks good. Also you need sponsorship.
Hi Graham, I'm not a sponsor so I cant do full review (afaik). Please consider the following points related to Apache httpd modules packaging best practices (ie: not in the guidelines but should be implemented): 1. You should include a config file that loads the module eg "20-mod_ical.conf", then install it into httpd modules config dir. # cat 20-mod_ical.conf LoadModule ical_module modules/mod_ical.so Spec changes: ... Source1: 20-mod_ical.conf ... ... install -Dp -m0644 %{SOURCE1} %{buildroot}%{_httpd_modconfdir}/20-mod_ical.conf ... 2. The module should require httpd binary interface that was built on, ie add: Requires: httpd-mmn = %{_httpd_mmn} 3. You should use macros instead of hardcoded paths, ie: Replace "%{_libdir}/httpd/modules/mod_ical.so" with "%{_httpd_moddir}/mod_ical.so"
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.