Bug 1338793
| Summary: | anaconda screen width exceeds display width if product title is to long | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Fabian Deutsch <fdeutsch> | ||||||
| Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Release Test Team <release-test-team-automation> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 7.2 | CC: | anaconda-maint-list, aoconnor, bmcclain, cshao, jkonecny, jstodola, nlevy, sbonazzo, sbueno, weiwang, ycui | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2019-12-16 08:22:33 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1720490 | ||||||||
| Attachments: |
|
||||||||
|
Description
Fabian Deutsch
2016-05-23 12:34:07 UTC
I'm not sure what can be done about the long title, but there is a IsFinal boolean in .buildstamp that controls whether or not the beta dialog is shown. Can't long titles be wrapped into a second line? And yes, we are using the isFinal key, I was just thinking if an additional switch for a TechPreview might be helpful as well. Created attachment 1161999 [details] long title wrapped (In reply to Fabian Deutsch from comment #2) > Can't long titles be wrapped into a second line? Yeah, I suppose. That sure is a lot of title, though. Attached a screenshot of what it looks like with that long string in .buildstamp and some wrap properties monkey-patched in with gtk inspector. > And yes, we are using the isFinal key, I was just thinking if an additional > switch for a TechPreview might be helpful as well. What you're really asking for is a second title line. Besides this being a large change (another label in every screen, changes to how .buildstamp is created and read), it's bound to lead to someone asking for a third title. I do not think this would be a good idea. (In reply to David Shea from comment #3) > Created attachment 1161999 [details] > long title wrapped > > (In reply to Fabian Deutsch from comment #2) > > Can't long titles be wrapped into a second line? > > Yeah, I suppose. That sure is a lot of title, though. > > Attached a screenshot of what it looks like with that long string in > .buildstamp and some wrap properties monkey-patched in with gtk inspector. As you can see I also centered it, since I thought it looked weird with two lines left justified. We may want to do the same to the "What language..." string below it. Created attachment 1162011 [details]
long title ellipsized
Here's another possibility. Long titles are cut off if they do not fit in the window.
You might be able to put non-breaking spaces (U+00A0 " ") in the string to influence wrap behavior, but regardless that string is just too long.
why are there two version numbers?
Maybe the tech preview part of the string should get taken out, and the words "Technology Preview" could get put in the place that says PRE-RELEASE / TESTING.
Maybe anaconda could check if the string is too long and use a different string ("Welcome to Installer" ?), or check if the string is too long and apply a compat/smaller style to it.
I wonder if a better solution would be to use a translated image file instead of text. Then the layout could be more carefully controlled and branded by the brand team.
(In reply to Ray Strode [halfline] from comment #6) > why are there two version numbers? That was my bad. I just stuck the string into .buildstamp using a RHEL 7.3 install disc, and I was really lazy about it. Pretend the 7.3 isn't there. This missed 7.2.z -> 7.6; can we have a target milestone for this? 7.6.z? 7.7? Anaconda is not doing Z streams but we will look on this issue during 7.7 planning. Missed 7.7, I assume that if this get fixed for 7.8 it will be fixed also in 8.1 right? Could you please answer the comment above? (In reply to Sandro Bonazzola from comment #10) > Missed 7.7, I assume that if this get fixed for 7.8 it will be fixed also in > 8.1 right? Not necessarily, because 8.1 is on a different development period than 7.8 (devel/test phase ends sooner in 8.1 than it does in 7.8). However, even though there is discussion and some proposals here, there is no agreement on how to fix this. I'm not a big fan of wrapping the title on to another line. Ray's proposal sounds interesting, but I'd like to hear what you think about that, Sandro. (In reply to Samantha N. Bueno from comment #12) > (In reply to Sandro Bonazzola from comment #10) > > Missed 7.7, I assume that if this get fixed for 7.8 it will be fixed also in > > 8.1 right? > > Not necessarily, because 8.1 is on a different development period than 7.8 > (devel/test phase ends sooner in 8.1 than it does in 7.8). However, even > though there is discussion and some proposals here, there is no agreement on > how to fix this. I'm not a big fan of wrapping the title on to another line. > Ray's proposal sounds interesting, but I'd like to hear what you think about > that, Sandro. I think we are not using anymore "Red Hat Enterprise Virtualization Hypervisor 3.6 Technology Preview" since now the product is "Red Hat Virtualization Host" and we are out of "Technology Preview" phase. Being the title shorter this may not be an issue anymore. Nir, can you please check if this is still an issue? as for rhvh-4.4 welcome screen has a decent title. closing this as current release according to comment #16 |