Bug 1338834 - Option to override cluster migration policy in vm level is absent
Summary: Option to override cluster migration policy in vm level is absent
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.0.0-rc
: ---
Assignee: Alexander Wels
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-23 13:52 UTC by sefi litmanovich
Modified: 2016-07-05 08:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 08:04:35 UTC
oVirt Team: Virt
rule-engine: ovirt-4.0.0+
rule-engine: blocker+
rule-engine: planning_ack+
tjelinek: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)
screenshot (2.11 MB, image/png)
2016-05-23 13:52 UTC, sefi litmanovich 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 57982 0 master MERGED webadmin: Override migration policy 2016-05-25 07:45:33 UTC

Description sefi litmanovich 2016-05-23 13:52:22 UTC 
Created attachment 1160639 [details]
screenshot

Description of problem:

New cluster migration policies were introduced on ovirt-4.0 beta.
The plan was to include the option to override the policy in vm level - under 'host' sub tab in new/edit vm menu.
The option is not there.

Version-Release number of selected component (if applicable):
ovirt-engine-4.0.0-0.7.master.el7ev.noarch

How reproducible:
always

Steps to Reproduce:
1. set cluster migration policy (to whatever you like)
2. create/edit a vm in the cluster, look for migration policy option


Actual results:
no migration policy option exists in vm.

Expected results:
Policy is changeable from this menu
Comment 1 Tomas Jelinek 2016-05-23 14:38:27 UTC 
It is a regression introduced by Ia95e6aba555e09d36643b091a9428b6edf366495 "userportal,webadmin: tab dialog scroll".

@Alex, could you please have a look? The migrationPolicyEditor, overrideMigrationPolicyEditorWithDetachable etc have disappeared from the dialog.
Comment 2 Alexander Wels 2016-05-23 14:59:00 UTC 
Of course, can you show me what it should look like? I tried to make 100% sure I didn't mangle anything but obviously I did. I am happy to add stuff I broke back, but I am not sure what I broke.
Comment 3 Tomas Jelinek 2016-05-24 06:58:59 UTC 
this section has disappeared:

<g:FlowPanel addStyleNames="{style.migrationFieldsPanel}">
<ge:EntityModelDetachableWidget ui:field="overrideMigrationPolicyEditorWithDetachable" addStyleNames="{style.overrideMigrationFields} avmpw_overrideMigrationFields_pfly_fix" contentWidgetContainerStyle="{style.overrideMigrationFieldsContentEditor}" />
<l:EnableableFormLabel ui:field="overrideMigrationPolicyLabel" text="{constants.overrideMigrationPolicyLabel}" addStyleNames="{style.migrationFieldsLabel} avmpw_migrationFieldsLabel_pfly_fix" />
d:InfoIcon ui:field="migrationPolicyInfoIcon" addStyleNames="{style.migrationFieldsInfoIcon} avmpw_infoIcon_pfly_fix" />
<e:ListModelListBoxOnlyEditor ui:field="migrationPolicyEditor" addStyleNames="{style.migrationFields}" />
</g:FlowPanel>

and the migrationPolicyInfoIcon has been placed to the overrideMigrationDowntimeLabel (instead of the migrationDowntimeInfoIcon)
Comment 4 Alexander Wels 2016-05-24 17:37:21 UTC 
Added the appropriate fields back in. Sorry for the mistake.
Comment 5 Tomas Jelinek 2016-05-25 07:45:13 UTC 
np, thank you for the quick response
Comment 6 sefi litmanovich 2016-06-05 10:39:16 UTC 
Verified with ovirt-engine-4.0.0.2-0.1.el7ev.noarch, option exists on both UI and API.
Comment 7 Sandro Bonazzola 2016-07-05 08:04:35 UTC 
oVirt 4.0.0 has been released, closing current release.
Note You need to log in before you can comment on or make changes to this bug.