Bug 1338967 - common-ha: ganesha.nfsd not put into NFS-GRACE after fail-back
Summary: common-ha: ganesha.nfsd not put into NFS-GRACE after fail-back
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: common-ha
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1338968 1338969
TreeView+ depends on / blocked
 
Reported: 2016-05-23 18:32 UTC by Kaleb KEITHLEY
Modified: 2016-12-06 05:20 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1338968 (view as bug list)
Environment:
Last Closed: 2016-12-06 05:20:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2016-05-23 18:32:25 UTC
Description of problem:

The surviving ganesha.nfsds are put into NFS-GRACE after a fail-over (triggered when one of the ganesha.nfsds dies).

When the ganesha.nfsd is restarted and the floating IP (VIP) fails back, the original surviving ganesha.nfsds should be put into NFS-GRACE again for post fail-back lock recovery, etc.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-05-23 19:26:55 UTC
REVIEW: http://review.gluster.org/14506 (common-ha: post fail-back, ganesha.nfsds are not put into NFS-GRACE) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Vijay Bellur 2016-05-23 19:48:40 UTC
REVIEW: http://review.gluster.org/14506 (common-ha: post fail-back, ganesha.nfsds are not put into NFS-GRACE) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Vijay Bellur 2016-05-24 08:41:21 UTC
COMMIT: http://review.gluster.org/14506 committed in master by Niels de Vos (ndevos) 
------
commit db817ff68125f89adba76080e8e93d4a4e72d549
Author: Kaleb S KEITHLEY <kkeithle>
Date:   Mon May 23 15:30:23 2016 -0400

    common-ha: post fail-back, ganesha.nfsds are not put into NFS-GRACE
    
    A little known, rarely used feature of pacemaker called
    "notification" is used to follow the status of the ganesha.nfsds
    in the cluster. This is done with location constraints and other
    Black Magick.
    
    When a nfsd dies, the ganesha-active attribute is cleared, the
    associated floating IP (VIP) fails over to another node, and the
    ganesha_grace notify method is invoked with post-stop on all the
    nodes where the ganesha.nfsd is still running. The notify methods
    send dbus msgs to put their nfsds into NFS-GRACE, and the nfsds
    perform their grace processing, e.g. taking over locks from the
    failed nfsd.
    
    N.B. Fail-back was originally not planned to be a feature for
    glusterfs-3.7, but we sorta got it for free.
    
    For fail-back, the opposite occurs. The ganesha-active attribute
    is recreated, the floating IP fails back, and the notify method is
    invoked with pre-start on all the nodes where the surviving
    ganesha.nfsds continue to run. The notify methods send dbus msgs
    again to put their nsfds into NFS-GRACE again, and the nfsds clean
    up their locks.
    
    Change-Id: I3fc64afa20ae3a928143d69aa533a8df68dd680e
    BUG: 1338967
    Signed-off-by: Kaleb S KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/14506
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Niels de Vos <ndevos>


Note You need to log in before you can comment on or make changes to this bug.