Spec URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libintelnvm-i18n.spec SRPM URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm Description: Internationalization library Fedora Account System Username: nkothapa
> %define rpm_name libintelnvm-i18n > %define build_version 1.0.0.1014 > %define build_release 1 > %define dname %{rpm_name}-devel Drop these variable and use the values directly. > %define debug_package %{nil} Drop, I see no reason to suppress debuginfo builds. > %build > make BUILDNUM=%{build_version} RELEASE=1 Need to include the distro CFLAGS in the build. > %files > %attr(755,root,root) %{_libdir}/libintelnvm-i18n.so.* > %license licenses/intel_bsd > > %files -n %dname > %attr(755,root,root) %{_libdir}/libintelnvm-i18n.so > %attr(755,root,root) %dir %{_includedir}/libintelnvm-i18n > %attr(644,root,root) %{_includedir}/libintelnvm-i18n/*.h Drop the attr settings. > %license licenses/intel_bsd How is intel_bsd different than bsd? # fedora-review -v --rpm-spec -n libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm libintelnvm-i18n.x86_64: W: incoherent-version-in-changelog ichard.a.johnson ['1.0.0.1014-1.fc24', '1.0.0.1014-1'] libintelnvm-i18n.x86_64: W: unstripped-binary-or-object /usr/lib64/libintelnvm-i18n.so.1.0.0 libintelnvm-i18n.x86_64: W: no-documentation libintelnvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib libintelnvm-i18n-devel.x86_64: W: no-documentation
Updated the spec file to not supress debuginfo, include CFLAGS in build, removed all variables but build_version, added doc macro. Need attr settings for security purposes. intel_bsd is the same as bsd, the file is named intel_bsd here. Probably named so because there is also a licenses/netbsd. Not sure why only-non-binary-in-usr-lib this is flagged. The same binary doesn't raise this flag in non devel files.
Updated tag to libintelnvm-i18n-<version> from v<version> Also, removed attr settings. Spec: https://github.com/01org/intelnvmi18nlibrary/releases/download/libintelnvm-i18n-1.0.0.1014/libintelnvm-i18n.spec SRPM: https://github.com/01org/intelnvmi18nlibrary/releases/download/libintelnvm-i18n-1.0.0.1014/libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm
Revert tag to v<version>. Update spec and tags to have GitHub's auto archiving produce a properly formatted tarball per feedback. Spec URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libintelnvm-i18n.spec SRPM URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm
Apologies for the delay circling back to this. A couple review items: 1/ fedora-review notices that %{?_smp_mflags} is missing from the make line 2/ I see the addition of: CFLAGS_EXTERNAL="%{?cflag}" in the latest spec file but I do not see CFLAGS_EXTERNAL referenced in the makefile. Also, the rpm variable to add the distribution specific compiler flags is: %{optflags}
Updated spec and package names to comply with Red Hat's open source packaging policies. Spec URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libinvm-i18n.spec SRPM URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libinvm-i18n-1.0.0.1014-1.fc23.src.rpm
Looks good, only two final tasks that I see: 1/ Flesh out %description it's currently too sparse. For example clarify that it is a base / common library for other "invm" components. 2/ Run fedora-review and supply a filled out template of "review.txt".
Here's the result of a fedora-review run with the rest of the template filled out. C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /media/intelnvmi18nlibrary/output/rpmbuild/SRPMS/1339327-libinvm- i18n/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libinvm- i18n-debuginfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define build_version 1.0.0.1014 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libinvm-i18n-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-devel-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-debuginfo-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-1.0.0.1014-1.fc23.src.rpm libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib libinvm-i18n-debuginfo.x86_64: E: debuginfo-without-sources libinvm-i18n.src: W: file-size-mismatch libinvm-i18n-1.0.0.1014.tar.gz = 14031, https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1014.tar.gz#/libinvm-i18n-1.0.0.1014.tar.gz = 14039 4 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: libinvm-i18n-debuginfo-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libinvm-i18n-debuginfo.x86_64: E: debuginfo-without-sources libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib 3 packages and 0 specfiles checked; 1 errors, 1 warnings. Requires -------- libinvm-i18n-debuginfo (rpmlib, GLIBC filtered): libinvm-i18n (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) libinvm-i18n-devel (rpmlib, GLIBC filtered): libinvm-i18n(x86-64) libinvm-i18n.so.1()(64bit) Provides -------- libinvm-i18n-debuginfo: libinvm-i18n-debuginfo libinvm-i18n-debuginfo(x86-64) libinvm-i18n: libinvm-i18n libinvm-i18n(x86-64) libinvm-i18n.so.1()(64bit) libinvm-i18n-devel: libinvm-i18n-devel libinvm-i18n-devel(x86-64) Source checksums ---------------- https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1014.tar.gz#/libinvm-i18n-1.0.0.1014.tar.gz : CHECKSUM(SHA256) this package : ae0c1570a29e939dee4acfb55769219c6ba95e8e1e3bb07c5d8d0d59f28d0a94 CHECKSUM(SHA256) upstream package : e5c540e7fc1a277615d9b0183a0657acfe9a1e010f8e0878a11e80e6ded3cbd8 diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1339327 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Looks good, please review the pending check list items "[ ]" and disposition them as [x], [-], or [!].
Updated review. C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /media/intelnvmi18nlibrary/output/rpmbuild/SRPMS/1339327-libinvm- i18n/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libinvm- i18n-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define build_version 1.0.0.1014 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libinvm-i18n-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-devel-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-debuginfo-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-1.0.0.1014-1.fc23.src.rpm libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib libinvm-i18n-debuginfo.x86_64: E: debuginfo-without-sources libinvm-i18n.src: W: file-size-mismatch libinvm-i18n-1.0.0.1014.tar.gz = 14031, https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1014.tar.gz#/libinvm-i18n-1.0.0.1014.tar.gz = 14039 4 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: libinvm-i18n-debuginfo-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libinvm-i18n-debuginfo.x86_64: E: debuginfo-without-sources libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib 3 packages and 0 specfiles checked; 1 errors, 1 warnings. Requires -------- libinvm-i18n-debuginfo (rpmlib, GLIBC filtered): libinvm-i18n (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) libinvm-i18n-devel (rpmlib, GLIBC filtered): libinvm-i18n(x86-64) libinvm-i18n.so.1()(64bit) Provides -------- libinvm-i18n-debuginfo: libinvm-i18n-debuginfo libinvm-i18n-debuginfo(x86-64) libinvm-i18n: libinvm-i18n libinvm-i18n(x86-64) libinvm-i18n.so.1()(64bit) libinvm-i18n-devel: libinvm-i18n-devel libinvm-i18n-devel(x86-64) Source checksums ---------------- https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1014.tar.gz#/libinvm-i18n-1.0.0.1014.tar.gz : CHECKSUM(SHA256) this package : ae0c1570a29e939dee4acfb55769219c6ba95e8e1e3bb07c5d8d0d59f28d0a94 CHECKSUM(SHA256) upstream package : e5c540e7fc1a277615d9b0183a0657acfe9a1e010f8e0878a11e80e6ded3cbd8 diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1339327 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Updated release v1.0.0.1014 Spec URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libinvm-i18n.spec SRPM URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libinvm-i18n-1.0.0.1014-1.fc23.src.rpm Here's the latest review template without the debuginfo-without-sources error: C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/namu/1339327-libinvm-i18n/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libinvm- i18n-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define build_version 1.0.0.1014 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libinvm-i18n-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-devel-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-debuginfo-1.0.0.1014-1.fc23.x86_64.rpm libinvm-i18n-1.0.0.1014-1.fc23.src.rpm libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib libinvm-i18n.src: W: file-size-mismatch libinvm-i18n-1.0.0.1014.tar.gz = 14108, https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1014.tar.gz#/libinvm-i18n-1.0.0.1014.tar.gz = 14039 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: libinvm-i18n-debuginfo-1.0.0.1014-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libinvm-i18n-debuginfo.x86_64: W: invalid-url URL: https://01.org/intel-nvm-i18n-library <urlopen error [Errno -3] Temporary failure in name resolution> libinvm-i18n.x86_64: W: invalid-url URL: https://01.org/intel-nvm-i18n-library <urlopen error [Errno -3] Temporary failure in name resolution> libinvm-i18n-devel.x86_64: W: invalid-url URL: https://01.org/intel-nvm-i18n-library <urlopen error [Errno -3] Temporary failure in name resolution> libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- libinvm-i18n-debuginfo (rpmlib, GLIBC filtered): libinvm-i18n (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) libinvm-i18n-devel (rpmlib, GLIBC filtered): libinvm-i18n(x86-64) libinvm-i18n.so.1()(64bit) Provides -------- libinvm-i18n-debuginfo: libinvm-i18n-debuginfo libinvm-i18n-debuginfo(x86-64) libinvm-i18n: libinvm-i18n libinvm-i18n(x86-64) libinvm-i18n.so.1()(64bit) libinvm-i18n-devel: libinvm-i18n-devel libinvm-i18n-devel(x86-64) Source checksums ---------------- https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1014.tar.gz#/libinvm-i18n-1.0.0.1014.tar.gz : CHECKSUM(SHA256) this package : 5e1d243e75ec560cbceba10f45b240ffa0de3b093c20e001f468f2b6ccd576aa CHECKSUM(SHA256) upstream package : e5c540e7fc1a277615d9b0183a0657acfe9a1e010f8e0878a11e80e6ded3cbd8 diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1339327 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Created new release v1.0.0.1015 Spec URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1015/libinvm-i18n.spec SRPM URL: https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1015/libinvm-i18n-1.0.0.1015-1.fc23.src.rpm
Renamed the repo to libinvm-i18n.Updated URLs are: Spec URL: https://github.com/01org/libinvm-i18n/releases/download/v1.0.0.1015/libinvm-i18n.spec SRPM URL: https://github.com/01org/libinvm-i18n/releases/download/v1.0.0.1015/libinvm-i18n-1.0.0.1015-1.fc23.src.rpm
rpmlint from fedora-review report below. Got rid of file-size-mismatch warning. Rpmlint ------- Checking: libinvm-i18n-1.0.0.1015-1.fc23.x86_64.rpm libinvm-i18n-devel-1.0.0.1015-1.fc23.x86_64.rpm libinvm-i18n-debuginfo-1.0.0.1015-1.fc23.x86_64.rpm libinvm-i18n-1.0.0.1015-1.fc23.src.rpm libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib libinvm-i18n.src: W: invalid-url Source0: https://github.com/01org/intelnvmi18nlibrary/archive/v1.0.0.1015.tar.gz#/libinvm-i18n-1.0.0.1015.tar.gz HTTP Error 503: Service Unavailable 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: libinvm-i18n-debuginfo-1.0.0.1015-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libinvm-i18n-devel.x86_64: W: only-non-binary-in-usr-lib 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Looks good to me.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libinvm-i18n
Package request has been denied with the reason: Resubmitting, error.