Bug 1339406 (kf5-libkdepim) - Review Request: kf5-libkdepim - lib for common kdepim apps
Summary: Review Request: kf5-libkdepim - lib for common kdepim apps
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-libkdepim
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christian Dersch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5-eventviews kf5-pimcommon kf5-messagelib kf5-mailimporter kf5-mailcommon kf5-libksieve
TreeView+ depends on / blocked
 
Reported: 2016-05-24 22:24 UTC by Rex Dieter
Modified: 2016-05-26 00:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-25 18:25:01 UTC
Type: ---
Embargoed:
lupinix.fedora: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2016-05-24 22:24:08 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-libkdepim.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-libkdepim-16.04.1-1.fc24.src.rpm
Description: lib for common kdepim apps
Fedora Account System Username: rdieter

Comment 1 Rex Dieter 2016-05-25 15:22:35 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14249166

(though I'm not 100% certain all the deps are in rawhide yet)

Comment 2 Christian Dersch 2016-05-25 15:34:27 UTC
Looks fine :) => Approved


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2 or later)",
     "Unknown or generated", "GPL (v2 or later) (with Qt exception)", "GPL
     (v2)". 3 files have unknown license. Detailed output of licensecheck
     in /home/review/1339406-kf5-libkdepim/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/dbus-1,
     /usr/lib64/cmake, /usr/lib64/qt5/mkspecs,
     /usr/lib64/qt5/mkspecs/modules, /usr/include/KF5, /usr/lib64/qt5,
     /usr/share/dbus-1/interfaces
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/kdepimwidgets
     (kdepim-common), /usr/share/kdepimwidgets/pics(kdepim-common)

===> We have a proper "Conflicts" here => Fine

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[?]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.

==> Did you ask upstream?

[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5
     -libkdepim-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kf5-libkdepim-16.04.1-1.fc25.x86_64.rpm
          kf5-libkdepim-devel-16.04.1-1.fc25.x86_64.rpm
          kf5-libkdepim-debuginfo-16.04.1-1.fc25.x86_64.rpm
          kf5-libkdepim-16.04.1-1.fc25.src.rpm
kf5-libkdepim.x86_64: W: spelling-error Summary(en_US) kdepim -> epidemic
kf5-libkdepim.x86_64: W: summary-not-capitalized C lib for common kdepim apps
kf5-libkdepim.x86_64: W: spelling-error %description -l en_US kdepim -> epidemic
kf5-libkdepim.x86_64: W: obsolete-not-provided kdepim-libs
kf5-libkdepim.x86_64: W: no-documentation
kf5-libkdepim.x86_64: W: non-conffile-in-etc /etc/xdg/libkdepim.categories
kf5-libkdepim-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-libkdepim-devel.x86_64: W: no-documentation
kf5-libkdepim.src: W: spelling-error Summary(en_US) kdepim -> epidemic
kf5-libkdepim.src: W: summary-not-capitalized C lib for common kdepim apps
kf5-libkdepim.src: W: spelling-error %description -l en_US kdepim -> epidemic
4 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (debuginfo)
-------------------
Checking: kf5-libkdepim-debuginfo-16.04.1-1.fc25.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
kf5-libkdepim-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-libkdepim-devel.x86_64: W: no-documentation
kf5-libkdepim.x86_64: W: spelling-error Summary(en_US) kdepim -> epidemic
kf5-libkdepim.x86_64: W: summary-not-capitalized C lib for common kdepim apps
kf5-libkdepim.x86_64: W: spelling-error %description -l en_US kdepim -> epidemic
kf5-libkdepim.x86_64: W: obsolete-not-provided kdepim-libs
kf5-libkdepim.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Libkdepim.so.5.2.1 /lib64/libKF5Service.so.5
kf5-libkdepim.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Libkdepim.so.5.2.1 /lib64/libQt5Xml.so.5
kf5-libkdepim.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Libkdepim.so.5.2.1 /lib64/libKF5Auth.so.5
kf5-libkdepim.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Libkdepim.so.5.2.1 /lib64/libm.so.6
kf5-libkdepim.x86_64: W: no-documentation
kf5-libkdepim.x86_64: W: non-conffile-in-etc /etc/xdg/libkdepim.categories
3 packages and 0 specfiles checked; 0 errors, 12 warnings.



Requires
--------
kf5-libkdepim-devel (rpmlib, GLIBC filtered):
    cmake(KF5Gpgmepp)
    kf5-libkdepim(x86-64)
    libKF5Libkdepim.so.5()(64bit)

kf5-libkdepim-debuginfo (rpmlib, GLIBC filtered):

kf5-libkdepim (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    kf5-filesystem
    libKF5AkonadiContact.so.5()(64bit)
    libKF5AkonadiCore.so.5()(64bit)
    libKF5AkonadiSearchPIM.so.5()(64bit)
    libKF5AkonadiWidgets.so.5()(64bit)
    libKF5Auth.so.5()(64bit)
    libKF5Codecs.so.5()(64bit)
    libKF5Completion.so.5()(64bit)
    libKF5ConfigCore.so.5()(64bit)
    libKF5ConfigGui.so.5()(64bit)
    libKF5ConfigWidgets.so.5()(64bit)
    libKF5Contacts.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5IconThemes.so.5()(64bit)
    libKF5ItemModels.so.5()(64bit)
    libKF5ItemViews.so.5()(64bit)
    libKF5JobWidgets.so.5()(64bit)
    libKF5KCMUtils.so.5()(64bit)
    libKF5KIOCore.so.5()(64bit)
    libKF5KIOWidgets.so.5()(64bit)
    libKF5Ldap.so.5()(64bit)
    libKF5Libkdepim.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libKF5Wallet.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.6)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libQt5Xml.so.5()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)



Provides
--------
kf5-libkdepim-devel:
    cmake(KF5Libkdepim)
    cmake(MailTransportDBusService)
    kf5-libkdepim-devel
    kf5-libkdepim-devel(x86-64)

kf5-libkdepim-debuginfo:
    kf5-libkdepim-debuginfo
    kf5-libkdepim-debuginfo(x86-64)

kf5-libkdepim:
    kf5-libkdepim
    kf5-libkdepim(x86-64)
    libKF5Libkdepim.so.5()(64bit)



Unversioned so-files
--------------------
kf5-libkdepim: /usr/lib64/qt5/plugins/designer/kdepimwidgets.so
kf5-libkdepim: /usr/lib64/qt5/plugins/kcm_ldap.so

Source checksums
----------------
http://download.kde.org/stable/applications/16.04.1/src/libkdepim-16.04.1.tar.xz :
  CHECKSUM(SHA256) this package     : 19cbf5e69bcc0b04f06908450d15a3c6d21b49c0b6b885f73617c82f11d1930f
  CHECKSUM(SHA256) upstream package : 19cbf5e69bcc0b04f06908450d15a3c6d21b49c0b6b885f73617c82f11d1930f


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1339406
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Rex Dieter 2016-05-25 16:03:22 UTC
Thanks!

pkgdb request submitted

Comment 4 Gwyn Ciesla 2016-05-25 16:04:27 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libkdepim

Comment 5 Rex Dieter 2016-05-25 18:25:01 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.