RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1339572 - Improve some logs about hotkeys
Summary: Improve some logs about hotkeys
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virt-viewer
Version: 7.3
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: rc
: ---
Assignee: Pavel Grunt
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 1351876
TreeView+ depends on / blocked
 
Reported: 2016-05-25 11:09 UTC by Xiaodai Wang
Modified: 2016-11-04 01:20 UTC (History)
8 users (show)

Fixed In Version: virt-viewer-2.0-8.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1351876 (view as bug list)
Environment:
Last Closed: 2016-11-04 01:20:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2229 0 normal SHIPPED_LIVE virt-viewer, libgovirt, spice-gtk, and usbredir bug fix and enhancement update 2016-11-03 13:26:58 UTC

Description Xiaodai Wang 2016-05-25 11:09:36 UTC
Description of problem:
Improve some logs about hotkeys

Version-Release number of selected component (if applicable):
virt-viewer-2.0-7.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running guest.
2. Run "virt-viewer -c qemu:///system $guest --hotkeys=toggle-fullscreen=shift+f11".
3. Run "virt-viewer -c qemu:///system $guest --hotkeys=invalid_hotkeys"


Actual results:
After step2 and step3, "(virt-viewer:1265): virt-viewer-WARNING **: disabling smartcard shortcuts" appears in terminal.
After step3, "(virt-viewer:3049): virt-viewer-WARNING **: (virt-viewer-app.c:2071):virt_viewer_app_set_hotkeys: code should not be reached" appears. 

Expected results:
1. It's better to not display non-relevant smartcard shortcuts log in terminal.
2. "code should not be reached" is not a good hint for users. It's better to give some hint about invalid hotkey settings.


Additional info:

Comment 2 Pavel Grunt 2016-05-30 09:28:11 UTC
Patches posted: https://www.redhat.com/archives/virt-tools-list/2016-May/msg00095.html

Comment 3 Pavel Grunt 2016-06-02 09:10:10 UTC
Improved upstream by commits:
7d7e8c2aae15d6d161f4651da4bb7b70bde9118d
9a3041eb0062128c84d96f37c5ead61c6f3aaa26
ffa460b8c6a1c900eb155d06245f42693bd13f3b

Comment 5 Xiaodai Wang 2016-07-01 05:51:20 UTC
I verified it with virt-viewer-2.0-9.el7.x86_64 following the steps in #comment 0.

$ virt-viewer -c qemu:///system rhel7.2 --hotkeys=invalid

(virt-viewer:18800): virt-viewer-WARNING **: missing value for key 'invalid'
$ virt-viewer -c qemu:///system rhel7.2 --hotkeys=invalid=a

(virt-viewer:18827): virt-viewer-WARNING **: Unknown hotkey command invalid

From above logs, we can see no unnecessary smartcard logs display and the correct warning log display for incorrect hotkeys setting.

So move the bug from ON_QA to VERIFIED.

Comment 7 errata-xmlrpc 2016-11-04 01:20:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2229.html


Note You need to log in before you can comment on or make changes to this bug.