Bug 133996 - unitialized variables used for parsing options / received signal 11
Summary: unitialized variables used for parsing options / received signal 11
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 3
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jeremy Katz
QA Contact: Mike McLean
Depends On:
TreeView+ depends on / blocked
Reported: 2004-09-28 21:18 UTC by bjorn l.
Modified: 2007-11-30 22:10 UTC (History)
1 user (show)

Clone Of:
Last Closed: 2004-10-01 17:59:01 UTC

Attachments (Terms of Use)

Description bjorn l. 2004-09-28 21:18:10 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510

Description of problem:
When using the harddrive kickstart option, anaconda fails
   install exited abnormally - received signal 11

In looking and testing at the code, it appears that some
variables are not initialized properly.  For example, in
file hdinstall.c, function setKickstartHD, the addresses
of biospart, partition, and dir are passed to poptGetContext.

But it appears that if the corresponding option is not
selected in harddisk, then that variable is not updated,
yielding a segmentation violation later, when referenced.

Similar uninitialized variables appear to exist in
- setKickstartURL (char *url)
- useKickstartDD (char *src)

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Whether it is reproducible depends on the state of memory previously
2. Attempt a harddisk install from a kickstart file, without setting

Actual Results:    install exited abnormally - received signal 11

Expected Results:  install should have succeeded

Additional info:

Comment 1 Jeremy Katz 2004-09-28 22:06:18 UTC
Fixed in CVS

Comment 2 bjorn l. 2004-10-01 17:25:56 UTC
Thanks for the quick update.  I tested it with anaconda-,
and it works.

But I did notice that in file driverdisk.c, function useKickstartDD,
src remains unitialized (as also listed in the bug description
above).  Unlike in the harddrive case, a segmentation
violation can only occur if the syntax of the driverdisk is not
correct (missing args), so it's not as likely.  But by simply
initializing src to NULL, anaconda would provide a descriptive warning
and proceed, instead of a signal 11 error message and crash.

Comment 3 Jeremy Katz 2004-10-01 17:59:01 UTC
Thanks, fixed.

Note You need to log in before you can comment on or make changes to this bug.