Bug 1339993 - False flash message displayed when clicked on commit while importing service dialog
Summary: False flash message displayed when clicked on commit while importing service...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.0
Assignee: Zita Nemeckova
QA Contact: Shveta
URL:
Whiteboard: import:service:dialog:ui
Depends On:
Blocks: 1341671
TreeView+ depends on / blocked
 
Reported: 2016-05-26 10:13 UTC by Niyaz Akhtar Ansari
Modified: 2017-01-12 05:03 UTC (History)
6 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1341671 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:05:28 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (63.12 KB, image/png)
2016-05-26 10:13 UTC, Niyaz Akhtar Ansari
no flags Details

Description Niyaz Akhtar Ansari 2016-05-26 10:13:16 UTC
Created attachment 1161857 [details]
screenshot

Description of problem:


Version-Release number of selected component (if applicable):
Version 5.6.0.8-rc1.20160524155303_f2a5a50


How reproducible:
100%

Steps to Reproduce:
1.Navigate to Automate->customization->import/export
2.Choose file for import and click on upload button
3.Click on commit button(Don't check on check box)

Actual results:
After clicking on commit button flash message displayed "service dialogs imported successfully" but actual it doesn't imported.    

Expected results:
Dialog import should be successful.

Additional info:

Comment 2 Harpreet Kataria 2016-05-26 14:54:18 UTC
Zita,

When user selects a file to import and presses Upload button, flash message is misleading.
Can you fix flash message here https://github.com/ManageIQ/manageiq/blob/master/app/controllers/miq_ae_customization_controller.rb#L55 to something like

add_flash(_("Select Dialogs to import"), :info) 

Thanks,
~Harpreet

Comment 4 Zita Nemeckova 2016-07-19 06:39:03 UTC
https://github.com/ManageIQ/manageiq/pull/9452

Comment 5 Shveta 2016-09-21 05:14:52 UTC
Fixed.
Verified in 5.7.0.0.20160906172503_12f65cb


Note You need to log in before you can comment on or make changes to this bug.