Bug 134025 - Inefficient and possibly unsafe closing of file descriptors
Summary: Inefficient and possibly unsafe closing of file descriptors
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: nfs-utils (Show other bugs)
(Show other bugs)
Version: 3
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Steve Dickson
QA Contact: Ben Levenson
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-09-29 01:23 UTC by Ulrich Drepper
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version: 1.0.6-37
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-10-15 02:32:26 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Replace brute force close loop (5.22 KB, patch)
2004-09-29 01:25 UTC, Ulrich Drepper
no flags Details | Diff
Updated patch (5.88 KB, patch)
2004-09-29 08:24 UTC, Ulrich Drepper
no flags Details | Diff
One more addition (6.11 KB, patch)
2004-09-29 08:38 UTC, Ulrich Drepper
no flags Details | Diff
One more addition to the patch (7.27 KB, patch)
2004-09-29 08:54 UTC, Ulrich Drepper
no flags Details | Diff

Description Ulrich Drepper 2004-09-29 01:23:17 UTC
Description of problem:
Various daemons in nfs-utils close all file descriptors before
starting work.  This happens in a very inefficient way.  All iterate
over all possible descriptor values and make a close(2) call.  Image
what happens if the file descriptor limit is high?

There is no reason for this, programs can learn exactly which
descriptors are used from the /proc/self/fd directory.

Version-Release number of selected component (if applicable):
nfs-utils-1.0.6-34

How reproducible:
always

Steps to Reproduce:
1. strace /usr/sbin/rpc.mountd
2.
3.
  
Actual results:
tons of failing close syscalls

Expected results:
no failing syscall

Additional info:
I'll attach a patch.

Comment 1 Ulrich Drepper 2004-09-29 01:25:46 UTC
Created attachment 104479 [details]
Replace brute force close loop

Comment 2 Ulrich Drepper 2004-09-29 08:24:12 UTC
Created attachment 104492 [details]
Updated patch

Updated patch fixing the problem of closing the pipe.

Also replace signal(3) calls with sigaction calls.  This is more portable and
the blocking mask includes all three signals for which the signal handler is
registered.  Otherwise it could be possible to get a SIGINT, SIGTERM, and
SIGHUP signal all in a row, one handler interrupting the other.  If the handler
one day does what it is supposed to do according to the context this might be
fatal.

Comment 3 Ulrich Drepper 2004-09-29 08:38:56 UTC
Created attachment 104493 [details]
One more addition

One additional change.	Three programs contain code like this

  close(N); dup2(fd, N);

where N is the same in both function calls.  This is completely unnecessary
since dup2() implicitly closes the descriptor for its second parameter.  The
close() calls can be removed.

Comment 4 Ulrich Drepper 2004-09-29 08:54:28 UTC
Created attachment 104497 [details]
One more addition to the patch

Yet more signal -> sigaction transformations.  Again, all signals must be
blocked since otherwise they could interrupt each other.

Comment 5 Steve Dickson 2004-10-01 11:02:09 UTC
fixed in nfs-utils-1.0.6-37

Comment 6 Ulrich Drepper 2004-10-15 02:32:26 UTC
Verified.


Note You need to log in before you can comment on or make changes to this bug.