Bug 1340417 - Review Request: perl-RDF-TriN3 - Notation 3 extensions for RDF::Trine
Summary: Review Request: perl-RDF-TriN3 - Notation 3 extensions for RDF::Trine
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1325351
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-27 11:05 UTC by Petr Pisar
Modified: 2016-06-10 14:16 UTC (History)
2 users (show)

Fixed In Version: perl-RDF-TriN3-0.206-1.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-10 14:16:16 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-05-27 11:05:53 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-RDF-TriN3/perl-RDF-TriN3.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-RDF-TriN3/perl-RDF-TriN3-0.206-1.fc25.src.rpm
Description:
This Perl module extends RDF::Trine. It adds Notation 3 parser, serializer and
it provides subclass for representing Notation 3 formulae literals.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-10 09:15:12 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-RDF-TriN3-0.206-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(Data::UUID)
      1 perl(Encode)
      1 perl(Log::Log4perl)
      1 perl(Module::Runtime)
      1 perl(RDF::NS::Trine)
      1 perl(RDF::Trine) >= 0.135
      1 perl(RDF::Trine::Error)
      1 perl(RDF::Trine::Namespace)
      1 perl(RDF::Trine::Node)
      1 perl(RDF::Trine::Node::Formula)
      1 perl(RDF::Trine::Node::Literal)
      1 perl(RDF::Trine::Parser)
      1 perl(RDF::Trine::Parser::Notation3)
      1 perl(RDF::Trine::Parser::ShorthandRDF)
      1 perl(RDF::Trine::Pattern)
      1 perl(RDF::Trine::Serializer::NTriples)
      1 perl(RDF::Trine::Serializer::Notation3)
      1 perl(RDF::Trine::Statement)
      1 perl(Scalar::Util)
      1 perl(URI)
      1 perl(URI::Escape)
      1 perl(base)
      1 perl(namespace::clean)
      1 perl(parent)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-RDF-TriN3-0.206-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(RDF::TriN3) = 0.206
      1 perl(RDF::Trine::Node::Formula) = 0.206
      1 perl(RDF::Trine::Parser::Notation3) = 0.206
      1 perl(RDF::Trine::Parser::ShorthandRDF) = 0.206
      1 perl(RDF::Trine::Serializer::Notation3) = 0.206
      1 perl(RDF::TrineX::Parser::Pretdsl) = 0.206
      1 perl-RDF-TriN3 = 0.206-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-RDF-TriN3*
perl-RDF-TriN3.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
perl-RDF-TriN3.noarch: W: spelling-error %description -l en_US formulae -> formula, formulate, formulas
perl-RDF-TriN3.src: W: spelling-error Summary(en_US) Trine -> Trina, Taine, Urine
perl-RDF-TriN3.src: W: spelling-error %description -l en_US Trine -> Trina, Taine, Urine
perl-RDF-TriN3.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
perl-RDF-TriN3.src: W: spelling-error %description -l en_US formulae -> formula, formulate, formulas
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

Rpmlint is ok

TODO: There is typo in description "formulae"

Otherwise package is good
Approved
$ rpm -qp --provides perl-RDF-TriN3-0.206-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(RDF::TriN3) = 0.206
      1 perl(RDF::Trine::Node::Formula) = 0.206
      1 perl(RDF::Trine::Parser::Notation3) = 0.206
      1 perl(RDF::Trine::Parser::ShorthandRDF) = 0.206
      1 perl(RDF::Trine::Serializer::Notation3) = 0.206
      1 perl(RDF::TrineX::Parser::Pretdsl) = 0.206
      1 perl-RDF-TriN3 = 0.206-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-RDF-TriN3*
perl-RDF-TriN3.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
perl-RDF-TriN3.noarch: W: spelling-error %description -l en_US formulae -> formula, formulate, formulas
perl-RDF-TriN3.src: W: spelling-error Summary(en_US) Trine -> Trina, Taine, Urine
perl-RDF-TriN3.src: W: spelling-error %description -l en_US Trine -> Trina, Taine, Urine
perl-RDF-TriN3.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
perl-RDF-TriN3.src: W: spelling-error %description -l en_US formulae -> formula, formulate, formulas
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

Rpmlint is ok

TODO: There is typo in description "formulae"

Otherwise package is good
Approved

Comment 2 Petr Pisar 2016-06-10 10:20:29 UTC
That's not a typo. Both formulae and formulas are correct plural forms.

Comment 3 Gwyn Ciesla 2016-06-10 13:44:42 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-RDF-TriN3

Comment 4 Petr Pisar 2016-06-10 14:16:16 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.