Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1340464 - [RFE] Suggestion give user a reminder for "Cancel conversion" button
[RFE] Suggestion give user a reminder for "Cancel conversion" button
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libguestfs (Show other bugs)
7.3
x86_64 Unspecified
low Severity low
: rc
: ---
Assigned To: Richard W.M. Jones
Virtualization Bugs
P2V
: FutureFeature
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-27 09:16 EDT by keanli
Modified: 2016-11-03 14:00 EDT (History)
7 users (show)

See Also:
Fixed In Version: libguestfs-1.32.5-5.el7
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-11-03 14:00:24 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2576 normal SHIPPED_LIVE Moderate: libguestfs and virt-p2v security, bug fix, and enhancement update 2016-11-03 08:06:51 EDT

  None (edit)
Description keanli 2016-05-27 09:16:38 EDT
Description of problem:
Suggestion give user a reminder for "Cancel conversion" button on p2v client  

Version-Release number of selected component (if applicable):
virt-p2v-1.32.4-1.el7.iso

How reproducible:
100%

Steps to Reproduce:
1.Boot the source machine into p2v client via iso
2.Input the correct ip and password of conversion server
3.Finish all convert value then click "Start conversion" 
4.When the conversion is starting, click the "Cancel conversion "
5.This action will terminal conversation immediately,there is no any reminder give user for confirm this action  

Actual results:
As above step 5

Expected results:
1.Since this operation will cause the convert terminal immediately,and for many physics host disk is very large.it's better give user a chance for return to convert 

2.Suggestion: After click "cancel conversation", give user a reminder just like "Are you sure cancel this conversion, this operation will cause terminal convert" make user is very clear for this operation  

Additional info:
N/A
Comment 2 Richard W.M. Jones 2016-06-18 04:21:35 EDT
Fixed in upstream commit 4f4f0f1fe98dbc82227c3a393d76498b6624a400.
Comment 3 mxie@redhat.com 2016-06-22 23:54:03 EDT
I can reproduce the bug on build
virt-p2v-1.32.4-1.el7

Try to verify the bug with build
virt-p2v-1.32.5-5.el7

Steps:
1.Boot the source machine into p2v client via iso
2.Input conversion server info and click 'next'
3.Input conversion info and then click 'start conversion'
4.When the conversion is starting, click the "Cancel conversion ",then the dialog will prompt 'Really cancel the conversion? To convert this machine you will need to re-run the conversion from the beginning'
5.If click 'No' option, the conversion could be continued
6.If click 'Yes' option, the conversion will be failed with error 'cancelled by user' after waiting for few mins


Result now
Has added a reminder for "Cancel conversion" button and the reminder dialog works well
Comment 8 mxie@redhat.com 2016-07-07 05:49:36 EDT
Verify the bug with virt-p2v-1.32.5-10.el7 as comment3 steps, the reminder for "Cancel conversion"  dialog works well, the bug has been fixed.

So move the bug from ON_QA to VERIFIED
Comment 10 errata-xmlrpc 2016-11-03 14:00:24 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2576.html

Note You need to log in before you can comment on or make changes to this bug.