Bug 1340619 - Review Request: python-imagesize - Python module for analyzing image file headers and returning image sizes
Summary: Review Request: python-imagesize - Python module for analyzing image file hea...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 24
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: William Moreno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1323202
TreeView+ depends on / blocked
 
Reported: 2016-05-29 03:23 UTC by Avram Lubkin
Modified: 2016-06-27 18:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-27 18:27:51 UTC
Type: ---
Embargoed:
williamjmorenor: fedora-review+


Attachments (Terms of Use)

Description Avram Lubkin 2016-05-29 03:23:31 UTC
Spec URL: https://aviso.fedorapeople.org/python-imagesize.spec
SRPM URL: https://aviso.fedorapeople.org/python-imagesize-0.7.1-1.fc23.src.rpm
Description: The imagesize package parses image file headers and returns the image sizes.

* PNG
* JPEG
* JPEG2000
* GIF

This is a pure Python library.
Fedora Account System Username: aviso

Comment 1 Avram Lubkin 2016-05-29 03:25:58 UTC
This package is a new dependency for python-sphinx

Comment 2 William Moreno 2016-06-16 03:49:34 UTC
Package Review
==============

Issues:
=======
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /home/fedora/1340619
  -python-imagesize/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL

- RPMLint is a easy fix:
python-imagesize.src:12: W: macro-in-comment %{pypi_name}
python-imagesize.src:12: W: macro-in-comment %{pypi_name}
python-imagesize.src:12: W: macro-in-comment %{version}

Just use doble %% in the comment.

Please fix the upstream diff issue and I will aprove this package.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====
Generic:
[x]: %check is present and all tests pass.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: python2-imagesize-0.7.1-1.fc23.noarch.rpm
          python3-imagesize-0.7.1-1.fc23.noarch.rpm
          python-imagesize-0.7.1-1.fc23.src.rpm
python-imagesize.src:12: W: macro-in-comment %{pypi_name}
python-imagesize.src:12: W: macro-in-comment %{pypi_name}
python-imagesize.src:12: W: macro-in-comment %{version}
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Rpmlint (installed packages)
----------------------------
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


Requires
--------
python3-imagesize (rpmlib, GLIBC filtered):
    python(abi)

python2-imagesize (rpmlib, GLIBC filtered):
    python(abi)

Provides
--------
python3-imagesize:
    python3-imagesize

python2-imagesize:
    python-imagesize
    python2-imagesize

Source checksums
----------------
https://github.com/shibukawa/imagesize_py/archive/0.7.1.tar.gz#/imagesize-0.7.1.tar.gz :
  CHECKSUM(SHA256) this package     : 781367e05a2aba5b66c76e46394cf627bfdd85dba94e066c49df7d57897c67c3
  CHECKSUM(SHA256) upstream package : 653b2440444912cc8f34aa0d488499d78ffc5a01827ac069946335eabe66e603
diff -r also reports differences

Comment 3 Avram Lubkin 2016-06-16 12:07:51 UTC
Thanks for the review. I'm not sure why there was a source difference, but it's fixed now.

Comment 4 William Moreno 2016-06-17 14:45:59 UTC
Thanks, I am aproving this package.

Comment 5 Gwyn Ciesla 2016-06-17 19:36:10 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-imagesize

Comment 6 Fedora Update System 2016-06-18 14:32:05 UTC
python-imagesize-0.7.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-46ec504ee9

Comment 7 Fedora Update System 2016-06-19 09:28:43 UTC
python-imagesize-0.7.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-46ec504ee9

Comment 8 Fedora Update System 2016-06-27 18:27:49 UTC
python-imagesize-0.7.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.