Created attachment 1162681 [details] log_jp Description of problem: Need to translate the title and tool-tips on Control -> Log page. Version-Release number of selected component (if applicable): 5.6.0.7-beta2.6 How reproducible: always Steps to Reproduce: 1. login with ja_JP or zh_CN locale 2. go to control->log page 3. check the title 4. check the tool-tips for reload and download buttons. Actual results: The page title and the tool-tips are not translated. Expected results: All the titles and tool-tips should be translated. Additional info:
Created attachment 1162682 [details] log_zh_CN
https://github.com/ManageIQ/manageiq/pull/9501 https://github.com/ManageIQ/manageiq/pull/9508 https://github.com/ManageIQ/manageiq/pull/9510 https://github.com/ManageIQ/manageiq/pull/9512 https://github.com/ManageIQ/manageiq/pull/9572
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0ca6339462c988f931c63aa3fb115a1c50f437e4 commit 0ca6339462c988f931c63aa3fb115a1c50f437e4 Author: Milan Zazrivec <mzazrivec> AuthorDate: Fri Jul 1 14:39:33 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Fri Jul 1 16:23:10 2016 +0200 Toolbars: remove string interpolations with ui_lookup This is to make sure the translations for toolbars works correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1352007 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 https://bugzilla.redhat.com/show_bug.cgi?id=1340139 https://bugzilla.redhat.com/show_bug.cgi?id=1340708 https://bugzilla.redhat.com/show_bug.cgi?id=1340870 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 app/helpers/application_helper/toolbar/condition_center.rb | 6 ++++-- app/helpers/application_helper/toolbar/conditions_center.rb | 8 +++++++- .../application_helper/toolbar/miq_alert_profiles_center.rb | 4 +++- app/helpers/application_helper/toolbar/miq_policy_center.rb | 10 +++++++--- 4 files changed, 21 insertions(+), 7 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/ba1e67271df72008424fa34200efe8e22f32750f commit ba1e67271df72008424fa34200efe8e22f32750f Author: Milan Zazrivec <mzazrivec> AuthorDate: Fri Jul 1 16:11:24 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Fri Jul 1 17:34:39 2016 +0200 Toolbars: remove string interpolations with instance variables This is to make sure the translations for toolbars works correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1352007 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 https://bugzilla.redhat.com/show_bug.cgi?id=1340139 https://bugzilla.redhat.com/show_bug.cgi?id=1340708 https://bugzilla.redhat.com/show_bug.cgi?id=1340870 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 app/helpers/application_helper.rb | 2 + .../application_helper/toolbar/condition_center.rb | 13 +++-- .../toolbar/custom_button_set_center.rb | 8 ++- .../toolbar/diagnostics_region_center.rb | 53 +++++++++++++++--- .../toolbar/diagnostics_server_center.rb | 8 ++- .../toolbar/diagnostics_zone_center.rb | 62 +++++++++++++++++++--- .../application_helper/toolbar/dialog_center.rb | 8 ++- .../application_helper/toolbar/logs_center.rb | 8 ++- .../application_helper/toolbar/miq_group_center.rb | 4 +- .../toolbar/miq_groups_center.rb | 4 +- .../toolbar/miq_policy_center.rb | 12 ++++- .../application_helper/toolbar/summary_center.rb | 5 +- .../toolbar/summary_center_restful.rb | 5 +- .../application_helper/toolbar/tenant_center.rb | 4 +- .../application_helper/toolbar/tenants_center.rb | 4 +- .../application_helper/toolbar/user_center.rb | 4 +- .../application_helper/toolbar/users_center.rb | 4 +- 17 files changed, 171 insertions(+), 37 deletions(-)
New commit detected on ManageIQ/manageiq/darga: https://github.com/ManageIQ/manageiq/commit/0935e92962f2e8c9796f0248d71281dd796b7a9d commit 0935e92962f2e8c9796f0248d71281dd796b7a9d Author: Milan Zazrivec <mzazrivec> AuthorDate: Fri Jul 1 16:11:24 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Tue Jul 12 13:51:17 2016 +0200 Toolbars: remove string interpolations with instance variables This is to make sure the translations for toolbars works correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1352007 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 https://bugzilla.redhat.com/show_bug.cgi?id=1340139 https://bugzilla.redhat.com/show_bug.cgi?id=1340708 https://bugzilla.redhat.com/show_bug.cgi?id=1340870 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 (cherry picked from commit ba1e67271df72008424fa34200efe8e22f32750f) app/helpers/application_helper.rb | 2 + .../application_helper/toolbar/condition_center.rb | 13 +++-- .../toolbar/custom_button_set_center.rb | 8 ++- .../toolbar/diagnostics_region_center.rb | 53 +++++++++++++++--- .../toolbar/diagnostics_server_center.rb | 8 ++- .../toolbar/diagnostics_zone_center.rb | 62 +++++++++++++++++++--- .../application_helper/toolbar/dialog_center.rb | 8 ++- .../application_helper/toolbar/logs_center.rb | 8 ++- .../application_helper/toolbar/miq_group_center.rb | 4 +- .../toolbar/miq_groups_center.rb | 4 +- .../toolbar/miq_policy_center.rb | 12 ++++- .../application_helper/toolbar/summary_center.rb | 5 +- .../toolbar/summary_center_restful.rb | 5 +- .../application_helper/toolbar/tenant_center.rb | 4 +- .../application_helper/toolbar/tenants_center.rb | 4 +- .../application_helper/toolbar/user_center.rb | 4 +- .../application_helper/toolbar/users_center.rb | 4 +- 17 files changed, 171 insertions(+), 37 deletions(-)
New commit detected on ManageIQ/manageiq/darga: https://github.com/ManageIQ/manageiq/commit/7d5af5d26e0ec90be2749c4033d35b733b651ebb commit 7d5af5d26e0ec90be2749c4033d35b733b651ebb Author: Milan Zazrivec <mzazrivec> AuthorDate: Fri Jul 1 14:39:33 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Tue Jul 12 13:50:20 2016 +0200 Toolbars: remove string interpolations with ui_lookup This is to make sure the translations for toolbars works correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1352007 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1348649 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 https://bugzilla.redhat.com/show_bug.cgi?id=1340139 https://bugzilla.redhat.com/show_bug.cgi?id=1340708 https://bugzilla.redhat.com/show_bug.cgi?id=1340870 https://bugzilla.redhat.com/show_bug.cgi?id=1288413 (cherry picked from commit 0ca6339462c988f931c63aa3fb115a1c50f437e4) app/helpers/application_helper/toolbar/condition_center.rb | 6 ++++-- app/helpers/application_helper/toolbar/conditions_center.rb | 8 +++++++- .../application_helper/toolbar/miq_alert_profiles_center.rb | 4 +++- app/helpers/application_helper/toolbar/miq_policy_center.rb | 10 +++++++--- 4 files changed, 21 insertions(+), 7 deletions(-)
Tested with 5.7.0.3.20160927165516_075d0f3 Now, although the page title is localized, the tool-tips for the download and reload buttons at the top are still unlocalized for both of the locales. Please refer attached screenshot. Changing the state back to assigned.
Created attachment 1205933 [details] logs_tool-tips_unlocalized_29/09
This is simply a matter of missing translations.
Moving to POST, since latest translations have been merged.
Tested with 5.7.0.7-beta1.20161025153249_9376fbd looks fine now. Will move it to verified once the bug is ON_QA.
Verified on 5.8.0.0.20170201144150_848e68b Translations are available!