REVIEW: http://review.gluster.org/14558 (geo-rep: update peers section in gsyncd conf) posted (#1) for review on master by Saravanakumar Arumugam (sarumuga)
REVIEW: http://review.gluster.org/14558 (geo-rep: update peers section in gsyncd conf) posted (#2) for review on master by Saravanakumar Arumugam (sarumuga)
Description of problem: ======================= With the recent changes, we support to rename the existing geo-rep session from one slave host to another slave host. Expected is to rename only the session and retain all the configuration/status as of the previous session. But the older configurations are not retained which passively breaks the geo-rep functionality for this use case. Existing session between: baloo 10.70.37.88::bagheera [root@dhcp37-162 ~]# gluster volume geo-replication baloo 10.70.37.88::bagheera config change_detector xsync [root@dhcp37-162 ~]# gluster volume geo-replication baloo 10.70.37.88::bagheera config ignore_deletes true [root@dhcp37-162 ~]# gluster volume geo-replication baloo 10.70.37.88::bagheera config use_meta_volume true [root@dhcp37-162 ~]# New Session between: baloo 10.70.37.43::bagheera [root@dhcp37-162 ~]# gluster volume geo-replication baloo 10.70.37.43::bagheera config use_meta_volume [root@dhcp37-162 ~]# gluster volume geo-replication baloo 10.70.37.43::bagheera config ignore_deletes false [root@dhcp37-162 ~]# gluster volume geo-replication baloo 10.70.37.43::bagheera config change_detector changelog [root@dhcp37-162 ~]# Version-Release number of selected component (if applicable): ============================================================= How reproducible: ================= Always Steps to Reproduce: =================== 1. Create georep session between master, slavehost1 and slave 2. Update configs for this session 3. Stop existing session 4. Recreate session between master, slavehost2 and slave 5. Start the session 6. Verify for the configs setup at step 2 Actual results: =============== Config options are reset Expected results: ================= Since it is a rename of a session and not the new session, all config options should be retained
REVIEW: http://review.gluster.org/14565 (geo-rep: update peers section in gsyncd conf) posted (#1) for review on release-3.8 by Saravanakumar Arumugam (sarumuga)
COMMIT: http://review.gluster.org/14558 committed in master by Aravinda VK (avishwan) ------ commit d6442d8f4ac6d892cf5adc55ea5c34dcb01e1f26 Author: Saravanakumar Arumugam <sarumuga> Date: Mon May 30 17:34:24 2016 +0530 geo-rep: update peers section in gsyncd conf Problem: Once Slave volume uuid is involved as part of a geo-rep session, it is possible to create the same geo-rep session with different (slave)host. But, it reflects default values for geo-rep configuration values originally configured for old geo-rep session. Reason is, slave host is used while saving config options in gsyncd.conf. With new slave host, it is not possible to retrieve those config values. Solution: Remove slave host related information from gsyncd.conf and have only master volume and slave volume as part of peers section. Also, during upgrade from old geo-rep session, update peers section to reflect only master volume and slave volume. Change-Id: I7debf35a09a28d030b706b0c3e5d82c9b0467d0e BUG: 1340853 Signed-off-by: Saravanakumar Arumugam <sarumuga> Reviewed-on: http://review.gluster.org/14558 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Kotresh HR <khiremat> Reviewed-by: Aravinda VK <avishwan>