Bug 1341099 - Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
Summary: Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jiri Kulda
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-31 09:25 UTC by Martin Krizek
Modified: 2017-02-07 00:22 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 21:50:23 UTC
Type: Bug
Embargoed:
jkulda: fedora-review+


Attachments (Terms of Use)

Description Martin Krizek 2016-05-31 09:25:05 UTC
Spec URL: https://mkrizek.fedorapeople.org/specs/taskotron-trigger.spec
SRPM URL: https://mkrizek.fedorapeople.org/srpms/taskotron-trigger-0.3.16-2.fc23.src.rpm
Description: Triggering Taskotron jobs on fedmsgs
FAS: mkrizek

Comment 2 Jiri Kulda 2016-07-19 14:00:26 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated". 20 files have
     unknown license. 
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/logrotate.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines. 
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces. 
     Note: There are rpmlint messages (see attachment). 
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[!]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: taskotron-trigger-0.3.16-3.fc22.noarch.rpm
          taskotron-trigger-0.3.16-3.fc22.src.rpm
taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: E: script-without-shebang /etc/fedmsg.d/taskotron-trigger.py
taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyc
taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyo
taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner
2 packages and 0 specfiles checked; 1 errors, 7 warnings.




Rpmlint (installed packages)
----------------------------
taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: E: script-without-shebang /etc/fedmsg.d/taskotron-trigger.py
taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyc
taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyo
taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner
1 packages and 0 specfiles checked; 1 errors, 7 warnings.



Requires
--------
taskotron-trigger (rpmlib, GLIBC filtered):
    /usr/bin/python
    PyYAML
    config(taskotron-trigger)
    fedmsg
    fedmsg-hub
    git
    koji
    python(abi)
    python-requests
    python-twisted



Provides
--------
taskotron-trigger:
    config(taskotron-trigger)
    taskotron-trigger



Source checksums
----------------
https://qadevel.cloud.fedoraproject.org/releases/taskotron-trigger/taskotron-trigger-0.3.16.tar.gz :
  CHECKSUM(SHA256) this package     : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
  CHECKSUM(SHA256) upstream package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review --rpm-spec -n Downloads/taskotron-trigger-0.3.16-3.fc23.src.rpm
Buildroot used: fedora-22-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


Comments 
--------
- rm -rf %{buildroot} in the beginning of %install section should be removed.

- I think python will download extra dependencies listed in setup.py:
	moksha.hub - probably
        fedmsg     - probably not because it is in Requires
        requests   - Same case as fedmsg
  If not they need to be added into requires...


- In readme should be "In /etc/fedmsg.d/logging.py, add the following handler::" instead of "In /etc/fedmsg.d/logging, add the following handler::" but it's minority.

- In installing there should be added options for preserving timestamp

Comment 3 Jaroslav Škarvada 2016-07-19 14:04:52 UTC
(In reply to Jiri Kulda from comment #2)
> - I think python will download extra dependencies listed in setup.py:
> 	moksha.hub - probably
>         fedmsg     - probably not because it is in Requires
>         requests   - Same case as fedmsg
>   If not they need to be added into requires...

I think these are runtime deps, IMHO they should be added to the requires.

Comment 4 Martin Krizek 2016-07-25 10:04:31 UTC
(In reply to Jiri Kulda from comment #2)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> 
> ===== MUST items =====
> 
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.
> [x]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "GPL (v2 or later)", "Unknown or generated". 20 files have
>      unknown license. 
> [x]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/logrotate.d
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
>      Note: rm -rf %{buildroot} present but not required
> [x]: Sources contain only permissible code or content.
> [x]: Package contains desktop file if it is a GUI application.
> [x]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
>      names).
> [x]: Package is named according to the Package Naming Guidelines. 
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [x]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [x]: Package contains systemd file(s) if in need.
> [x]: Package is not known to require an ExcludeArch tag.
> [x]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 10240 bytes in 1 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
>      one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces. 
>      Note: There are rpmlint messages (see attachment). 
> [x]: If (and only if) the source package includes the text of the
>      license(s) in its own file, then that file, containing the text of the
>      license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package does not own files or directories owned by other packages.
> [x]: All build dependencies are listed in BuildRequires, except for any
>      that are listed in the exceptions section of Packaging Guidelines.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: %config files are marked noreplace or the reason is justified.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>      work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: No %config files under /usr.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> Python:
> [!]: Python eggs must not download any dependencies during the build
>      process.
> [x]: A package which is used by another package via an egg interface should
>      provide egg info.
> [!]: Package meets the Packaging Guidelines::Python
> [x]: Package contains BR: python2-devel or python3-devel
> [x]: Binary eggs must be removed in %prep
> 
> ===== SHOULD items =====
> 
> Generic:
> [x]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.
> [x]: Final provides and requires are sane (see attachments).
> [x]: Package functions as described.
> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [?]: Description and summary sections in the package spec file contains
>      translations for supported Non-English languages, if available.
> [x]: Package should compile and build into binary rpms on all supported
>      architectures.
> [x]: %check is present and all tests pass.
> [!]: Packages should try to preserve timestamps of original installed
>      files.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
> [x]: Reviewer should test that the package builds in mock.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: SourceX is a working URL.
> [x]: Spec use %global instead of %define unless justified.
> 
> ===== EXTRA items =====
> 
> Generic:
> [x]: Rpmlint is run on all installed packages.
>      Note: There are rpmlint messages (see attachment).
> 
> 
> Rpmlint
> -------
> Checking: taskotron-trigger-0.3.16-3.fc22.noarch.rpm
>           taskotron-trigger-0.3.16-3.fc22.src.rpm
> taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: E: script-without-shebang
> /etc/fedmsg.d/taskotron-trigger.py
> taskotron-trigger.noarch: W: non-conffile-in-etc
> /etc/fedmsg.d/taskotron-trigger.pyc
> taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: W: non-conffile-in-etc
> /etc/fedmsg.d/taskotron-trigger.pyo
> taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner
> 2 packages and 0 specfiles checked; 1 errors, 7 warnings.
> 
> 
> 
> 
> Rpmlint (installed packages)
> ----------------------------
> taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: E: script-without-shebang
> /etc/fedmsg.d/taskotron-trigger.py
> taskotron-trigger.noarch: W: non-conffile-in-etc
> /etc/fedmsg.d/taskotron-trigger.pyc
> taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger
> fedmsg
> taskotron-trigger.noarch: W: non-conffile-in-etc
> /etc/fedmsg.d/taskotron-trigger.pyo
> taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner
> 1 packages and 0 specfiles checked; 1 errors, 7 warnings.
> 
> 
> 
> Requires
> --------
> taskotron-trigger (rpmlib, GLIBC filtered):
>     /usr/bin/python
>     PyYAML
>     config(taskotron-trigger)
>     fedmsg
>     fedmsg-hub
>     git
>     koji
>     python(abi)
>     python-requests
>     python-twisted
> 
> 
> 
> Provides
> --------
> taskotron-trigger:
>     config(taskotron-trigger)
>     taskotron-trigger
> 
> 
> 
> Source checksums
> ----------------
> https://qadevel.cloud.fedoraproject.org/releases/taskotron-trigger/taskotron-
> trigger-0.3.16.tar.gz :
>   CHECKSUM(SHA256) this package     :
> daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
>   CHECKSUM(SHA256) upstream package :
> daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
> 
> 
> Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
> Command line :/usr/bin/fedora-review --rpm-spec -n
> Downloads/taskotron-trigger-0.3.16-3.fc23.src.rpm
> Buildroot used: fedora-22-x86_64
> Active plugins: Python, Generic, Shell-api
> Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell,
> R, PHP, Ruby
> Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
> 
> 
> Comments 
> --------
> - rm -rf %{buildroot} in the beginning of %install section should be removed.
> 
> - I think python will download extra dependencies listed in setup.py:
> 	moksha.hub - probably
>         fedmsg     - probably not because it is in Requires
>         requests   - Same case as fedmsg
>   If not they need to be added into requires...
> 
I will remove moksha.hub from setup.py upstream since it's dep of fedmsg.

> 
> - In readme should be "In /etc/fedmsg.d/logging.py, add the following
> handler::" instead of "In /etc/fedmsg.d/logging, add the following
> handler::" but it's minority.
> 

Good catch, will fix that upstream.

> - In installing there should be added options for preserving timestamp

Thanks for the review!

Updated version:
Spec URL: https://mkrizek.fedorapeople.org/specs/taskotron-trigger.spec
SRPM URL: https://mkrizek.fedorapeople.org/srpms/taskotron-trigger-0.3.16-4.fc23.src.rpm

Comment 5 Jiri Kulda 2016-08-23 11:16:19 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/logrotate.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: taskotron-trigger-0.3.16-4.fc22.noarch.rpm
          taskotron-trigger-0.3.16-4.fc22.src.rpm
taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.py
taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner
2 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.py
taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg
taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner
1 packages and 0 specfiles checked; 0 errors, 6 warnings.



Requires
--------
taskotron-trigger (rpmlib, GLIBC filtered):
    /usr/bin/python
    PyYAML
    config(taskotron-trigger)
    fedmsg
    fedmsg-hub
    git
    koji
    python(abi)
    python-moksha-hub
    python-requests
    python-twisted



Provides
--------
taskotron-trigger:
    config(taskotron-trigger)
    taskotron-trigger



Source checksums
----------------
https://qadevel.cloud.fedoraproject.org/releases/taskotron-trigger/taskotron-trigger-0.3.16.tar.gz :
  CHECKSUM(SHA256) this package     : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
  CHECKSUM(SHA256) upstream package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c


Comments
--------
- Packages should try to preserve timestamps:
	install should have -p option to preserve timestamps

If preserving timestamps are not review blockers then It's ok with me.

Comment 6 Gwyn Ciesla 2016-09-13 12:17:59 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/taskotron-trigger

Comment 7 Fedora Update System 2016-10-13 03:52:22 UTC
taskotron-trigger-0.4.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-74b0f2a36a

Comment 8 Fedora Update System 2016-10-13 04:52:51 UTC
taskotron-trigger-0.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6bd8252b0a

Comment 9 Fedora Update System 2016-10-13 05:53:43 UTC
taskotron-trigger-0.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-47efa5e800

Comment 10 Fedora Update System 2016-10-14 21:20:57 UTC
taskotron-trigger-0.4.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8cc8f5a18a

Comment 11 Fedora Update System 2016-10-14 21:22:51 UTC
taskotron-trigger-0.4.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5727de3374

Comment 12 Fedora Update System 2016-10-14 21:53:32 UTC
taskotron-trigger-0.4.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-222f28e6b3

Comment 13 Fedora Update System 2016-10-31 21:31:27 UTC
taskotron-trigger-0.4.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9394b72a1

Comment 14 Fedora Update System 2016-10-31 21:31:38 UTC
taskotron-trigger-0.4.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9c6f20ddf8

Comment 15 Fedora Update System 2016-10-31 21:31:44 UTC
taskotron-trigger-0.4.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cb1f7e0ff9

Comment 16 Fedora Update System 2016-11-06 01:51:21 UTC
taskotron-trigger-0.4.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9394b72a1

Comment 17 Fedora Update System 2016-11-06 01:53:01 UTC
taskotron-trigger-0.4.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9c6f20ddf8

Comment 18 Fedora Update System 2016-11-07 02:22:39 UTC
taskotron-trigger-0.4.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cb1f7e0ff9

Comment 19 Fedora Update System 2017-01-16 18:48:02 UTC
taskotron-trigger-0.4.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3eab8acf22

Comment 20 Fedora Update System 2017-01-16 18:48:13 UTC
taskotron-trigger-0.4.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b175c3dd22

Comment 21 Fedora Update System 2017-01-17 21:50:12 UTC
taskotron-trigger-0.4.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3eab8acf22

Comment 22 Fedora Update System 2017-01-17 21:50:24 UTC
taskotron-trigger-0.4.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b175c3dd22

Comment 23 Fedora Update System 2017-01-23 14:51:58 UTC
taskotron-trigger-0.4.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ad5ad7c3e

Comment 24 Fedora Update System 2017-01-23 14:54:01 UTC
taskotron-trigger-0.4.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e11280f62f

Comment 25 Fedora Update System 2017-01-25 01:21:51 UTC
taskotron-trigger-0.4.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e11280f62f

Comment 26 Fedora Update System 2017-01-28 19:18:25 UTC
taskotron-trigger-0.4.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ad5ad7c3e

Comment 27 Fedora Update System 2017-02-01 21:50:23 UTC
taskotron-trigger-0.4.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 28 Fedora Update System 2017-02-07 00:22:27 UTC
taskotron-trigger-0.4.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.