Bug 1341304 - [abrt] hplip: hp-scan:663:<module>:NameError: name 'source_option' is not defined
Summary: [abrt] hplip: hp-scan:663:<module>:NameError: name 'source_option' is not def...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: hplip
Version: 24
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zdenek Dohnal
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:33542f7bb124cc915ce9e19c32c...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-31 18:35 UTC by Niki Guldbrand
Modified: 2016-06-24 18:53 UTC (History)
4 users (show)

Fixed In Version: hplip-3.16.5-2.fc24
Clone Of:
Environment:
Last Closed: 2016-06-24 18:53:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (24.26 KB, text/plain)
2016-05-31 18:35 UTC, Niki Guldbrand
no flags Details
File: environ (4.25 KB, text/plain)
2016-05-31 18:35 UTC, Niki Guldbrand
no flags Details
Proposed patch (464 bytes, patch)
2016-06-01 07:14 UTC, Zdenek Dohnal
no flags Details | Diff

Description Niki Guldbrand 2016-05-31 18:35:28 UTC
Version-Release number of selected component:
hplip-3.16.5-1.fc24

Additional info:
reporter:       libreport-2.7.1
cmdline:        /usr/bin/python3 /usr/bin/hp-scan
executable:     /usr/bin/hp-scan
kernel:         4.5.5-300.fc24.x86_64
pkg_fingerprint: 73BD E983 81B4 6521
pkg_vendor:     Fedora Project
reproducible:   Not sure how to reproduce the problem
runlevel:       N 5
type:           Python3
uid:            1000

Truncated backtrace:
#1 <module> in /usr/bin/hp-scan:663

Comment 1 Niki Guldbrand 2016-05-31 18:35:34 UTC
Created attachment 1163345 [details]
File: backtrace

Comment 2 Niki Guldbrand 2016-05-31 18:35:36 UTC
Created attachment 1163346 [details]
File: environ

Comment 3 Zdenek Dohnal 2016-06-01 07:13:12 UTC
Hello Niki,

can you please try this patch? Will it solve your problem?

Comment 4 Zdenek Dohnal 2016-06-01 07:14:06 UTC
Created attachment 1163496 [details]
Proposed patch

Comment 5 Zdenek Dohnal 2016-06-01 08:42:54 UTC
Niki, sorry for misunderstanding on my part, you just need to add new line with command:

sys.exit(1)

after line 660 in your /usr/bin/hp-scan.

Comment 6 Zdenek Dohnal 2016-06-13 07:12:18 UTC
Hello Niki,

any update on this matter?

Comment 7 Niki Guldbrand 2016-06-21 19:42:31 UTC
Hi Zdenek.

I have had a look at the code, and as far as I can see the proposed sys.exit(1) at the end of the except block, starting at line 659, seems to be the correct fix for the code, as line 663 expects the variable 'source_option' to exist, which is defined in the try block starting at line 653.

Comment 8 Fedora Update System 2016-06-22 09:55:27 UTC
hplip-3.16.5-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8aa96ab25a

Comment 9 Fedora Update System 2016-06-22 23:02:50 UTC
hplip-3.16.5-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8aa96ab25a

Comment 10 Fedora Update System 2016-06-24 18:53:15 UTC
hplip-3.16.5-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.