SPEC: http://www.matthias-runge.de/fedora/openstack-neutron-lbaas-ui.spec SRPM: http://www.matthias-runge.de/fedora/openstack-neutron-lbaas-ui-1.0.0-1.fc24.src.rpm
Hi Matthias, Here you have some comments: - About packaging for python3 in fedora. We don't have all dependencies packaged for python3 so we should skip package build for py3. - Is there any meaningful test that we could execute in the %check section? - Macros python2_sitearch, python2_sitelib and __python2 are default ones, you don't need to set them in .spec file. - About requirements: * requirements.txt mentions barbicanclient. should it be included as Requires or it's specific for certain non-default configurations? * requirements.txt include pbr and babel, are they really required on runtime?. - In autosetup, adding "-S git" allows to apply patches in git format which may be convenient if downstream patching is required in future. This requires "BuildRequires: git". - About the enabled files, some other projects are adding the files to /etc/openstack-dashboard/enabled/ in addition to /usr path. Could this cause any issue or conflict if both -ui packages are installed in the same server?, how horizon discover enabled directory?, will it go to /usr/share/openstack-dashboard/openstack_dashboard/local/enabled even if /etc/openstack-dashboard/enabled directory exist? Best regards, Alfredo
- barbicanclient, yes, you're right. In my first grep, I missed that in sources. - tests require openstack-dashboard (and friends) installed; I can't see, what upstream is testing. It's the same for other -ui packages - I'm quite sure, babel is not required at runtime - horizon looks for enabled files in /usr/share/openstack-dashboard/openstack-_dashboard/local/enabled. It doesn't care about /etc/openstack-dashboard/enabled If it really does, I should stand corrected. I believe, I addressed all your comments SPEC: http://www.matthias-runge.de/fedora/openstack-neutron-lbaas-ui-1.0.0-1.fc24.src.rpm SRPM: http://www.matthias-runge.de/fedora/openstack-neutron-lbaas-ui-1.0.0-2.fc24.src.rpm
- About barbicanclient, i guess it must be only Requires, not BuildRequires (at least i could build it without it). - One more comment, this spec is installing the .buildinfo and .doctrees directories in -docs package. Those dirs are temporary dirs used by sphinx and can be deleted after building the docs as in https://github.com/javierpena/openstack-example-spec/blob/master/python-example-library.spec#L106-L107.
Thank you for your comments: I removed barbicanclient from buildrequires and cleaned up build artifacts from doc build. Left: Replace Version/Release with XXX and use %{upstream_version} in %autosetup instead of %{version} That could be safely done during scm import. SPEC: SPEC: http://www.matthias-runge.de/fedora/openstack-neutron-lbaas-ui-1.0.0-1.fc24.src.rpm SRPM: http://www.matthias-runge.de/fedora/openstack-neutron-lbaas-ui-1.0.0-3.fc24.src.rpm
Looks ok to me. Yes, i think we can adapt it for dlrn when importing into rpmfactory. Thanks, Alfredo
Results from fedora-review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 13 files have unknown license. Detailed output of licensecheck in /home/amoralej/1341687-openstack-neutron-lbaas- ui/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 7 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openstack-neutron-lbaas-ui-doc [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openstack-neutron-lbaas-ui-1.0.0-3.fc23.noarch.rpm openstack-neutron-lbaas-ui-doc-1.0.0-3.fc23.noarch.rpm openstack-neutron-lbaas-ui-1.0.0-3.fc23.src.rpm openstack-neutron-lbaas-ui.noarch: W: spurious-executable-perm /usr/share/doc/openstack-neutron-lbaas-ui/doc/source/conf.py openstack-neutron-lbaas-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1480_project_loadbalancersv2_panel.py 640 openstack-neutron-lbaas-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1481_project_ng_loadbalancersv2_panel.py 640 3 packages and 0 specfiles checked; 2 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- openstack-neutron-lbaas-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1480_project_loadbalancersv2_panel.py 640 openstack-neutron-lbaas-ui.noarch: E: non-readable /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1481_project_ng_loadbalancersv2_panel.py 640 openstack-neutron-lbaas-ui.noarch: W: spurious-executable-perm /usr/share/doc/openstack-neutron-lbaas-ui/doc/source/conf.py 2 packages and 0 specfiles checked; 2 errors, 1 warnings. Requires -------- openstack-neutron-lbaas-ui-doc (rpmlib, GLIBC filtered): openstack-neutron-lbaas-ui (rpmlib, GLIBC filtered): openstack-dashboard python(abi) python-barbicanclient python-pbr Provides -------- openstack-neutron-lbaas-ui-doc: openstack-neutron-lbaas-ui-doc openstack-neutron-lbaas-ui: openstack-neutron-lbaas-ui Source checksums ---------------- http://tarballs.openstack.org/neutron-lbaas-dashboard/neutron-lbaas-dashboard-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 8c455c72a8381ad94a7d46d3d4dd331d4ff99dface71e80f4f759503a298e39c CHECKSUM(SHA256) upstream package : 8c455c72a8381ad94a7d46d3d4dd331d4ff99dface71e80f4f759503a298e39c Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1341687 Buildroot used: fedora-23-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package approved.
Built so closing.