Spec URL: https://raw.githubusercontent.com/skrzepto/flask-oidc/rpm-packaging/python-flask_oidc.spec SRPM URL: https://github.com/skrzepto/flask-oidc/raw/rpm-packaging/python-flask_oidc-1.0.1-1.fc23.src.rpm Description: OpenID Connect support for Flask. This library should work with any standards compliant OpenID Connect provider. It has been tested with: Google+ login Ipsilon Fedora Account System Username:skrzepto
postpone reviewing this until i get a successful koji build posted
At last :) Spec URL: https://github.com/skrzepto/flask-oidc/raw/rpm-packaging/python-flask-oidc.spec SRPM URL: https://github.com/skrzepto/flask-oidc/raw/rpm-packaging/python-flask-oidc-1.0.1-1.fc23.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14341953
Package Review =============== Please fix the source url to chech the checksum and aprove the package. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-flask_oidc-1.0.1-1.fc23.noarch.rpm python3-flask_oidc-1.0.1-1.fc23.noarch.rpm python-flask-oidc-1.0.1-1.fc23.src.rpm python3-flask_oidc.noarch: W: no-manual-page-for-binary oidc-register python-flask-oidc.src: W: invalid-url Source0: pypi.io/packages/source/f/flask-oidc/flask-oidc-1.0.1.tar.gz 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python3-flask_oidc.noarch: W: no-manual-page-for-binary oidc-register 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- python3-flask_oidc (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-flask python3-itsdangerous python3-oauth2client python3-setuptools python3-six python2-flask_oidc (rpmlib, GLIBC filtered): python(abi) python-flask python-itsdangerous python-oauth2client python-setuptools python-six Provides -------- python3-flask_oidc: python3-flask_oidc python2-flask_oidc: python-flask_oidc python2-flask_oidc
updated the sources for each should be the same but here it is again Spec URL: https://github.com/skrzepto/flask-oidc/raw/rpm-packaging/python-flask-oidc.spec SRPM URL: https://github.com/skrzepto/flask-oidc/raw/rpm-packaging/python-flask-oidc-1.0.1-1.fc23.src.rpm new koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14452949 git diff: https://github.com/skrzepto/flask-oidc/commit/61e914488e93dbcd4d1020151890bdea98582c8e
Forgot to mention that i adjusted the name of the python_provides since i noticed it was coming out as "python3-flask_oidc" when i wanted "python3-flask-oidc"
Looks god for me, package aproved
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-flask-oidc