Red Hat Bugzilla – Bug 134197
joerc and messages i18n not completely
Last modified: 2007-11-30 17:10:50 EST
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; zh-TW; rv:1.7.3) Gecko/20040922 Description of problem: has not introduced gettext function in source. messages should be excluded from joerc. utf-8 coded help messages will not be displayed. Version-Release number of selected component (if applicable): joe-3.1 How reproducible: Always Steps to Reproduce: 1.joe /etc/joe/joerc 2.change some help messages with utf8 coded text 3.joe -help Actual Results: literal utf8 messages Expected Results: correctly interpreted messages Additional info:
So, this is only with the help dialog box, right?
Also, could you attach a joerc which causes problems for me?
Created attachment 104638 [details] Screenshot
Created attachment 104639 [details] joerc exhibiting behavior
Upstream bug for tracking: http://sourceforge.net/tracker/index.php?func=detail&aid=1038643&group_id=23475&atid=378598
Created attachment 104645 [details] Patch attempt #1 This patch causes joe to decode the help text output prior to displaying and counts one UTF-8 glyph as one char for screen size purposes.
The 'int ret' variable isn't used in that patch. However, the rest should work. Building new package; state -> MODIFIED
This should appear in rawhide as joe-3.1-5
Created attachment 104697 [details] screen from joe-3.1-3
Created attachment 104698 [details] joerc for last comment
also suggest include gettext patch from markx_sk in sourceforge. and then exclude help message from joerc into src.
The gettext patch is for joe-2.9.8, and does not apply very well to 3.1. When a newer version of the patch is built, I'll look in to it.
Created attachment 104774 [details] screenshot from joe-3.1-5 better than joe-3.1-3, but still not complete :(
in terminal, the width of each CJK glyph equal two letters. could it be the reason, which also sometime causes broken CJK glyphs in the main edit pane?
I don't think there's a clean way to determine the proper width of the glyph as it's rendered on the screen, but I think the effect that would have would be to display the whole glyph (and move the edge off the screen) in this case. I'll do more looking.
Wait, yes there is. joe_wcwidth()...
Created attachment 104786 [details] New screenshot with real fix. Screenshot from 3.1-6 patch.
Created attachment 104787 [details] Joerc with correct "CURSOR" width in help section (fixes formatting from old joercs)
Created attachment 104788 [details] New patch for joe-3.1-6 This fixes the previous patch's lack of correct character width support.
Patch submitted upstream: https://sourceforge.net/tracker/index.php?func=detail&aid=1040797&group_id=23475&atid=378600
Created attachment 104982 [details] joerc with help messages for zh_TW.UTF-8 here is another joerc. before taking a gettext patch, could you make a i18n joerc higher priority? that is, joe looks for: 1. $HOME/.joerc.$LANG 2. $HOME/.joerc 3. /etc/joe/joerc.$LANG 4. /etc/joe/joerc
I was not going to take the gettext patch. The patch is against 2.9.8, and 3.1 is *very* different from 2.9.8 (such as, 2.9.8 does not have UTF-8 support). I'm going to submit joerc.zh_TW.UTF-8 upstream. All of the other text files need to be converted to all the different languages too (jpicorc, jmacsrc, etc.).
The author of joe is going to create a contrib directory and place the joerc.zj_TW.UTF-8 there. He's also got it on his roadmap to implement gettext support. Apparently, others are working on separating the help text out of joerc so that it can be internationalized as well. As others are already working on this, I'm closing this 'UPSTREAM'.