Spec URL: https://jskladan.fedorapeople.org/python-mongoquery/python-mongoquery.spec SRPM URL: https://jskladan.fedorapeople.org/python-mongoquery/python-mongoquery-1.1.0-1.fc23.src.rpm Description: Hi, I just finished packaging python-mongoquery, that is needed for a future and better version of Fedora QA's Taskotron Trigger, and I'd appreciate a review. Python-mongoquery is an utility library that provides a MongoDB-like query language for querying Python collections. It's mainly intended to parse objects structured as fundamental types in a similar fashion to what is produced by JSON or YAML parsers. It follows the specification of queries for MongoDB version 3.2. Fedora Account System Username: jskladan
Hello Josef. I am not a packager, so this review is only *informal*, but everything looks good to me. Koji builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=14578993 and http://koji.fedoraproject.org/koji/taskinfo?taskID=14579013 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/lbalhar/Review/1342063-python-mongoquery/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/lbalhar/Review/1342063-python- mongoquery/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-mongoquery , python3-mongoquery [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-mongoquery-1.1.0-1.fc24.noarch.rpm python3-mongoquery-1.1.0-1.fc24.noarch.rpm python-mongoquery-1.1.0-1.fc24.src.rpm python2-mongoquery.noarch: W: spelling-error Summary(en_US) mongodb -> mongoloid python2-mongoquery.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python3-mongoquery.noarch: W: spelling-error Summary(en_US) mongodb -> mongoloid python3-mongoquery.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python-mongoquery.src: W: spelling-error Summary(en_US) mongodb -> mongoloid python-mongoquery.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python2-mongoquery (rpmlib, GLIBC filtered): python(abi) python3-mongoquery (rpmlib, GLIBC filtered): python(abi) Provides -------- python2-mongoquery: python-mongoquery python2-mongoquery python3-mongoquery: python3-mongoquery
Hello. I am the packager now so I can do a formal review. Everything looks good to me as before but I have one suggestion. I think that you could be more specific in %file section and replace > %{python2_sitelib}/* with > %{python2_sitelib}/%{srcname}/ > %{python2_sitelib}/%{srcname}-%{version}-py%{python2_version}.egg-info/ Could you please do this small change? Rest of review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/lbalhar/Review/1342063-python- mongoquery/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-mongoquery , python3-mongoquery [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-mongoquery-1.1.0-1.fc25.noarch.rpm python3-mongoquery-1.1.0-1.fc25.noarch.rpm python-mongoquery-1.1.0-1.fc25.src.rpm python2-mongoquery.noarch: W: spelling-error Summary(en_US) mongodb -> mongoloid python2-mongoquery.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python3-mongoquery.noarch: W: spelling-error Summary(en_US) mongodb -> mongoloid python3-mongoquery.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python-mongoquery.src: W: spelling-error Summary(en_US) mongodb -> mongoloid python-mongoquery.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- python2-mongoquery.noarch: W: spelling-error Summary(en_US) mongodb -> mongoloid python2-mongoquery.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python3-mongoquery.noarch: W: spelling-error Summary(en_US) mongodb -> mongoloid python3-mongoquery.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python2-mongoquery (rpmlib, GLIBC filtered): python(abi) python3-mongoquery (rpmlib, GLIBC filtered): python(abi) Provides -------- python2-mongoquery: python-mongoquery python2-mongoquery python2.7dist(mongoquery) python3-mongoquery: python3-mongoquery python3.5dist(mongoquery) Source checksums ---------------- https://github.com/kapouille/mongoquery/archive/v1.1.0.tar.gz : CHECKSUM(SHA256) this package : d1e87f6038ea074273610b6258e5af7477de61c782f6424fc7ecf3416df3e645 CHECKSUM(SHA256) upstream package : d1e87f6038ea074273610b6258e5af7477de61c782f6424fc7ecf3416df3e645 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1342063 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
> Source0: https://github.com/kapouille/%{srcname}/archive/v%{version}.tar.gz -> Source0: %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz > BuildRequires: python2-devel python3-devel python-nose python3-nose split those to subpackages and replace python-nose with python2-nose > %if 0%{?rhel} && 0%{?rhel} <= 6 > %{!?__python2: %global __python2 /usr/bin/python} > %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} > %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} > %endif You don't build this package for RHEL6 and below, so drop it. > %if ! 0%{?rhel} || 0%{?rhel} > 6 same > %global sum A python implementation of mongodb queries move this to `Summary` tag and use further as %{summary}. > Group: Development/Languages drop it > License: Unlicense not sure if it's valid license (just check on licensing wikipage) Also it would be better if you will do: %global _description \ .... and then for each package do: %description -n python3-%{srcname} %{_description} Python 3 version.
Hello Josef. Is there any problem with suggested changes? Can I help you with something? Have a nice day. Lumir
Lumír, sorry for the late reply, /me missed the emails in the tons of Bugzilla stuff in inbox. Thank you for the suggestions, and review. I updated the specfile at the original location: Spec URL: https://jskladan.fedorapeople.org/python-mongoquery/python-mongoquery.spec SRPM URL: https://jskladan.fedorapeople.org/python-mongoquery/python-mongoquery-1.1.0-1.fc23.src.rpm Hope those will be fine now, and thank you once again. Josef
Specfile looks good to me, thank you. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15285712 Package approved!
Since we, Fedora QA, need the package in Fedora (we'll be using it in taskotron-trigger) and Josef is not a packager, we decided that I'll be taking over the package. Hope that's fine, thanks.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-mongoquery
python-mongoquery-1.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5964bac1e2
python-mongoquery-1.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-36d5d5faa5
python-mongoquery-1.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9d21e40faa
python-mongoquery-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5964bac1e2
python-mongoquery-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-36d5d5faa5
python-mongoquery-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9d21e40faa
python-mongoquery-1.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-mongoquery-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-mongoquery-1.1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.