Bug 1342687 - Review Request: python2-backports-ssl-match-hostname - The ssl match_hostname() function from Python 3.5
Summary: Review Request: python2-backports-ssl-match-hostname - The ssl match_hostname...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1342688
TreeView+ depends on / blocked
 
Reported: 2016-06-03 22:07 UTC by William Moreno
Modified: 2016-08-25 01:32 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-25 01:32:11 UTC
Type: ---
Embargoed:
loganjerry: fedora-review?


Attachments (Terms of Use)

Description William Moreno 2016-06-03 22:07:10 UTC
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-backports-ssl-match-hostname.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-backports.ssl_match_hostname-3.5.0.1-0.fc25.src.rpm
Description: The ssl match_hostname() function from Python 3.5
Fedora Account System Username: williamjmorenor

Comment 1 Jerry James 2016-06-04 19:35:52 UTC
I will take this review.  Immediate problem:

$ fedora-review -b 1342687 -m fedora-rawhide-x86_64
INFO: Processing bugzilla bug: 1342687

...

ERROR: No specfile found in srpm: python-backports.ssl_match_hostname-3.5.0.1-0.fc25.src.rpm

There is a spec file in that SRPM, but its name does not end with ".spec".  Can you fix that, please?  It should be named python-backports-ssl-match-hostname.spec.

Comment 2 William Moreno 2016-06-22 19:45:37 UTC
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python2-backports-ssl-match-hostname.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python2-backports-ssl-match-hostname-3.5.0.1-2.fc25.src.rpm

- Drop python2 subpackage, remane spec to \
   python2-backports-ssl-match-hostname

Comment 3 William Moreno 2016-06-22 19:46:33 UTC
I have a issue, upstream git repo do not provide a License or any docs, will requets to upstream

Comment 5 Jerry James 2016-06-30 02:24:57 UTC
Isn't backports.ssl_match_hostname/backports/ssl_match_hostname/LICENSE.txt the license file?  Anyway, I've just noticed that this package already exists in Fedora: https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-ssl_match_hostname/.

Comment 6 Jerry James 2016-08-25 01:32:11 UTC
Closing this bug since the package already exists in Fedora.


Note You need to log in before you can comment on or make changes to this bug.