Bug 1342753 - Image Transfer - authorizing once to reduce overhead in UI and proxy
Summary: Image Transfer - authorizing once to reduce overhead in UI and proxy
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.2.1
: ---
Assignee: Daniel Erez
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-04 19:13 UTC by Greg Padgett
Modified: 2018-02-12 11:58 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-12 11:58:19 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: ovirt-4.3+
rule-engine: planning_ack+
tnisan: devel_ack+
ratamir: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 58624 0 master ABANDONED proxy: Return the session id in the http response 2017-05-07 01:57:21 UTC
oVirt gerrit 58625 0 master ABANDONED webadmin: Send session id to Image Upload proxy if available 2016-11-13 01:56:22 UTC
oVirt gerrit 85450 0 master MERGED core: extract add image ticket logic to a method 2017-12-26 10:02:59 UTC
oVirt gerrit 85451 0 master MERGED core: PUT request to image proxy for adding a ticket 2017-12-26 11:43:46 UTC
oVirt gerrit 85452 0 master MERGED core: extract remove image ticket logic to a method 2017-12-26 13:40:23 UTC
oVirt gerrit 85453 0 master MERGED core: DELETE request to image proxy for removing a ticket 2017-12-26 13:40:29 UTC
oVirt gerrit 85454 0 master MERGED webadmin: remove start session logic from DownloadImageHandler 2017-12-26 13:40:34 UTC
oVirt gerrit 85455 0 master MERGED webadmin: remove authorization header from UploadImageHandler 2017-12-26 13:40:43 UTC

Description Greg Padgett 2016-06-04 19:13:46 UTC
Description of problem:
When a request to the Image Upload proxy is made, WebAdmin generates a 
new signed ticket and sends it in the Authorization header of the 
request.  This should only be done for the first request, as subsequent
requests can use the session id that is sent by the proxy.  This will
reduce overhead in both the UI and the proxy.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Perform an Image Upload

(The headers are IMHO an implementation detail; verification can consist of "the upload works".  However, if you want to check the headers, you can look for the Authorization header being sent during each request either via the browser's development tools or the proxy debug log.)

Actual results:
The Authorization header is sent every request, and no X-Session-Id header is sent.

Expected results:
The first request should result in an Authorization header; subsequent requests should send the X-Session-Id header instead.

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2016-06-05 09:14:00 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 3 Allon Mureinik 2017-09-03 14:33:56 UTC
Daniel, is this still relevant?

Comment 4 Daniel Erez 2017-09-03 16:24:03 UTC
(In reply to Allon Mureinik from comment #3)
> Daniel, is this still relevant?

Relevant, but can be moved to 4.3. Not much gain here.

Comment 5 Natalie Gavrielov 2018-02-05 15:03:52 UTC
Verified, using:
rhvm-4.2.1.4-0.1.el7.noarch
ovirt-imageio-proxy-1.2.1-0.el7ev.noarch
ovirt-imageio-common-1.2.1-0.el7ev.noarch

* Upload image works.
* image-proxy.log doesn't show _create_update_session and _decode_proxy_ticket anymore.

Comment 6 Sandro Bonazzola 2018-02-12 11:58:19 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.