Bug 1343136 - The fedora:23 base image ships service configuration in /etc/systemd/system
Summary: The fedora:23 base image ships service configuration in /etc/systemd/system
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: spin-kickstarts
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeroen van Meeuwen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-06 15:17 UTC by Jan Pazdziora
Modified: 2016-11-27 13:26 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-26 18:15:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jan Pazdziora 2016-06-06 15:17:42 UTC
Description of problem:

The fedora:23 image contains /etc/systemd/system/dbus.service. Since the image is a vendor content, it should not contain such modifications that are reserved for admin's local changes.

Version-Release number of selected component (if applicable):

fedora:23
fedora:rawhide

How reproducible:

Deterministic.

Steps to Reproduce:
1. $ docker run --rm -ti fedora:23 cat /etc/systemd/system/dbus.service

Actual results:

[Unit]
Description=D-Bus System Message Bus
Documentation=man:dbus-daemon(1)
Requires=dbus.socket

[Service]
ExecStart=/usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation
ExecReload=/usr/bin/dbus-send --print-reply --system --type=method_call --dest=org.freedesktop.DBus / org.freedesktop.DBus.ReloadConfig

Expected results:

cat: /etc/systemd/system/dbus.service: No such file or directory

Additional info:

 The man systemd.unit(5) says

       Along with a unit file foo.service, a directory foo.service.d/ may
       exist. All files with the suffix ".conf" from this directory will be
       parsed after the file itself is parsed. This is useful to alter or add
       configuration settings to a unit, without having to modify their unit
       files.

and also includes

       │/etc/systemd/system     │ Local configuration │
       ├────────────────────────┼─────────────────────┤
       │/run/systemd/system     │ Runtime units       │
       ├────────────────────────┼─────────────────────┤
       │/usr/lib/systemd/system │ Units of installed  │
       │                        │ packages            │

 The file seems to be generated by

+#Make it easier for systemd to run in Docker container
+cp /usr/lib/systemd/system/dbus.service /etc/systemd/system/
+sed -i 's/OOMScoreAdjust=-900//' /etc/systemd/system/dbus.service

I recommend putting the OOMScoreAdjust reset to /usr, using something like

( echo '[Service]' ; echo OOMScoreAdjust=0 ) > /usr/lib/systemd/system/dbus.service.d/nooomscoreadjust.conf

Alternatively just removing those lines that create /etc/systemd/system/dbus.service altogether might work -- I did not see any issues running systemd with dbus on Fedora 23 with fedora:23 image with /etc/systemd/system/dbus.service removed. 

This is a copy of https://fedorahosted.org/spin-kickstarts/ticket/61.

Comment 1 Kevin Fenzi 2016-06-06 22:04:11 UTC
Would you be willing to submit a PR on this? 

Is this change ok with the cloud sig?

Comment 2 Jan Pazdziora 2016-06-07 07:55:13 UTC
Filed https://pagure.io/fedora-kickstarts/pull-request/28.

I did not talk to the cloud sig.

Comment 3 Jan Pazdziora 2016-09-20 16:28:18 UTC
On fedora:rawhide, things seem fixed now:

$ docker images fedora:rawhide
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
docker.io/fedora    rawhide             3bcdeb6ee43b        5 weeks ago         174 MB
$ docker run --rm -ti fedora:rawhide cat /etc/systemd/system/dbus.service
cat: /etc/systemd/system/dbus.service: No such file or directory
$

Comment 4 Jan Pazdziora 2016-09-20 16:29:59 UTC
Filed another pull request for fedora:24:

https://pagure.io/fedora-kickstarts/pull-request/62

Comment 5 Fedora End Of Life 2016-11-25 09:13:35 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Jan Pazdziora 2016-11-25 14:15:44 UTC
Issue still present on fedora:24 image:

# docker run --rm -ti fedora:24 cat /etc/systemd/system/dbus.service
[Unit]
Description=D-Bus System Message Bus
Documentation=man:dbus-daemon(1)
Requires=dbus.socket

[Service]
ExecStart=/usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation
ExecReload=/usr/bin/dbus-send --print-reply --system --type=method_call --dest=org.freedesktop.DBus / org.freedesktop.DBus.ReloadConfig

Comment 7 Dusty Mabe 2016-11-26 02:55:41 UTC
Not a problem in F25:

-bash-4.3# docker run --rm -ti fedora:25 cat /etc/systemd/system/dbus.service
cat: /etc/systemd/system/dbus.service: No such file or directory

Comment 8 Kevin Fenzi 2016-11-26 18:15:15 UTC
Yeah, will close this now... if we need f24 images fixed, I think we need a releng ticket to ask for a new compose there (as we don't usually do regular composes after release).

Comment 9 Jan Pazdziora 2016-11-27 13:26:58 UTC
(In reply to Kevin Fenzi from comment #8)
> Yeah, will close this now... if we need f24 images fixed, I think we need a
> releng ticket to ask for a new compose there (as we don't usually do regular
> composes after release).

Well, the latest fedora:24 image was built 11 days ago (f623aaef07f0). The https://pagure.io/fedora-kickstarts/pull-request/62 was merged two months ago.

I'm really concerned about the process, that while merged, it was not used with the latest respin.

Also, I thought the plan was to do image repins every two weeks or so ...


Note You need to log in before you can comment on or make changes to this bug.