Bug 1343208 - Review Request: xfce4-hotcorner-plugin - XFCE4 HotCorner Panel Plugin
Summary: Review Request: xfce4-hotcorner-plugin - XFCE4 HotCorner Panel Plugin
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: William Moreno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2016-06-06 19:50 UTC by davideoli87
Modified: 2016-11-03 08:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 08:21:13 UTC
Type: ---
Embargoed:
williamjmorenor: fedora-review?


Attachments (Terms of Use)

Description davideoli87 2016-06-06 19:50:16 UTC
Spec URL: https://www.dropbox.com/s/cegh3cqxhgr8khd/xfce4-hotcorner-plugin.spec
SRPM URL: https://www.dropbox.com/s/0fpw33dgg6701gv/xfce4-hotcorner-plugin-0.0.2-1.fc23.src.rpm
Description: 

"This plugin aims to provide an easy to use xfce4 panel plugin that lets users set hot corner actions."

This is my first package. I am currently looking for a sponsor within the Fedora community in order to become a package maintainer.

Fedora Account System Username: davideoli

Comment 1 William Moreno 2016-06-06 23:19:16 UTC
Hello I will take your fedora-review request and become your mentor to become a fedora package maintainer.

Currently the spec and the source rpm are available via http, I will recomend to ask about access to fedora people to upload your files:

https://fedorahosted.org/packager-sponsors/

Examples:
https://fedorahosted.org/packager-sponsors/ticket/237
https://fedorahosted.org/packager-sponsors/ticket/240
https://fedorahosted.org/packager-sponsors/ticket/233

Also you can upload your files to a repo in github

Comment 2 davideoli87 2016-06-07 07:14:53 UTC
Hi William,

Thank you for helping and taking ownership of the review.

I have requested access to fedorapeople.org as advised by you (ticket #279).

Davide

Comment 3 William Moreno 2016-06-15 21:18:04 UTC
Looks like the responsible of aprobe the access to fedora people is not available.

Any way you can host your spec and src.rpm in a repo corp or in a github repo.

Also I will like to see some informal reviews please.

Comment 4 davideoli87 2016-06-16 10:10:21 UTC
Hi William,

Thank you.

I uploaded the files to github:

git clone https://github.com/davideoli/packages/

What do you mean by informal reviews?

Cheers,
Davide

Comment 5 William Moreno 2016-06-21 17:26:31 UTC
Spec URL: https://github.com/davideoli/packages/raw/master/xfce4-hotcorner-plugin.spec
SRPM URL: https://github.com/davideoli/packages/raw/master/xfce4-hotcorner-plugin-0.0.2-1.fc23.src.rpm

Please always use the Spec URL and SRPM URL format, with informal reviews I mean than you look at others reviews request and make some comments on.

You can see some examples in Jeremy Cline informal reviews here:

https://fedoraproject.org/wiki/User:Williamjmorenor/reviews

Comment 6 fszymanski 2016-06-24 20:33:23 UTC
Hi,

Please use a full source URL (Source0).

Example:
%global gittag 0.0.2

Source0: https://github.com/brianhsu/%{name}/archive/%{gittag}.tar.gz#/%{name}-%{version}.tar.gz

See: https://fedoraproject.org/wiki/Packaging:SourceURL

If your application is written in C you must list a BuildRequires against gcc.

Example:
BuildRequires: gcc

See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

Comment 7 davideoli87 2016-06-24 22:30:02 UTC
Hi Filip,

Thanks for your comments and wiki articles.

I amended the SPEC and source rpm files on git following your recommendations.

Thanks a lot.

Cheers,
Davide


Note You need to log in before you can comment on or make changes to this bug.