Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/843b082beffc9988daea7898b7401a7c6f42bd99/cassandra-cpp-driver/cassandra-cpp-driver.spec SRPM URL: http://rpms.remirepo.net/SRPMS/cassandra-cpp-driver-2.4.0-1.remi.src.rpm Description: DataStax C/C++ Driver for Apache Cassandra. A modern, feature-rich, and highly tunable C/C++ client library for Apache Cassandra (1.2+) and DataStax Enterprise (3.1+) using exclusively Cassandra's native protocol and Cassandra Query Language v3. Fedora Account System Username: remi
minor fix, change URL Spec: https://raw.githubusercontent.com/remicollet/remirepo/842c5e47b08537e540ae0f57b961c8013c30ccb0/cassandra-cpp-driver/cassandra-cpp-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/cassandra-cpp-driver-2.4.0-1.remi.src.rpm
Update to 2.4.1 Spec: https://raw.githubusercontent.com/remicollet/remirepo/a5e31786aca89ffd01d86853fee5194e0545f575/cassandra-cpp-driver/cassandra-cpp-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/cassandra-cpp-driver-2.4.1-1.remi.src.rpm
Hi, as I am not a packager, I just made an informal review to help others to make the official one. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)", "BSL (v1.0) Apache (v2.0)", "BSD (3 clause)", "BSD (2 clause)", "ISC", "Apache (v2.0) MIT/X11 (BSD like)". 67 files have unknown license. Detailed output of licensecheck in /home/tosykora/rpmbuild/SPECS /cassandra-cpp-driver/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 225280 bytes in 43 files. => See above. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: cassandra-cpp-driver-2.4.1-1.fc24.x86_64.rpm cassandra-cpp-driver-devel-2.4.1-1.fc24.x86_64.rpm cassandra-cpp-driver-debuginfo-2.4.1-1.fc24.x86_64.rpm cassandra-cpp-driver-2.4.1-1.fc24.src.rpm cassandra-cpp-driver.x86_64: W: spelling-error %description -l en_US tunable -> unable, tenable, t unable cassandra-cpp-driver.x86_64: W: no-documentation cassandra-cpp-driver-devel.x86_64: W: only-non-binary-in-usr-lib cassandra-cpp-driver.src: W: spelling-error %description -l en_US tunable -> unable, tenable, t unable 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: cassandra-cpp-driver-debuginfo-2.4.1-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- cassandra-cpp-driver (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libuv.so.1()(64bit) rtld(GNU_HASH) cassandra-cpp-driver-debuginfo (rpmlib, GLIBC filtered): cassandra-cpp-driver-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cassandra-cpp-driver(x86-64) libcassandra.so.2()(64bit) Provides -------- cassandra-cpp-driver: cassandra-cpp-driver cassandra-cpp-driver(x86-64) libcassandra.so.2()(64bit) cassandra-cpp-driver-debuginfo: cassandra-cpp-driver-debuginfo cassandra-cpp-driver-debuginfo(x86-64) cassandra-cpp-driver-devel: cassandra-cpp-driver-devel cassandra-cpp-driver-devel(x86-64) pkgconfig(cassandra) Source checksums ---------------- https://github.com/datastax/cpp-driver/archive/468db35af8875930d424395808ddc9523c57c6f2/cpp-driver-2.4.1-468db35.tar.gz : CHECKSUM(SHA256) this package : 361f244b3a4b336464ba54b4ef0b804410228544a2700d64e5ea6f3e3ec97157 CHECKSUM(SHA256) upstream package : 361f244b3a4b336464ba54b4ef0b804410228544a2700d64e5ea6f3e3ec97157 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -r -n ../../Downloads/cassandra-cpp-driver-2.4.1-1.remi.src.rpm Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Update to 2.4.2: https://github.com/remicollet/remirepo/commit/d0548e86bfdf1c0ed7564e794a75fbbfd15cc652 Spec: https://raw.githubusercontent.com/remicollet/remirepo/d0548e86bfdf1c0ed7564e794a75fbbfd15cc652/cassandra-cpp-driver/cassandra-cpp-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/cassandra-cpp-driver-2.4.2-1.remi.src.rpm
Update to 2.4.3: https://github.com/remicollet/remirepo/commit/35a211f7408ea5795c18faff59adf3ceac5419bc Spec: https://raw.githubusercontent.com/remicollet/remirepo/35a211f7408ea5795c18faff59adf3ceac5419bc/cassandra-cpp-driver/cassandra-cpp-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/cassandra-cpp-driver-2.4.3-1.remi.src.rpm
Update to 2.5.0:https://github.com/remicollet/remirepo/commit/df179a6c249eab249557b213ed826ae0dd8e12ab Spec: https://raw.githubusercontent.com/remicollet/remirepo/df179a6c249eab249557b213ed826ae0dd8e12ab/cassandra-cpp-driver/cassandra-cpp-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/cassandra-cpp-driver-2.5.0-1.remi.src.rpm
6 months old. So, it seems nobody cares And Broken bulid with GCC 7 and OpenSSL 1.1 https://datastax-oss.atlassian.net/browse/CPP-438